[GitHub] [arrow] bkietz commented on a change in pull request #7748: ARROW-9388: [C++] Division kernels

2020-08-18 Thread GitBox
bkietz commented on a change in pull request #7748: URL: https://github.com/apache/arrow/pull/7748#discussion_r472240168 ## File path: cpp/src/arrow/compute/kernels/scalar_arithmetic.cc ## @@ -186,6 +187,42 @@ struct MultiplyChecked { } }; +struct Divide { + template +

[GitHub] [arrow] bkietz commented on a change in pull request #7748: ARROW-9388: [C++] Division kernels

2020-08-13 Thread GitBox
bkietz commented on a change in pull request #7748: URL: https://github.com/apache/arrow/pull/7748#discussion_r469934580 ## File path: cpp/src/arrow/compute/kernels/scalar_arithmetic.cc ## @@ -186,6 +187,42 @@ struct MultiplyChecked { } }; +struct Divide { + template +

[GitHub] [arrow] bkietz commented on a change in pull request #7748: ARROW-9388: [C++] Division kernels

2020-07-14 Thread GitBox
bkietz commented on a change in pull request #7748: URL: https://github.com/apache/arrow/pull/7748#discussion_r454610972 ## File path: cpp/src/arrow/compute/kernels/codegen_internal.h ## @@ -675,11 +704,80 @@ struct ScalarBinary { } }; +// An alternative to ScalarBinary