[GitHub] [arrow] cyb70289 commented on a change in pull request #8637: ARROW-10021: [C++][Compute] Return top-n modes in mode kernel

cyb70289 commented on a change in pull request #8637: URL: https://github.com/apache/arrow/pull/8637#discussion_r521973124 ## File path: docs/source/cpp/compute.rst ## @@ -140,7 +140,7 @@ Aggregations

[GitHub] [arrow] cyb70289 commented on a change in pull request #8637: ARROW-10021: [C++][Compute] Return top-n modes in mode kernel

cyb70289 commented on a change in pull request #8637: URL: https://github.com/apache/arrow/pull/8637#discussion_r521865256 ## File path: cpp/src/arrow/compute/kernels/aggregate_mode.cc ## @@ -205,35 +243,59 @@ struct ModeImpl : public ScalarAggregator {

[GitHub] [arrow] cyb70289 commented on a change in pull request #8637: ARROW-10021: [C++][Compute] Return top-n modes in mode kernel

cyb70289 commented on a change in pull request #8637: URL: https://github.com/apache/arrow/pull/8637#discussion_r521865178 ## File path: cpp/src/arrow/compute/kernels/aggregate_mode.cc ## @@ -28,6 +29,9 @@ namespace internal { namespace { +constexpr char kModeFieldName[]

[GitHub] [arrow] cyb70289 commented on a change in pull request #8637: ARROW-10021: [C++][Compute] Return top-n modes in mode kernel

cyb70289 commented on a change in pull request #8637: URL: https://github.com/apache/arrow/pull/8637#discussion_r521865103 ## File path: cpp/src/arrow/compute/api_aggregate.h ## @@ -76,6 +76,18 @@ struct ARROW_EXPORT MinMaxOptions : public FunctionOptions { enum Mode

[GitHub] [arrow] cyb70289 commented on a change in pull request #8637: ARROW-10021: [C++][Compute] Return top-n modes in mode kernel

cyb70289 commented on a change in pull request #8637: URL: https://github.com/apache/arrow/pull/8637#discussion_r521776788 ## File path: docs/source/cpp/compute.rst ## @@ -140,7 +140,7 @@ Aggregations