[GitHub] [arrow] emkornfield commented on a change in pull request #10203: ARROW-5385: [Go] Implement EXTENSION datatype

2021-05-12 Thread GitBox
emkornfield commented on a change in pull request #10203: URL: https://github.com/apache/arrow/pull/10203#discussion_r631180370 ## File path: go/arrow/datatype_extension.go ## @@ -0,0 +1,163 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contribut

[GitHub] [arrow] emkornfield commented on a change in pull request #10203: ARROW-5385: [Go] Implement EXTENSION datatype

2021-05-11 Thread GitBox
emkornfield commented on a change in pull request #10203: URL: https://github.com/apache/arrow/pull/10203#discussion_r630327365 ## File path: go/arrow/internal/testing/types/extension_types.go ## @@ -0,0 +1,247 @@ +// Licensed to the Apache Software Foundation (ASF) under one +

[GitHub] [arrow] emkornfield commented on a change in pull request #10203: ARROW-5385: [Go] Implement EXTENSION datatype

2021-05-11 Thread GitBox
emkornfield commented on a change in pull request #10203: URL: https://github.com/apache/arrow/pull/10203#discussion_r630321847 ## File path: go/arrow/datatype_extension.go ## @@ -0,0 +1,163 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contribut

[GitHub] [arrow] emkornfield commented on a change in pull request #10203: ARROW-5385: [Go] Implement EXTENSION datatype

2021-05-11 Thread GitBox
emkornfield commented on a change in pull request #10203: URL: https://github.com/apache/arrow/pull/10203#discussion_r630316132 ## File path: go/arrow/compare_test.go ## @@ -27,7 +27,7 @@ func TestTypeEqual(t *testing.T) { checkMetadata bool }{

[GitHub] [arrow] emkornfield commented on a change in pull request #10203: ARROW-5385: [Go] Implement EXTENSION datatype

2021-05-11 Thread GitBox
emkornfield commented on a change in pull request #10203: URL: https://github.com/apache/arrow/pull/10203#discussion_r630315454 ## File path: go/arrow/compare.go ## @@ -46,34 +46,45 @@ func TypeEqual(left, right DataType, opts ...TypeEqualOption) bool { switch {

[GitHub] [arrow] emkornfield commented on a change in pull request #10203: ARROW-5385: [Go] Implement EXTENSION datatype

2021-05-11 Thread GitBox
emkornfield commented on a change in pull request #10203: URL: https://github.com/apache/arrow/pull/10203#discussion_r630311178 ## File path: go/arrow/array/extension.go ## @@ -0,0 +1,236 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor