[GitHub] [arrow] emkornfield commented on pull request #7979: ARROW-9766: [C++][Parquet] Add EngineVersion for toggling between new and old logic

2020-09-12 Thread GitBox
emkornfield commented on pull request #7979: URL: https://github.com/apache/arrow/pull/7979#issuecomment-690915801 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [arrow] emkornfield commented on pull request #7979: ARROW-9766: [C++][Parquet] Add EngineVersion for toggling between new and old logic

2020-09-12 Thread GitBox
emkornfield commented on pull request #7979: URL: https://github.com/apache/arrow/pull/7979#issuecomment-690915801 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [arrow] emkornfield commented on pull request #7979: ARROW-9766: [C++][Parquet] Add EngineVersion for toggling between new and old logic

2020-09-11 Thread GitBox
emkornfield commented on pull request #7979: URL: https://github.com/apache/arrow/pull/7979#issuecomment-690915801 Going to close this as its been demonstrated existing implementations probably have bugs so, I'm going to focus on a replacing instead of adding code.

[GitHub] [arrow] emkornfield commented on pull request #7979: ARROW-9766: [C++][Parquet] Add EngineVersion for toggling between new and old logic

2020-08-18 Thread GitBox
emkornfield commented on pull request #7979: URL: https://github.com/apache/arrow/pull/7979#issuecomment-675842493 actually, change might be invasive enough that this probably won't mitigate risk, we can hold off until I get a little further.

[GitHub] [arrow] emkornfield commented on pull request #7979: ARROW-9766: [C++][Parquet] Add EngineVersion for toggling between new and old logic

2020-08-18 Thread GitBox
emkornfield commented on pull request #7979: URL: https://github.com/apache/arrow/pull/7979#issuecomment-675817406 @pitrou that is the plan, but since there will be a decent amount of new code, I think it is worth-while to provide the option. Once the new engine is implemented that will