[GitHub] [arrow] jorgecarleitao edited a comment on pull request #8645: ARROW-10561: [Rust] Simplified Buffer's `write` and `write_bytes` and fixed undefined behavior

2020-11-13 Thread GitBox
jorgecarleitao edited a comment on pull request #8645: URL: https://github.com/apache/arrow/pull/8645#issuecomment-726756578 Thanks a lot, @alamb , really useful data points ❤️ For me that is enough of a reason: fix UB with `safe` code, and figure out a way to perform multi-bit

[GitHub] [arrow] jorgecarleitao edited a comment on pull request #8645: ARROW-10561: [Rust] Simplified Buffer's `write` and `write_bytes` and fixed undefined behavior

2020-11-12 Thread GitBox
jorgecarleitao edited a comment on pull request #8645: URL: https://github.com/apache/arrow/pull/8645#issuecomment-726510728 Ok, I confirm that this error is due to a wrong pointer offset on the `set_bits_raw` and that this undefined behavior is already present in `master`: ```

[GitHub] [arrow] jorgecarleitao edited a comment on pull request #8645: ARROW-10561: [Rust] Simplified Buffer's `write` and `write_bytes` and fixed undefined behavior

2020-11-12 Thread GitBox
jorgecarleitao edited a comment on pull request #8645: URL: https://github.com/apache/arrow/pull/8645#issuecomment-726510728 Ok, I confirm that this error is due to a wrong pointer offset on the `set_bits_raw` and that this undefined behavior is already present in `master`: ```