[GitHub] [arrow] kszucs commented on pull request #7797: ARROW-4189: [Rust] Added coverage report.

2020-09-22 Thread GitBox
kszucs commented on pull request #7797: URL: https://github.com/apache/arrow/pull/7797#issuecomment-696598247 @jorgecarleitao could you rebase on top of the master? I'm unable to push to your fork, but the build failures should be resolved after a rebase. -

[GitHub] [arrow] kszucs commented on pull request #7797: ARROW-4189: [Rust] Added coverage report.

2020-09-18 Thread GitBox
kszucs commented on pull request #7797: URL: https://github.com/apache/arrow/pull/7797#issuecomment-694747857 Thanks @jorgecarleitao, it looks good to me. Just one nit, could you please add a coverage report link to the rust README to improve its visibilty? ---

[GitHub] [arrow] kszucs commented on pull request #7797: ARROW-4189: [Rust] Added coverage report.

2020-09-15 Thread GitBox
kszucs commented on pull request #7797: URL: https://github.com/apache/arrow/pull/7797#issuecomment-692822149 I thought that codecov looks for the CI specific environment variables, but if placing a `workdir: arrow` to the [codecov step](https://github.com/apache/arrow/pull/7797/files#diff

[GitHub] [arrow] kszucs commented on pull request #7797: ARROW-4189: [Rust] Added coverage report.

2020-09-15 Thread GitBox
kszucs commented on pull request #7797: URL: https://github.com/apache/arrow/pull/7797#issuecomment-692811492 @jorgecarleitao thanks for setting this up! I'm afraid the [codecov](https://github.com/apache/arrow/pull/7797/files#diff-65f11a6b56b838fa108262f1f2c3e65aR45) script picks u

[GitHub] [arrow] kszucs commented on pull request #7797: ARROW-4189: [Rust] Added coverage report.

2020-09-14 Thread GitBox
kszucs commented on pull request #7797: URL: https://github.com/apache/arrow/pull/7797#issuecomment-691980090 Seems like the template has [errors](https://github.com/ursa-labs/crossbow/actions/runs/253553399). You can take a look at the builds under the crossbow repository's [actions tab]

[GitHub] [arrow] kszucs commented on pull request #7797: ARROW-4189: [Rust] Added coverage report.

2020-09-14 Thread GitBox
kszucs commented on pull request #7797: URL: https://github.com/apache/arrow/pull/7797#issuecomment-691928331 @github-actions crossbow submit rust-coverage This is an automated message from the Apache Git Service. To respond