[GitHub] [arrow] kszucs edited a comment on pull request #7073: ARROW-8318: [C++][Dataset] Construct FileSystemDataset from fragments

2020-05-01 Thread GitBox
kszucs edited a comment on pull request #7073: URL: https://github.com/apache/arrow/pull/7073#issuecomment-62291 > * Simplified FileSystemDataset to hold a FragmentVector. Each Fragment must be a FileFragment and is checked at `FileSystemDataset::Make`. Fragments are not required to

[GitHub] [arrow] kszucs edited a comment on pull request #7073: ARROW-8318: [C++][Dataset] Construct FileSystemDataset from fragments

2020-05-01 Thread GitBox
kszucs edited a comment on pull request #7073: URL: https://github.com/apache/arrow/pull/7073#issuecomment-62291 > Fragments are not required to use the same backing filesystem nor the same format. This makes me wonder, why do we need FileSystemDataset and/or UnionDataset at