[GitHub] [arrow] mr-smidge commented on a change in pull request #7654: ARROW-8581: [C#] Accept and return DateTime from DateXXArray

2020-08-10 Thread GitBox
mr-smidge commented on a change in pull request #7654: URL: https://github.com/apache/arrow/pull/7654#discussion_r468233789 ## File path: csharp/src/Apache.Arrow/Arrays/Date64Array.cs ## @@ -15,56 +15,103 @@ using Apache.Arrow.Types; using System; -using

[GitHub] [arrow] mr-smidge commented on a change in pull request #7654: ARROW-8581: [C#] Accept and return DateTime from DateXXArray

2020-08-10 Thread GitBox
mr-smidge commented on a change in pull request #7654: URL: https://github.com/apache/arrow/pull/7654#discussion_r468233789 ## File path: csharp/src/Apache.Arrow/Arrays/Date64Array.cs ## @@ -15,56 +15,103 @@ using Apache.Arrow.Types; using System; -using

[GitHub] [arrow] mr-smidge commented on a change in pull request #7654: ARROW-8581: [C#] Accept and return DateTime from DateXXArray

2020-07-31 Thread GitBox
mr-smidge commented on a change in pull request #7654: URL: https://github.com/apache/arrow/pull/7654#discussion_r463888181 ## File path: csharp/test/Apache.Arrow.Tests/TestDateAndTimeData.cs ## @@ -0,0 +1,83 @@ +// Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [arrow] mr-smidge commented on a change in pull request #7654: ARROW-8581: [C#] Accept and return DateTime from DateXXArray

2020-07-31 Thread GitBox
mr-smidge commented on a change in pull request #7654: URL: https://github.com/apache/arrow/pull/7654#discussion_r463886892 ## File path: csharp/src/Apache.Arrow/Arrays/Date64Array.cs ## @@ -15,56 +15,103 @@ using Apache.Arrow.Types; using System; -using

[GitHub] [arrow] mr-smidge commented on a change in pull request #7654: ARROW-8581: [C#] Accept and return DateTime from DateXXArray

2020-07-21 Thread GitBox
mr-smidge commented on a change in pull request #7654: URL: https://github.com/apache/arrow/pull/7654#discussion_r458452083 ## File path: csharp/src/Apache.Arrow/Arrays/Date64Array.cs ## @@ -15,56 +15,94 @@ using Apache.Arrow.Types; using System; -using

[GitHub] [arrow] mr-smidge commented on a change in pull request #7654: ARROW-8581: [C#] Accept and return DateTime from DateXXArray

2020-07-20 Thread GitBox
mr-smidge commented on a change in pull request #7654: URL: https://github.com/apache/arrow/pull/7654#discussion_r457739938 ## File path: csharp/src/Apache.Arrow/Arrays/Date64Array.cs ## @@ -15,56 +15,94 @@ using Apache.Arrow.Types; using System; -using

[GitHub] [arrow] mr-smidge commented on a change in pull request #7654: ARROW-8581: [C#] Accept and return DateTime from DateXXArray

2020-07-20 Thread GitBox
mr-smidge commented on a change in pull request #7654: URL: https://github.com/apache/arrow/pull/7654#discussion_r457739938 ## File path: csharp/src/Apache.Arrow/Arrays/Date64Array.cs ## @@ -15,56 +15,94 @@ using Apache.Arrow.Types; using System; -using

[GitHub] [arrow] mr-smidge commented on a change in pull request #7654: ARROW-8581: [C#] Accept and return DateTime from DateXXArray

2020-07-17 Thread GitBox
mr-smidge commented on a change in pull request #7654: URL: https://github.com/apache/arrow/pull/7654#discussion_r456563263 ## File path: csharp/src/Apache.Arrow/Arrays/DelegatingArrayBuilder.cs ## @@ -0,0 +1,96 @@

[GitHub] [arrow] mr-smidge commented on a change in pull request #7654: ARROW-8581: [C#] Accept and return DateTime from DateXXArray

2020-07-17 Thread GitBox
mr-smidge commented on a change in pull request #7654: URL: https://github.com/apache/arrow/pull/7654#discussion_r456557697 ## File path: csharp/src/Apache.Arrow/Arrays/Date64Array.cs ## @@ -15,56 +15,94 @@ using Apache.Arrow.Types; using System; -using

[GitHub] [arrow] mr-smidge commented on a change in pull request #7654: ARROW-8581: [C#] Accept and return DateTime from DateXXArray

2020-07-17 Thread GitBox
mr-smidge commented on a change in pull request #7654: URL: https://github.com/apache/arrow/pull/7654#discussion_r456557817 ## File path: csharp/test/Apache.Arrow.Tests/Date32ArrayTests.cs ## @@ -20,28 +20,46 @@ namespace Apache.Arrow.Tests { public class

[GitHub] [arrow] mr-smidge commented on a change in pull request #7654: ARROW-8581: [C#] Accept and return DateTime from DateXXArray

2020-07-17 Thread GitBox
mr-smidge commented on a change in pull request #7654: URL: https://github.com/apache/arrow/pull/7654#discussion_r456557580 ## File path: csharp/src/Apache.Arrow/Arrays/Date64Array.cs ## @@ -15,56 +15,94 @@ using Apache.Arrow.Types; using System; -using

[GitHub] [arrow] mr-smidge commented on a change in pull request #7654: ARROW-8581: [C#] Accept and return DateTime from DateXXArray

2020-07-13 Thread GitBox
mr-smidge commented on a change in pull request #7654: URL: https://github.com/apache/arrow/pull/7654#discussion_r453675969 ## File path: csharp/src/Apache.Arrow/Arrays/DelegatingArrayBuilder.cs ## @@ -0,0 +1,96 @@

[GitHub] [arrow] mr-smidge commented on a change in pull request #7654: ARROW-8581: [C#] Accept and return DateTime from DateXXArray

2020-07-13 Thread GitBox
mr-smidge commented on a change in pull request #7654: URL: https://github.com/apache/arrow/pull/7654#discussion_r453673591 ## File path: csharp/src/Apache.Arrow/Arrays/DateArrayBuilder.cs ## @@ -0,0 +1,179 @@

[GitHub] [arrow] mr-smidge commented on a change in pull request #7654: ARROW-8581: [C#] Accept and return DateTime from DateXXArray

2020-07-13 Thread GitBox
mr-smidge commented on a change in pull request #7654: URL: https://github.com/apache/arrow/pull/7654#discussion_r453670993 ## File path: csharp/src/Apache.Arrow/Arrays/Date32Array.cs ## @@ -55,16 +70,39 @@ public Date32Array(ArrayData data) public override void