[GitHub] [arrow] nealrichardson commented on pull request #9586: ARROW-11704: [R] Wire up dplyr::mutate() for datasets

2021-03-05 Thread GitBox
nealrichardson commented on pull request #9586: URL: https://github.com/apache/arrow/pull/9586#issuecomment-791624414 > So now we have scalar recycling in `mutate()` for Datasets but not yet for Tables and RecordBatches, correct? Correct, that's ARROW-11705

[GitHub] [arrow] nealrichardson commented on pull request #9586: ARROW-11704: [R] Wire up dplyr::mutate() for datasets

2021-03-05 Thread GitBox
nealrichardson commented on pull request #9586: URL: https://github.com/apache/arrow/pull/9586#issuecomment-791602869 Thanks @ianmcook, fixed in https://github.com/apache/arrow/pull/9586/commits/3ac4086cd651411bb17409e726b7261c13347bf3, PTAL.

[GitHub] [arrow] nealrichardson commented on pull request #9586: ARROW-11704: [R] Wire up dplyr::mutate() for datasets

2021-03-04 Thread GitBox
nealrichardson commented on pull request #9586: URL: https://github.com/apache/arrow/pull/9586#issuecomment-791039254 I'll add a couple more tests, particularly around error handling, but I'd like to move on to other issues and get this merged so that others can test it out more widely.