[GitHub] [arrow] nevi-me commented on a change in pull request #8739: ARROW-10684: [Rust] Inherit struct nulls in child null equality

2020-11-27 Thread GitBox
nevi-me commented on a change in pull request #8739: URL: https://github.com/apache/arrow/pull/8739#discussion_r531781486 ## File path: rust/arrow/src/array/equal/structure.rs ## @@ -15,45 +15,97 @@ // specific language governing permissions and limitations // under the

[GitHub] [arrow] nevi-me commented on a change in pull request #8739: ARROW-10684: [Rust] Inherit struct nulls in child null equality

2020-11-27 Thread GitBox
nevi-me commented on a change in pull request #8739: URL: https://github.com/apache/arrow/pull/8739#discussion_r531780455 ## File path: rust/arrow/src/array/equal/structure.rs ## @@ -15,13 +15,15 @@ // specific language governing permissions and limitations // under the

[GitHub] [arrow] nevi-me commented on a change in pull request #8739: ARROW-10684: [Rust] Inherit struct nulls in child null equality

2020-11-26 Thread GitBox
nevi-me commented on a change in pull request #8739: URL: https://github.com/apache/arrow/pull/8739#discussion_r531155130 ## File path: rust/arrow/src/array/equal/structure.rs ## @@ -30,19 +32,51 @@ fn equal_values( .iter() .zip(rhs.child_data())

[GitHub] [arrow] nevi-me commented on a change in pull request #8739: ARROW-10684: [Rust] Inherit struct nulls in child null equality

2020-11-26 Thread GitBox
nevi-me commented on a change in pull request #8739: URL: https://github.com/apache/arrow/pull/8739#discussion_r531148917 ## File path: rust/arrow/src/array/equal/structure.rs ## @@ -30,19 +32,51 @@ fn equal_values( .iter() .zip(rhs.child_data())