[GitHub] [arrow] nevi-me commented on pull request #7024: ARROW-8573: [Rust] Upgrade Rust to 1.44 nightly

2020-04-28 Thread GitBox
nevi-me commented on pull request #7024: URL: https://github.com/apache/arrow/pull/7024#issuecomment-620739497 Thanks @markhildreth, I didn't see that the branch wasn't rebased into master. We should be fine now. This is an

[GitHub] [arrow] nevi-me commented on pull request #7024: ARROW-8573: [Rust] Upgrade Rust to 1.44 nightly

2020-04-28 Thread GitBox
nevi-me commented on pull request #7024: URL: https://github.com/apache/arrow/pull/7024#issuecomment-620649009 @andygrove this failure (https://git.data-engine.co.za/nevi-me/ifrs16-front-end-angular/pipelines/1830) doesn't make sense to me. On my machine, the relevant file is formatted

[GitHub] [arrow] nevi-me commented on pull request #7024: ARROW-8573: [Rust] Upgrade Rust to 1.44 nightly

2020-04-24 Thread GitBox
nevi-me commented on pull request #7024: URL: https://github.com/apache/arrow/pull/7024#issuecomment-619189091 @paddyhoran we might have to try a different nightly, as sometimes a day's version might have no rustfmt. The change I made in that PR installs a nightly version, I don't know