[GitHub] [arrow] pitrou commented on a change in pull request #7748: ARROW-9388: [C++] Division kernels

2020-08-18 Thread GitBox
pitrou commented on a change in pull request #7748: URL: https://github.com/apache/arrow/pull/7748#discussion_r472277809 ## File path: cpp/src/arrow/compute/kernels/scalar_arithmetic.cc ## @@ -186,6 +187,42 @@ struct MultiplyChecked { } }; +struct Divide { + template +

[GitHub] [arrow] pitrou commented on a change in pull request #7748: ARROW-9388: [C++] Division kernels

2020-08-17 Thread GitBox
pitrou commented on a change in pull request #7748: URL: https://github.com/apache/arrow/pull/7748#discussion_r471518131 ## File path: cpp/src/arrow/compute/kernels/scalar_arithmetic_test.cc ## @@ -492,6 +486,81 @@ TYPED_TEST(TestBinaryArithmeticFloating, Add) {

[GitHub] [arrow] pitrou commented on a change in pull request #7748: ARROW-9388: [C++] Division kernels

2020-08-17 Thread GitBox
pitrou commented on a change in pull request #7748: URL: https://github.com/apache/arrow/pull/7748#discussion_r471364203 ## File path: cpp/src/arrow/compute/kernels/scalar_arithmetic_test.cc ## @@ -492,6 +486,81 @@ TYPED_TEST(TestBinaryArithmeticFloating, Add) {

[GitHub] [arrow] pitrou commented on a change in pull request #7748: ARROW-9388: [C++] Division kernels

2020-08-13 Thread GitBox
pitrou commented on a change in pull request #7748: URL: https://github.com/apache/arrow/pull/7748#discussion_r469995900 ## File path: docs/source/cpp/compute.rst ## @@ -197,6 +197,10 @@ an ``Invalid`` :class:`Status` when overflow is detected.