[GitHub] [arrow] pitrou commented on a change in pull request #8219: ARROW-9603: [C++] Fix parquet write to not assume leaf-array validity bitmaps have the same values as parent structs

2020-09-25 Thread GitBox
pitrou commented on a change in pull request #8219: URL: https://github.com/apache/arrow/pull/8219#discussion_r494170006 ## File path: cpp/src/parquet/column_writer.cc ## @@ -1130,37 +1188,61 @@ class TypedColumnWriterImpl : public ColumnWriterImpl, public TypedColumnWriter<

[GitHub] [arrow] pitrou commented on a change in pull request #8219: ARROW-9603: [C++] Fix parquet write to not assume leaf-array validity bitmaps have the same values as parent structs

2020-09-24 Thread GitBox
pitrou commented on a change in pull request #8219: URL: https://github.com/apache/arrow/pull/8219#discussion_r494170006 ## File path: cpp/src/parquet/column_writer.cc ## @@ -1130,37 +1188,61 @@ class TypedColumnWriterImpl : public ColumnWriterImpl, public TypedColumnWriter<

[GitHub] [arrow] pitrou commented on a change in pull request #8219: ARROW-9603: [C++] Fix parquet write to not assume leaf-array validity bitmaps have the same values as parent structs

2020-09-22 Thread GitBox
pitrou commented on a change in pull request #8219: URL: https://github.com/apache/arrow/pull/8219#discussion_r492558115 ## File path: cpp/src/parquet/column_writer.cc ## @@ -1009,12 +1046,33 @@ class TypedColumnWriterImpl : public ColumnWriterImpl, public TypedColumnWriter<

[GitHub] [arrow] pitrou commented on a change in pull request #8219: ARROW-9603: [C++] Fix parquet write to not assume leaf-array validity bitmaps have the same values as parent structs

2020-09-22 Thread GitBox
pitrou commented on a change in pull request #8219: URL: https://github.com/apache/arrow/pull/8219#discussion_r492563521 ## File path: cpp/src/parquet/column_writer.cc ## @@ -1130,37 +1188,61 @@ class TypedColumnWriterImpl : public ColumnWriterImpl, public TypedColumnWriter<

[GitHub] [arrow] pitrou commented on a change in pull request #8219: ARROW-9603: [C++] Fix parquet write to not assume leaf-array validity bitmaps have the same values as parent structs

2020-09-22 Thread GitBox
pitrou commented on a change in pull request #8219: URL: https://github.com/apache/arrow/pull/8219#discussion_r492560707 ## File path: cpp/src/parquet/column_writer.cc ## @@ -1009,12 +1046,33 @@ class TypedColumnWriterImpl : public ColumnWriterImpl, public TypedColumnWriter<

[GitHub] [arrow] pitrou commented on a change in pull request #8219: ARROW-9603: [C++] Fix parquet write to not assume leaf-array validity bitmaps have the same values as parent structs

2020-09-22 Thread GitBox
pitrou commented on a change in pull request #8219: URL: https://github.com/apache/arrow/pull/8219#discussion_r492560707 ## File path: cpp/src/parquet/column_writer.cc ## @@ -1009,12 +1046,33 @@ class TypedColumnWriterImpl : public ColumnWriterImpl, public TypedColumnWriter<

[GitHub] [arrow] pitrou commented on a change in pull request #8219: ARROW-9603: [C++] Fix parquet write to not assume leaf-array validity bitmaps have the same values as parent structs

2020-09-22 Thread GitBox
pitrou commented on a change in pull request #8219: URL: https://github.com/apache/arrow/pull/8219#discussion_r492560172 ## File path: cpp/src/parquet/column_writer.cc ## @@ -1009,12 +1046,33 @@ class TypedColumnWriterImpl : public ColumnWriterImpl, public TypedColumnWriter<

[GitHub] [arrow] pitrou commented on a change in pull request #8219: ARROW-9603: [C++] Fix parquet write to not assume leaf-array validity bitmaps have the same values as parent structs

2020-09-22 Thread GitBox
pitrou commented on a change in pull request #8219: URL: https://github.com/apache/arrow/pull/8219#discussion_r492559517 ## File path: cpp/src/parquet/column_writer.cc ## @@ -1009,12 +1046,33 @@ class TypedColumnWriterImpl : public ColumnWriterImpl, public TypedColumnWriter<

[GitHub] [arrow] pitrou commented on a change in pull request #8219: ARROW-9603: [C++] Fix parquet write to not assume leaf-array validity bitmaps have the same values as parent structs

2020-09-22 Thread GitBox
pitrou commented on a change in pull request #8219: URL: https://github.com/apache/arrow/pull/8219#discussion_r492558836 ## File path: cpp/src/parquet/column_writer.cc ## @@ -1009,12 +1046,33 @@ class TypedColumnWriterImpl : public ColumnWriterImpl, public TypedColumnWriter<

[GitHub] [arrow] pitrou commented on a change in pull request #8219: ARROW-9603: [C++] Fix parquet write to not assume leaf-array validity bitmaps have the same values as parent structs

2020-09-22 Thread GitBox
pitrou commented on a change in pull request #8219: URL: https://github.com/apache/arrow/pull/8219#discussion_r492559005 ## File path: cpp/src/parquet/column_writer.cc ## @@ -1009,12 +1046,33 @@ class TypedColumnWriterImpl : public ColumnWriterImpl, public TypedColumnWriter<

[GitHub] [arrow] pitrou commented on a change in pull request #8219: ARROW-9603: [C++] Fix parquet write to not assume leaf-array validity bitmaps have the same values as parent structs

2020-09-22 Thread GitBox
pitrou commented on a change in pull request #8219: URL: https://github.com/apache/arrow/pull/8219#discussion_r492558115 ## File path: cpp/src/parquet/column_writer.cc ## @@ -1009,12 +1046,33 @@ class TypedColumnWriterImpl : public ColumnWriterImpl, public TypedColumnWriter<