[GitHub] [arrow] pravindra commented on a change in pull request #7402: ARROW-9099: [C++][Gandiva] Implement trim function for string

2020-06-19 Thread GitBox
pravindra commented on a change in pull request #7402: URL: https://github.com/apache/arrow/pull/7402#discussion_r442869546 ## File path: cpp/src/gandiva/precompiled/string_ops.cc ## @@ -284,6 +284,49 @@ const char* reverse_utf8(gdv_int64 context, const char* data, gdv_int32

[GitHub] [arrow] pravindra commented on a change in pull request #7402: ARROW-9099: [C++][Gandiva] Implement trim function for string

2020-06-19 Thread GitBox
pravindra commented on a change in pull request #7402: URL: https://github.com/apache/arrow/pull/7402#discussion_r442868857 ## File path: cpp/src/gandiva/precompiled/string_ops_test.cc ## @@ -426,6 +426,33 @@ TEST(TestStringOps, TestReverse) { ctx.Reset(); }

[GitHub] [arrow] pravindra commented on a change in pull request #7402: ARROW-9099: [C++][Gandiva] Implement trim function for string

2020-06-19 Thread GitBox
pravindra commented on a change in pull request #7402: URL: https://github.com/apache/arrow/pull/7402#discussion_r442867225 ## File path: cpp/src/gandiva/precompiled/string_ops.cc ## @@ -284,6 +284,49 @@ const char* reverse_utf8(gdv_int64 context, const char* data, gdv_int32