[GitHub] [arrow] rok commented on a change in pull request #10457: ARROW-12980: [C++] Kernels to extract datetime components should be timezone aware

rok commented on a change in pull request #10457: URL: https://github.com/apache/arrow/pull/10457#discussion_r690413546 ## File path: r/tests/testthat/test-dplyr-lubridate.R ## @@ -26,22 +26,13 @@ library(dplyr) # TODO: consider reevaluating this workaround after ARROW-12980

[GitHub] [arrow] rok commented on a change in pull request #10457: ARROW-12980: [C++] Kernels to extract datetime components should be timezone aware

rok commented on a change in pull request #10457: URL: https://github.com/apache/arrow/pull/10457#discussion_r689816847 ## File path: r/tests/testthat/test-dplyr-lubridate.R ## @@ -26,22 +26,13 @@ library(dplyr) # TODO: consider reevaluating this workaround after ARROW-12980

[GitHub] [arrow] rok commented on a change in pull request #10457: ARROW-12980: [C++] Kernels to extract datetime components should be timezone aware

rok commented on a change in pull request #10457: URL: https://github.com/apache/arrow/pull/10457#discussion_r689611393 ## File path: cpp/src/arrow/compute/kernels/scalar_temporal.cc ## @@ -63,79 +71,132 @@ const std::string& GetInputTimezone(const ArrayData& array) {

[GitHub] [arrow] rok commented on a change in pull request #10457: ARROW-12980: [C++] Kernels to extract datetime components should be timezone aware

rok commented on a change in pull request #10457: URL: https://github.com/apache/arrow/pull/10457#discussion_r688405211 ## File path: cpp/src/arrow/compute/kernels/scalar_temporal_test.cc ## @@ -142,44 +141,211 @@ TEST_F(ScalarTemporalTest,

[GitHub] [arrow] rok commented on a change in pull request #10457: ARROW-12980: [C++] Kernels to extract datetime components should be timezone aware

rok commented on a change in pull request #10457: URL: https://github.com/apache/arrow/pull/10457#discussion_r688207402 ## File path: docs/source/cpp/compute.rst ## @@ -1056,7 +1056,8 @@ Temporal component extraction ~ These functions extract

[GitHub] [arrow] rok commented on a change in pull request #10457: ARROW-12980: [C++] Kernels to extract datetime components should be timezone aware

rok commented on a change in pull request #10457: URL: https://github.com/apache/arrow/pull/10457#discussion_r688207165 ## File path: cpp/src/arrow/compute/kernels/scalar_temporal.cc ## @@ -399,6 +533,44 @@ struct ISOCalendar { } }; +template class Op, typename OutType>

[GitHub] [arrow] rok commented on a change in pull request #10457: ARROW-12980: [C++] Kernels to extract datetime components should be timezone aware

rok commented on a change in pull request #10457: URL: https://github.com/apache/arrow/pull/10457#discussion_r688207105 ## File path: cpp/src/arrow/compute/kernels/scalar_temporal.cc ## @@ -187,16 +243,28 @@ struct DayOfYear { template struct ISOYear { + explicit

[GitHub] [arrow] rok commented on a change in pull request #10457: ARROW-12980: [C++] Kernels to extract datetime components should be timezone aware

rok commented on a change in pull request #10457: URL: https://github.com/apache/arrow/pull/10457#discussion_r688206189 ## File path: cpp/src/arrow/compute/kernels/scalar_temporal_test.cc ## @@ -142,29 +141,168 @@ TEST_F(ScalarTemporalTest,

[GitHub] [arrow] rok commented on a change in pull request #10457: ARROW-12980: [C++] Kernels to extract datetime components should be timezone aware

rok commented on a change in pull request #10457: URL: https://github.com/apache/arrow/pull/10457#discussion_r688205633 ## File path: cpp/src/arrow/compute/kernels/scalar_temporal_test.cc ## @@ -216,5 +354,6 @@ TEST_F(ScalarTemporalTest, DayOfWeek) {

[GitHub] [arrow] rok commented on a change in pull request #10457: ARROW-12980: [C++] Kernels to extract datetime components should be timezone aware

rok commented on a change in pull request #10457: URL: https://github.com/apache/arrow/pull/10457#discussion_r673573050 ## File path: python/pyarrow/tests/test_compute.py ## @@ -1427,9 +1428,20 @@ def test_extract_datetime_components(): "2008-12-28",

[GitHub] [arrow] rok commented on a change in pull request #10457: ARROW-12980: [C++] Kernels to extract datetime components should be timezone aware

rok commented on a change in pull request #10457: URL: https://github.com/apache/arrow/pull/10457#discussion_r673306462 ## File path: python/pyarrow/tests/test_compute.py ## @@ -1427,9 +1428,20 @@ def test_extract_datetime_components(): "2008-12-28",

[GitHub] [arrow] rok commented on a change in pull request #10457: ARROW-12980: [C++] Kernels to extract datetime components should be timezone aware

rok commented on a change in pull request #10457: URL: https://github.com/apache/arrow/pull/10457#discussion_r673255609 ## File path: python/pyarrow/tests/test_compute.py ## @@ -1427,9 +1428,20 @@ def test_extract_datetime_components(): "2008-12-28",

[GitHub] [arrow] rok commented on a change in pull request #10457: ARROW-12980: [C++] Kernels to extract datetime components should be timezone aware

rok commented on a change in pull request #10457: URL: https://github.com/apache/arrow/pull/10457#discussion_r673229267 ## File path: python/pyarrow/tests/test_compute.py ## @@ -1427,9 +1428,20 @@ def test_extract_datetime_components(): "2008-12-28",

[GitHub] [arrow] rok commented on a change in pull request #10457: ARROW-12980: [C++] Kernels to extract datetime components should be timezone aware

rok commented on a change in pull request #10457: URL: https://github.com/apache/arrow/pull/10457#discussion_r673152117 ## File path: python/pyarrow/tests/test_compute.py ## @@ -1427,9 +1428,20 @@ def test_extract_datetime_components(): "2008-12-28",

[GitHub] [arrow] rok commented on a change in pull request #10457: ARROW-12980: [C++] Kernels to extract datetime components should be timezone aware

rok commented on a change in pull request #10457: URL: https://github.com/apache/arrow/pull/10457#discussion_r657924847 ## File path: cpp/src/arrow/compute/kernels/scalar_temporal.cc ## @@ -60,86 +63,132 @@ const std::string& GetInputTimezone(const ArrayData& array) {

[GitHub] [arrow] rok commented on a change in pull request #10457: ARROW-12980: [C++] Kernels to extract datetime components should be timezone aware

rok commented on a change in pull request #10457: URL: https://github.com/apache/arrow/pull/10457#discussion_r657924847 ## File path: cpp/src/arrow/compute/kernels/scalar_temporal.cc ## @@ -60,86 +63,132 @@ const std::string& GetInputTimezone(const ArrayData& array) {

[GitHub] [arrow] rok commented on a change in pull request #10457: ARROW-12980: [C++] Kernels to extract datetime components should be timezone aware

rok commented on a change in pull request #10457: URL: https://github.com/apache/arrow/pull/10457#discussion_r657543026 ## File path: cpp/src/arrow/compute/kernels/scalar_temporal_test.cc ## @@ -143,39 +142,204 @@ TEST(ScalarTemporalTest,

[GitHub] [arrow] rok commented on a change in pull request #10457: ARROW-12980: [C++] Kernels to extract datetime components should be timezone aware

rok commented on a change in pull request #10457: URL: https://github.com/apache/arrow/pull/10457#discussion_r657531497 ## File path: cpp/src/arrow/compute/kernels/scalar_temporal_test.cc ## @@ -143,39 +142,204 @@ TEST(ScalarTemporalTest,

[GitHub] [arrow] rok commented on a change in pull request #10457: ARROW-12980: [C++] Kernels to extract datetime components should be timezone aware

rok commented on a change in pull request #10457: URL: https://github.com/apache/arrow/pull/10457#discussion_r657500729 ## File path: cpp/src/arrow/compute/kernels/scalar_temporal.cc ## @@ -60,86 +63,132 @@ const std::string& GetInputTimezone(const ArrayData& array) {

[GitHub] [arrow] rok commented on a change in pull request #10457: ARROW-12980: [C++] Kernels to extract datetime components should be timezone aware

rok commented on a change in pull request #10457: URL: https://github.com/apache/arrow/pull/10457#discussion_r657500729 ## File path: cpp/src/arrow/compute/kernels/scalar_temporal.cc ## @@ -60,86 +63,132 @@ const std::string& GetInputTimezone(const ArrayData& array) {

[GitHub] [arrow] rok commented on a change in pull request #10457: ARROW-12980: [C++] Kernels to extract datetime components should be timezone aware

rok commented on a change in pull request #10457: URL: https://github.com/apache/arrow/pull/10457#discussion_r651827989 ## File path: python/pyarrow/tests/test_compute.py ## @@ -1255,6 +1255,78 @@ def test_strptime(): assert got == expected +def

[GitHub] [arrow] rok commented on a change in pull request #10457: ARROW-12980: [C++] Kernels to extract datetime components should be timezone aware

rok commented on a change in pull request #10457: URL: https://github.com/apache/arrow/pull/10457#discussion_r651784673 ## File path: cpp/src/arrow/compute/kernels/scalar_temporal_test.cc ## @@ -143,39 +142,202 @@ TEST(ScalarTemporalTest,

[GitHub] [arrow] rok commented on a change in pull request #10457: ARROW-12980: [C++] Kernels to extract datetime components should be timezone aware

rok commented on a change in pull request #10457: URL: https://github.com/apache/arrow/pull/10457#discussion_r651779895 ## File path: cpp/src/arrow/compute/kernels/scalar_temporal_test.cc ## @@ -143,39 +142,202 @@ TEST(ScalarTemporalTest,

[GitHub] [arrow] rok commented on a change in pull request #10457: ARROW-12980: [C++] Kernels to extract datetime components should be timezone aware

rok commented on a change in pull request #10457: URL: https://github.com/apache/arrow/pull/10457#discussion_r651290261 ## File path: cpp/src/arrow/compute/kernels/scalar_temporal_test.cc ## @@ -143,39 +142,202 @@ TEST(ScalarTemporalTest,

[GitHub] [arrow] rok commented on a change in pull request #10457: ARROW-12980: [C++] Kernels to extract datetime components should be timezone aware

rok commented on a change in pull request #10457: URL: https://github.com/apache/arrow/pull/10457#discussion_r651241888 ## File path: python/pyarrow/tests/test_compute.py ## @@ -1212,6 +1212,80 @@ def test_strptime(): assert got == expected +def