[GitHub] [arrow] rtpsw commented on pull request #33676: GH-33673: [C++] Standardize as-of-join convention for past and future tolerance

rtpsw commented on PR #33676: URL: https://github.com/apache/arrow/pull/33676#issuecomment-1407398710 CI job failure is unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [arrow] rtpsw commented on pull request #33676: GH-33673: [C++] Standardize as-of-join convention for past and future tolerance

rtpsw commented on PR #33676: URL: https://github.com/apache/arrow/pull/33676#issuecomment-1407383636 I merged with master to get the missing test cases and then fixed them similarly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [arrow] rtpsw commented on pull request #33676: GH-33673: [C++] Standardize as-of-join convention for past and future tolerance

rtpsw commented on PR #33676: URL: https://github.com/apache/arrow/pull/33676#issuecomment-1407378621 Something weird seems to be going on with the CI. Some failing jobs, like [this one](https://github.com/apache/arrow/actions/runs/4031369011/jobs/6930622636) and [this one](https://github

[GitHub] [arrow] rtpsw commented on pull request #33676: GH-33673: [C++] Standardize as-of-join convention for past and future tolerance

rtpsw commented on PR #33676: URL: https://github.com/apache/arrow/pull/33676#issuecomment-1407368585 Yes, the test was failing because it used the pre-PR tolerance convention. I just fixed it. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [arrow] rtpsw commented on pull request #33676: GH-33673: [C++] Standardize as-of-join convention for past and future tolerance

rtpsw commented on PR #33676: URL: https://github.com/apache/arrow/pull/33676#issuecomment-1398491977 Ping @westonpace - it would be great if this can be reviewed quickly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [arrow] rtpsw commented on pull request #33676: GH-33673: [C++] Standardize as-of-join convention for past and future tolerance

rtpsw commented on PR #33676: URL: https://github.com/apache/arrow/pull/33676#issuecomment-1387193893 cc @icexelloss -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [arrow] rtpsw commented on pull request #33676: GH-33673: [C++] Standardize as-of-join convention for past and future tolerance

rtpsw commented on PR #33676: URL: https://github.com/apache/arrow/pull/33676#issuecomment-1383564040 cc @westonpace -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [arrow] rtpsw commented on pull request #33676: GH-33673: [C++] Standardize as-of-join convention for past and future tolerance

rtpsw commented on PR #33676: URL: https://github.com/apache/arrow/pull/33676#issuecomment-1383237187 The CI job failures appear to be unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t