tianchen92 commented on pull request #6433:
URL: https://github.com/apache/arrow/pull/6433#issuecomment-633778149
> @tianchen92 can you rebase this once? I will merge then.
Thanks, rebased:)
This is an automated
tianchen92 commented on pull request #6433:
URL: https://github.com/apache/arrow/pull/6433#issuecomment-631284400
> include a test which ensures that the Netty Allocator returns an
empty-behaving byte buffer when users allocate a zero byte buffer
Thanks jacques, I created
tianchen92 commented on pull request #6433:
URL: https://github.com/apache/arrow/pull/6433#issuecomment-630540722
> > Good suggestion, seems empty ArrowBuf was used in vectors before
populating data. I have added a set of tests in TestValueVector.
>
> The tests you added are all
tianchen92 commented on pull request #6433:
URL: https://github.com/apache/arrow/pull/6433#issuecomment-625704614
> I think it would be good to have a set of tests ensuring that the behavior
of the empty buffer is consistent. For example, refcnt, release/allocate, etc.
That way, if
tianchen92 commented on pull request #6433:
URL: https://github.com/apache/arrow/pull/6433#issuecomment-624480936
> @tianchen92 , can you please revise thia? Looks like the work is completed
ok, revised, thanks!
This
