[GitHub] [arrow] wesm commented on a change in pull request #7378: ARROW-8866: [C++] Split UNION into SPARSE_UNION and DENSE_UNION

2020-06-12 Thread GitBox
wesm commented on a change in pull request #7378: URL: https://github.com/apache/arrow/pull/7378#discussion_r439539505 ## File path: cpp/src/arrow/type_fwd.h ## @@ -351,39 +358,21 @@ std::shared_ptr ARROW_EXPORT time64(TimeUnit::type unit); std::shared_ptr ARROW_EXPORT

[GitHub] [arrow] wesm commented on a change in pull request #7378: ARROW-8866: [C++] Split UNION into SPARSE_UNION and DENSE_UNION

2020-06-12 Thread GitBox
wesm commented on a change in pull request #7378: URL: https://github.com/apache/arrow/pull/7378#discussion_r439539160 ## File path: cpp/src/arrow/array/array_primitive.h ## @@ -108,11 +108,11 @@ class ARROW_EXPORT DayTimeIntervalArray : public PrimitiveArray { // For