wesm commented on pull request #6631:
URL: https://github.com/apache/arrow/pull/6631#issuecomment-623028612
Closing in favor of #7088 so we can have a fresh round of code review
This is an automated message from the Apache
wesm commented on pull request #6631:
URL: https://github.com/apache/arrow/pull/6631#issuecomment-622586463
There aren't any unit tests in this patch so there is some work to do to get
this merged
This is an automated
wesm commented on pull request #6631:
URL: https://github.com/apache/arrow/pull/6631#issuecomment-622447876
I can pick up this patch today and take it the last mile so it can be
merged.
This is an automated message from
wesm commented on pull request #6631:
URL: https://github.com/apache/arrow/pull/6631#issuecomment-622195001
Thank you. There are some code linting issues and other code style issues
(we follow the Google C++ style guide), can you fix the CI builds? I'd like to
kick the tires a bit on this
wesm commented on pull request #6631:
URL: https://github.com/apache/arrow/pull/6631#issuecomment-621260531
Note we have `arrow/csv/converter_benchmark.cc`. Maybe you can put the
benchmarks there (or otherwise in the arrow/csv directory)?
