wesm commented on pull request #7356:
URL: https://github.com/apache/arrow/pull/7356#issuecomment-640673030
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
wesm commented on pull request #7356:
URL: https://github.com/apache/arrow/pull/7356#issuecomment-639899415
I'm going to be basing some patches on top of this, I can rebase whenever
this gets reviewed/merged
This is an
wesm commented on pull request #7356:
URL: https://github.com/apache/arrow/pull/7356#issuecomment-639697297
OK, here are the binary benchmarks:
```
Benchmark
wesm commented on pull request #7356:
URL: https://github.com/apache/arrow/pull/7356#issuecomment-639685965
I'm adding a BitmapReader-based comparison for the binary case. Stay tuned
This is an automated message from the
wesm commented on pull request #7356:
URL: https://github.com/apache/arrow/pull/7356#issuecomment-639555962
OK here are the fixed benchmarks. These match my intuition now. This shows
that there is very little downside and nearly always upside to using
`BitBlockCounter` over
wesm commented on pull request #7356:
URL: https://github.com/apache/arrow/pull/7356#issuecomment-639550537
There are some issues with the benchmarks, I'll fix them and repost numbers
This is an automated message from the
wesm commented on pull request #7356:
URL: https://github.com/apache/arrow/pull/7356#issuecomment-639547819
Benchmarks
```
BitBlockCounterSum/8 1687631 ns1687634 ns
407 592.545M items/s
BitBlockCounterSum/64
