[GitHub] [arrow] wesm commented on pull request #7378: ARROW-8866: [C++] Split UNION into SPARSE_UNION and DENSE_UNION

2020-06-12 Thread GitBox
wesm commented on pull request #7378: URL: https://github.com/apache/arrow/pull/7378#issuecomment-643413102 thanks @bkietz! This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [arrow] wesm commented on pull request #7378: ARROW-8866: [C++] Split UNION into SPARSE_UNION and DENSE_UNION

2020-06-12 Thread GitBox
wesm commented on pull request #7378: URL: https://github.com/apache/arrow/pull/7378#issuecomment-643412670 Appveyor was passing two commits ago: https://ci.appveyor.com/project/BenjaminKietzman/arrow/builds/33489614. The Ursabot CI failure looks transient. I'll go ahead and merge this so

[GitHub] [arrow] wesm commented on pull request #7378: ARROW-8866: [C++] Split UNION into SPARSE_UNION and DENSE_UNION

2020-06-12 Thread GitBox
wesm commented on pull request #7378: URL: https://github.com/apache/arrow/pull/7378#issuecomment-643390508 Sorry about the noise I think I've got it now. We might need to create an "arrow-deprecated-test" at some point where we verify that deprecated APIs still work as advertised

[GitHub] [arrow] wesm commented on pull request #7378: ARROW-8866: [C++] Split UNION into SPARSE_UNION and DENSE_UNION

2020-06-11 Thread GitBox
wesm commented on pull request #7378: URL: https://github.com/apache/arrow/pull/7378#issuecomment-643004964 @bkietz can you rebase and address @pitrou's comments tomorrow? This is going to collide with ARROW-9075 so would prefer that this go in first and then I can rebase my patch on that

[GitHub] [arrow] wesm commented on pull request #7378: ARROW-8866: [C++] Split UNION into SPARSE_UNION and DENSE_UNION

2020-06-09 Thread GitBox
wesm commented on pull request #7378: URL: https://github.com/apache/arrow/pull/7378#issuecomment-641498953 My patch #7382 should not conflict with this so no need to worry about rebasing This is an automated message from

[GitHub] [arrow] wesm commented on pull request #7378: ARROW-8866: [C++] Split UNION into SPARSE_UNION and DENSE_UNION

2020-06-09 Thread GitBox
wesm commented on pull request #7378: URL: https://github.com/apache/arrow/pull/7378#issuecomment-640849143 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use