[GitHub] [arrow] wesm commented on pull request #7417: ARROW-9079: [C++] Write benchmark for arithmetic kernels

2020-06-13 Thread GitBox
wesm commented on pull request #7417: URL: https://github.com/apache/arrow/pull/7417#issuecomment-643671002 +1. I fixed a few lingering issues that jumped out at me, will merge this once build passes This is an automated

[GitHub] [arrow] wesm commented on pull request #7417: ARROW-9079: [C++] Write benchmark for arithmetic kernels

2020-06-12 Thread GitBox
wesm commented on pull request #7417: URL: https://github.com/apache/arrow/pull/7417#issuecomment-643281405 There don't seem to be issues on MSVC https://gist.github.com/wesm/45be57393b2d9186f87faae228f12380/revisions

[GitHub] [arrow] wesm commented on pull request #7417: ARROW-9079: [C++] Write benchmark for arithmetic kernels

2020-06-12 Thread GitBox
wesm commented on pull request #7417: URL: https://github.com/apache/arrow/pull/7417#issuecomment-643266987 Thanks for working on this. I'll check the benchmarks on MSVC also This is an automated message from the Apache Git