wesm commented on pull request #7593:
URL: https://github.com/apache/arrow/pull/7593#issuecomment-653055238
Other types (e.g. list) will need to have a "contains" operation, so I think
it's more clear to have `binary_contains` and `list_contains` than simply
`contains`.
wesm commented on pull request #7593:
URL: https://github.com/apache/arrow/pull/7593#issuecomment-653042125
OK, do you have an idea for a prefix for a function that works either on
BinaryArray or StringArray?
This is an auto
wesm commented on pull request #7593:
URL: https://github.com/apache/arrow/pull/7593#issuecomment-653032949
> I think prefixes make sense. We will have sometime similar kernel names
that act quite different depending on the types they work on. I would
differentiate in the string/binary cas
wesm commented on pull request #7593:
URL: https://github.com/apache/arrow/pull/7593#issuecomment-652450464
> Could you elaborate? Why is this not a problem with the lower/upper
kernels?
The data preallocation is only for fixed size outputs (eg boolean, integers,
floating point, etc
wesm commented on pull request #7593:
URL: https://github.com/apache/arrow/pull/7593#issuecomment-652053744
I also propose to rename the function from "contains_exact" to
"utf8_contains". I'm pushing that change here shortly
wesm commented on pull request #7593:
URL: https://github.com/apache/arrow/pull/7593#issuecomment-652048000
I just opened https://issues.apache.org/jira/browse/ARROW-9285 -- it should
be easy to check if a kernel has mistakenly replaced a preallocated data buffer
(which may be a slice of a
wesm commented on pull request #7593:
URL: https://github.com/apache/arrow/pull/7593#issuecomment-652045953
@xhochy I'm fixing a couple issues with the implementation:
* The function executor allocates memory for you unless you explicitly
disable it. The idea is that you don't want t
wesm commented on pull request #7593:
URL: https://github.com/apache/arrow/pull/7593#issuecomment-651849432
@xhochy chunked array should be handled automatically by the function
executors. I will take a look.
This is an aut
