[GitHub] [arrow] westonpace commented on a diff in pull request #13669: ARROW-16389: [C++][Acero] Add spilling for hash join

2023-01-18 Thread GitBox
westonpace commented on code in PR #13669: URL: https://github.com/apache/arrow/pull/13669#discussion_r1073590080 ## cpp/src/arrow/compute/exec/spilling_join.h: ## @@ -0,0 +1,129 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license ag

[GitHub] [arrow] westonpace commented on a diff in pull request #13669: ARROW-16389: [C++][Acero] Add spilling for hash join

2023-01-09 Thread GitBox
westonpace commented on code in PR #13669: URL: https://github.com/apache/arrow/pull/13669#discussion_r1064813860 ## cpp/src/arrow/compute/exec/accumulation_queue.cc: ## @@ -39,20 +37,180 @@ void AccumulationQueue::Concatenate(AccumulationQueue&& that) { this->batches_.reser

[GitHub] [arrow] westonpace commented on a diff in pull request #13669: ARROW-16389: [C++][Acero] Add spilling for hash join

2022-08-11 Thread GitBox
westonpace commented on code in PR #13669: URL: https://github.com/apache/arrow/pull/13669#discussion_r943999661 ## cpp/src/arrow/compute/light_array.h: ## @@ -348,11 +349,13 @@ class ARROW_EXPORT ExecBatchBuilder { ExecBatch Flush(); int num_rows() const { return values

[GitHub] [arrow] westonpace commented on a diff in pull request #13669: ARROW-16389: [C++][Acero] Add spilling for hash join

2022-08-11 Thread GitBox
westonpace commented on code in PR #13669: URL: https://github.com/apache/arrow/pull/13669#discussion_r943998671 ## cpp/src/arrow/compute/exec/spilling_util.cc: ## @@ -0,0 +1,253 @@ +#include "spilling_util.h" + +namespace arrow +{ +namespace compute +{ + +struct ArrayInfo +

[GitHub] [arrow] westonpace commented on a diff in pull request #13669: ARROW-16389: [C++][Acero] Add spilling for hash join

2022-07-21 Thread GitBox
westonpace commented on code in PR #13669: URL: https://github.com/apache/arrow/pull/13669#discussion_r926657650 ## cpp/src/arrow/memory_pool_internal.h: ## @@ -26,7 +26,7 @@ namespace memory_pool { namespace internal { -static constexpr size_t kAlignment = 64; +static cons