[GitHub] [arrow] wgtmac commented on a diff in pull request #33736: PARQUET-2232: [C++] Add an api to ColumnChunkMetaData to indicate if the column chunk uses a bloom filter

[GitBox]

wgtmac commented on code in PR #33736:
URL: https://github.com/apache/arrow/pull/33736#discussion_r1073268411


##########
cpp/src/parquet/metadata.h:
##########
@@ -171,6 +171,7 @@ class PARQUET_EXPORT ColumnChunkMetaData {
 
   const std::vector<Encoding::type>& encodings() const;
   const std::vector<PageEncodingStats>& encoding_stats() const;
+  bool has_bloom_filter() const;

Review Comment:
   ```suggestion
     std::optional<int64_t> bloom_filter_offset() const;
   ```



##########
cpp/src/parquet/metadata.h:
##########
@@ -171,6 +171,7 @@ class PARQUET_EXPORT ColumnChunkMetaData {
 
   const std::vector<Encoding::type>& encodings() const;
   const std::vector<PageEncodingStats>& encoding_stats() const;
+  bool has_bloom_filter() const;

Review Comment:
   It would be more user-friendly to provide this function, like the 
`GetColumnIndexLocation` below.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org