[GitHub] [arrow] xhochy commented on a change in pull request #8219: ARROW-9603: [C++] Fix parquet write to not assume leaf-array validity bitmaps have the same values as parent structs

2020-09-25 Thread GitBox
xhochy commented on a change in pull request #8219: URL: https://github.com/apache/arrow/pull/8219#discussion_r494169301 ## File path: cpp/src/parquet/arrow/arrow_reader_writer_test.cc ## @@ -2360,6 +2361,39 @@ TEST(ArrowReadWrite, SingleColumnNullableStruct) { 3); }

[GitHub] [arrow] xhochy commented on a change in pull request #8219: ARROW-9603: [C++] Fix parquet write to not assume leaf-array validity bitmaps have the same values as parent structs

2020-09-24 Thread GitBox
xhochy commented on a change in pull request #8219: URL: https://github.com/apache/arrow/pull/8219#discussion_r494169301 ## File path: cpp/src/parquet/arrow/arrow_reader_writer_test.cc ## @@ -2360,6 +2361,39 @@ TEST(ArrowReadWrite, SingleColumnNullableStruct) { 3); }

[GitHub] [arrow] xhochy commented on a change in pull request #8219: ARROW-9603: [C++] Fix parquet write to not assume leaf-array validity bitmaps have the same values as parent structs

2020-09-23 Thread GitBox
xhochy commented on a change in pull request #8219: URL: https://github.com/apache/arrow/pull/8219#discussion_r493663621 ## File path: cpp/src/parquet/arrow/arrow_reader_writer_test.cc ## @@ -2360,6 +2361,39 @@ TEST(ArrowReadWrite, SingleColumnNullableStruct) { 3); }