[GitHub] [arrow] zeevm commented on a change in pull request #7586: ARROW-9280: [Rust] [Parquet] Calculate page and column statistics

2020-07-02 Thread GitBox
zeevm commented on a change in pull request #7586: URL: https://github.com/apache/arrow/pull/7586#discussion_r448870420 ## File path: rust/parquet/src/column/writer.rs ## @@ -216,26 +278,26 @@ impl ColumnWriterImpl { def_levels_sink: vec![], rep_levels

[GitHub] [arrow] zeevm commented on a change in pull request #7586: ARROW-9280: [Rust] [Parquet] Calculate page and column statistics

2020-07-02 Thread GitBox
zeevm commented on a change in pull request #7586: URL: https://github.com/apache/arrow/pull/7586#discussion_r448870420 ## File path: rust/parquet/src/column/writer.rs ## @@ -216,26 +278,26 @@ impl ColumnWriterImpl { def_levels_sink: vec![], rep_levels

[GitHub] [arrow] zeevm commented on a change in pull request #7586: ARROW-9280: [Rust] [Parquet] Calculate page and column statistics

2020-07-02 Thread GitBox
zeevm commented on a change in pull request #7586: URL: https://github.com/apache/arrow/pull/7586#discussion_r448814477 ## File path: rust/parquet/src/column/writer.rs ## @@ -216,26 +278,26 @@ impl ColumnWriterImpl { def_levels_sink: vec![], rep_levels

[GitHub] [arrow] zeevm commented on a change in pull request #7586: ARROW-9280: [Rust] [Parquet] Calculate page and column statistics

2020-07-01 Thread GitBox
zeevm commented on a change in pull request #7586: URL: https://github.com/apache/arrow/pull/7586#discussion_r448764844 ## File path: rust/parquet/src/column/writer.rs ## @@ -216,26 +278,26 @@ impl ColumnWriterImpl { def_levels_sink: vec![], rep_levels

[GitHub] [arrow] zeevm commented on a change in pull request #7586: ARROW-9280: [Rust] [Parquet] Calculate page and column statistics

2020-07-01 Thread GitBox
zeevm commented on a change in pull request #7586: URL: https://github.com/apache/arrow/pull/7586#discussion_r448757699 ## File path: rust/parquet/src/column/writer.rs ## @@ -216,26 +278,26 @@ impl ColumnWriterImpl { def_levels_sink: vec![], rep_levels

[GitHub] [arrow] zeevm commented on a change in pull request #7586: ARROW-9280: [Rust] [Parquet] Calculate page and column statistics

2020-07-01 Thread GitBox
zeevm commented on a change in pull request #7586: URL: https://github.com/apache/arrow/pull/7586#discussion_r448745612 ## File path: rust/parquet/src/column/writer.rs ## @@ -216,26 +278,26 @@ impl ColumnWriterImpl { def_levels_sink: vec![], rep_levels

[GitHub] [arrow] zeevm commented on a change in pull request #7586: ARROW-9280: [Rust] [Parquet] Calculate page and column statistics

2020-07-01 Thread GitBox
zeevm commented on a change in pull request #7586: URL: https://github.com/apache/arrow/pull/7586#discussion_r448745197 ## File path: rust/parquet/src/column/writer.rs ## @@ -276,12 +372,60 @@ impl ColumnWriterImpl { &values[values_offset..], def_level