Jimexist commented on a change in pull request #520:
URL: https://github.com/apache/arrow-datafusion/pull/520#discussion_r651361200
##
File path: datafusion/src/physical_plan/windows.rs
##
@@ -156,31 +162,72 @@ impl WindowExpr for BuiltInWindowExpr {
Jimexist commented on a change in pull request #520:
URL: https://github.com/apache/arrow-datafusion/pull/520#discussion_r651360294
##
File path: datafusion/src/physical_plan/expressions/nth_value.rs
##
@@ -113,54 +111,32 @@ impl BuiltInWindowFunctionExpr for NthValue {
Jimexist commented on a change in pull request #520:
URL: https://github.com/apache/arrow-datafusion/pull/520#discussion_r651358846
##
File path: datafusion/src/physical_plan/windows.rs
##
@@ -156,31 +162,72 @@ impl WindowExpr for BuiltInWindowExpr {
Jimexist commented on a change in pull request #520:
URL: https://github.com/apache/arrow-datafusion/pull/520#discussion_r651356971
##
File path: datafusion/src/physical_plan/expressions/nth_value.rs
##
@@ -113,54 +111,32 @@ impl BuiltInWindowFunctionExpr for NthValue {
Jimexist commented on a change in pull request #520:
URL: https://github.com/apache/arrow-datafusion/pull/520#discussion_r650504538
##
File path: ballista/rust/core/Cargo.toml
##
@@ -40,7 +40,7 @@ tokio = "1.0"
tonic = "0.4"
uuid = { version = "0.8", features = ["v4"] }