[GitHub] [arrow-datafusion] Jimexist commented on pull request #429: implement lead and lag built-in window function

2021-06-29 Thread GitBox
Jimexist commented on pull request #429: URL: https://github.com/apache/arrow-datafusion/pull/429#issuecomment-870594468 @alamb and @Dandandan this pull request is ready now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [arrow-datafusion] Jimexist commented on pull request #429: implement lead and lag built-in window function

2021-06-15 Thread GitBox
Jimexist commented on pull request #429: URL: https://github.com/apache/arrow-datafusion/pull/429#issuecomment-861419260 > > putting this back to draft as this relies on apache/arrow-rs#388 which is not yet in arrow 4.3 > > > > Oh no! > > > > Can we possibly

[GitHub] [arrow-datafusion] Jimexist commented on pull request #429: implement lead and lag built-in window function

2021-06-14 Thread GitBox
Jimexist commented on pull request #429: URL: https://github.com/apache/arrow-datafusion/pull/429#issuecomment-861103557 putting this back to draft as this relies on https://github.com/apache/arrow-rs/pull/388 which is not yet in arrow 4.3 -- This is an automated message from the Apache

[GitHub] [arrow-datafusion] Jimexist commented on pull request #429: implement lead and lag built-in window function

2021-06-14 Thread GitBox
Jimexist commented on pull request #429: URL: https://github.com/apache/arrow-datafusion/pull/429#issuecomment-860225216 > Actually let's park this pull request for a while - I plan to implement sort and partition first and then window frame, after which the window shift approach might

[GitHub] [arrow-datafusion] Jimexist commented on pull request #429: implement lead and lag built-in window function

2021-06-02 Thread GitBox
Jimexist commented on pull request #429: URL: https://github.com/apache/arrow-datafusion/pull/429#issuecomment-853192661 Actually let's park this pull request for a while - I plan to implement sort and partition first and then window frame, after which the window shift approach might not