alamb commented on PR #4924:
URL:
https://github.com/apache/arrow-datafusion/pull/4924#issuecomment-1396866343
Thanks again -- this is going to be great!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
alamb commented on PR #4924:
URL:
https://github.com/apache/arrow-datafusion/pull/4924#issuecomment-1387252935
I will plan to merge this PR tomorrow unless there are any other comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
alamb commented on PR #4924:
URL:
https://github.com/apache/arrow-datafusion/pull/4924#issuecomment-1387223619
I changed the PR description to say "closes
https://github.com/apache/arrow-datafusion/issues/2723; and filed
https://github.com/apache/arrow-datafusion/issues/4973 to track the
alamb commented on PR #4924:
URL:
https://github.com/apache/arrow-datafusion/pull/4924#issuecomment-1387203424
During review of this code it was clear it was in need of some more cleanup
-- PR proposing to do so in https://github.com/apache/arrow-datafusion/pull/4972
--
This is an
alamb commented on PR #4924:
URL:
https://github.com/apache/arrow-datafusion/pull/4924#issuecomment-1386207760
> Looks good, mostly noise I guess (and even if we suffer a 10% hit, I would
take that for the simpler implementation).
my reading of the benchmarks was that some got 10%
alamb commented on PR #4924:
URL:
https://github.com/apache/arrow-datafusion/pull/4924#issuecomment-1384713662
Thank you @mustafasrepo - I will put this on my review queue for tomorrow.
Sounds awesome
cc @crepererum and @tustvold
--
This is an automated message from the
