houqp edited a comment on pull request #55:
URL: https://github.com/apache/arrow-datafusion/pull/55#issuecomment-864615921
@alamb, turns out the bug you demoed is not simple to fix and surfaced a
problem in how join columns are handled in the current design. Based on what I
have seen in
houqp edited a comment on pull request #55:
URL: https://github.com/apache/arrow-datafusion/pull/55#issuecomment-864515901
looks like integration test is failing due to mismatch between logical
schema and physical schema for window queries, i will dig into this.
--
This is an automated
houqp edited a comment on pull request #55:
URL: https://github.com/apache/arrow-datafusion/pull/55#issuecomment-860150632
@andygrove @Dandandan @jorgecarleitao @alamb @Jimexist this PR is now ready
for review. We are now able to pass both tpch-7 and tpch-8.
I filed
houqp edited a comment on pull request #55:
URL: https://github.com/apache/arrow-datafusion/pull/55#issuecomment-831405269
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
houqp edited a comment on pull request #55:
URL: https://github.com/apache/arrow-datafusion/pull/55#issuecomment-828880763
@jorgecarleitao looking more into the logical optimization invariants, I
think we might want to relax it a little bit to account for some optimizations
that may
houqp edited a comment on pull request #55:
URL: https://github.com/apache/arrow-datafusion/pull/55#issuecomment-828880763
@jorgecarleitao looking more into the logical optimization invariants, I
think we might want to relax it a little bit to account for some optimizations
that may
houqp edited a comment on pull request #55:
URL: https://github.com/apache/arrow-datafusion/pull/55#issuecomment-827766515
Thanks @jorgecarleitao for the invariant design doc, I wasn't aware of it
before. I will definitely go through it and write something up for this PR this
weekend. I
houqp edited a comment on pull request #55:
URL: https://github.com/apache/arrow-datafusion/pull/55#issuecomment-826380176
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
houqp edited a comment on pull request #55:
URL: https://github.com/apache/arrow-datafusion/pull/55#issuecomment-826380176
@jorgecarleitao your understanding on column changes in logical and physical
planes are correct. I would add that in physical plane, the string column name
is
houqp edited a comment on pull request #55:
URL: https://github.com/apache/arrow-datafusion/pull/55#issuecomment-826380176
@jorgecarleitao your understanding on column changes in logical and physical
planes are correct. I would add that in physical plane, the string column name
is
houqp edited a comment on pull request #55:
URL: https://github.com/apache/arrow-datafusion/pull/55#issuecomment-826380176
@jorgecarleitao your understanding on column changes in logical and physical
planes are correct. I would add that in physical plane, the string column name
is
houqp edited a comment on pull request #55:
URL: https://github.com/apache/arrow-datafusion/pull/55#issuecomment-826380176
@jorgecarleitao your understanding on column changes in logical and physical
planes are correct. I would add that in physical plane, the string column name
is
houqp edited a comment on pull request #55:
URL: https://github.com/apache/arrow-datafusion/pull/55#issuecomment-826380176
@jorgecarleitao your understanding on column changes in logical and physical
planes are correct. I would add that in physical plane, the string column name
is
13 matches
Mail list logo
