[GitHub] [arrow-datafusion] mingmwang commented on pull request #4923: Support filter pushdown for semi/anti join

2023-01-18 Thread GitBox
mingmwang commented on PR #4923: URL: https://github.com/apache/arrow-datafusion/pull/4923#issuecomment-1386657477 Except for the method name `on_lr_is_preserved`, this PR LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [arrow-datafusion] mingmwang commented on pull request #4923: Support filter pushdown for semi/anti join

2023-01-18 Thread GitBox
mingmwang commented on PR #4923: URL: https://github.com/apache/arrow-datafusion/pull/4923#issuecomment-1386652044 @alamb @ygf11 Just share you the SparkSQL's result: ```sql explain extended SELECT t1_id, t1_name FROM t1 LEFT SEMI JOIN t2 ON (t1_id = t2_id and t2_id >=

[GitHub] [arrow-datafusion] mingmwang commented on pull request #4923: Support filter pushdown for semi/anti join

2023-01-16 Thread GitBox
mingmwang commented on PR #4923: URL: https://github.com/apache/arrow-datafusion/pull/4923#issuecomment-1384902196 is this PR ready for review now? I'm working on another issue which might be related to the things that you are working on. When decorrelates the where Exists/IN Subquer