[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3578: Use native types in PageIndex (#3575)

tustvold commented on code in PR #3578: URL: https://github.com/apache/arrow-rs/pull/3578#discussion_r1082678855 ## parquet/src/util/bit_util.rs: ## @@ -17,76 +17,104 @@ use std::{cmp, mem::size_of}; -use crate::data_type::AsBytes; +use crate::data_type::{AsBytes,

[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3578: Use native types in PageIndex (#3575)

tustvold commented on code in PR #3578: URL: https://github.com/apache/arrow-rs/pull/3578#discussion_r1082672997 ## parquet/src/bin/parquet-index.rs: ## @@ -132,7 +132,7 @@ fn compute_row_counts(offset_index: &[PageLocation], rows: i64) -> Vec { } /// Prints index

[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3578: Use native types in PageIndex (#3575)

tustvold commented on code in PR #3578: URL: https://github.com/apache/arrow-rs/pull/3578#discussion_r1082672397 ## parquet/src/file/page_index/index.rs: ## @@ -53,14 +53,14 @@ pub enum Index { /// will only return pageLocations without min_max index, /// `NONE`

[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3578: Use native types in PageIndex (#3575)

tustvold commented on code in PR #3578: URL: https://github.com/apache/arrow-rs/pull/3578#discussion_r1082671978 ## parquet/src/util/bit_util.rs: ## @@ -17,76 +17,104 @@ use std::{cmp, mem::size_of}; -use crate::data_type::AsBytes; +use crate::data_type::{AsBytes,

[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3578: Use native types in PageIndex (#3575)

tustvold commented on code in PR #3578: URL: https://github.com/apache/arrow-rs/pull/3578#discussion_r1082671374 ## parquet/src/file/statistics.rs: ## @@ -181,11 +181,11 @@ pub fn from_thrift( // min/max statistics for INT96 columns.

[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3578: Use native types in PageIndex (#3575)

tustvold commented on code in PR #3578: URL: https://github.com/apache/arrow-rs/pull/3578#discussion_r1082668780 ## parquet/src/util/bit_util.rs: ## @@ -17,76 +17,104 @@ use std::{cmp, mem::size_of}; -use crate::data_type::AsBytes; +use crate::data_type::{AsBytes,

[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3578: Use native types in PageIndex (#3575)

tustvold commented on code in PR #3578: URL: https://github.com/apache/arrow-rs/pull/3578#discussion_r1082605700 ## parquet/src/bin/parquet-index.rs: ## @@ -132,7 +132,7 @@ fn compute_row_counts(offset_index: &[PageLocation], rows: i64) -> Vec { } /// Prints index