[GitHub] [arrow-rs] viirya commented on a diff in pull request #3572: Packing array into dictionary of generic byte array

2023-01-20 Thread GitBox
viirya commented on code in PR #3572: URL: https://github.com/apache/arrow-rs/pull/3572#discussion_r1082878810 ## arrow-cast/src/cast.rs: ## @@ -3344,42 +3350,23 @@ where Ok(Arc::new(b.finish())) } -// Packs the data as a StringDictionaryArray, if possible, with the -//

[GitHub] [arrow-rs] viirya commented on a diff in pull request #3572: Packing array into dictionary of generic byte array

2023-01-20 Thread GitBox
viirya commented on code in PR #3572: URL: https://github.com/apache/arrow-rs/pull/3572#discussion_r1082878810 ## arrow-cast/src/cast.rs: ## @@ -3344,42 +3350,23 @@ where Ok(Arc::new(b.finish())) } -// Packs the data as a StringDictionaryArray, if possible, with the -//