Re: [I] Rust Interval definition incorrect [arrow-rs]

2024-06-03 Thread via GitHub
tustvold commented on issue #5654: URL: https://github.com/apache/arrow-rs/issues/5654#issuecomment-2144828847 `label_issue.py` automatically added labels {'arrow'} from #5769 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [I] Rust Interval definition incorrect [arrow-rs]

2024-06-03 Thread via GitHub
tustvold commented on issue #5654: URL: https://github.com/apache/arrow-rs/issues/5654#issuecomment-2144828720 `label_issue.py` automatically added labels {'parquet'} from #5769 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [I] Rust Interval definition incorrect [arrow-rs]

2024-05-31 Thread via GitHub
alamb commented on issue #5654: URL: https://github.com/apache/arrow-rs/issues/5654#issuecomment-2141612597 > @alamb any idea on when [52.0.0](https://github.com/apache/arrow-rs/issues/5688) will be deployed? The plan as I understand it is next week -- This is an automated

Re: [I] Rust Interval definition incorrect [arrow-rs]

2024-05-30 Thread via GitHub
david542542 commented on issue #5654: URL: https://github.com/apache/arrow-rs/issues/5654#issuecomment-2140998763 @alamb any idea on when https://github.com/apache/arrow-rs/issues/5688 will be deployed? -- This is an automated message from the Apache Git Service. To respond to the

Re: [I] Rust Interval definition incorrect [arrow-rs]

2024-05-20 Thread via GitHub
tustvold closed issue #5654: Rust Interval definition incorrect URL: https://github.com/apache/arrow-rs/issues/5654 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [I] Rust Interval definition incorrect [arrow-rs]

2024-05-17 Thread via GitHub
alamb commented on issue #5654: URL: https://github.com/apache/arrow-rs/issues/5654#issuecomment-2117975046 Proposed PR: https://github.com/apache/arrow-rs/pull/5769 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [I] Rust Interval definition incorrect [arrow-rs]

2024-05-13 Thread via GitHub
alamb commented on issue #5654: URL: https://github.com/apache/arrow-rs/issues/5654#issuecomment-2108732883 We are holding the [`52.0.0` release for this](https://github.com/apache/arrow-rs/issues/5688). I expect it will be available in about 2 weeks but no promises, etc -- This is an

Re: [I] Rust Interval definition incorrect [arrow-rs]

2024-05-13 Thread via GitHub
david542542 commented on issue #5654: URL: https://github.com/apache/arrow-rs/issues/5654#issuecomment-2108722445 That's great to know. Any idea on the ETA on this fix? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [I] Rust Interval definition incorrect [arrow-rs]

2024-05-13 Thread via GitHub
tustvold commented on issue #5654: URL: https://github.com/apache/arrow-rs/issues/5654#issuecomment-2108044769 It turns out the reason we didn't detect this with our integration tests, is that they were actually using different, correct, logic for constructing the expected values from the

Re: [I] Rust Interval definition incorrect [arrow-rs]

2024-04-24 Thread via GitHub
alamb commented on issue #5654: URL: https://github.com/apache/arrow-rs/issues/5654#issuecomment-2075207796 Typing down some things that @tustvold told me today: 1. we think the tests ensure the data round trips but does not actually ensure both ends interpret them in the same way

Re: [I] Rust Interval definition incorrect [arrow-rs]

2024-04-24 Thread via GitHub
tustvold commented on issue #5654: URL: https://github.com/apache/arrow-rs/issues/5654#issuecomment-2074140467 One way to avoid this leading to subtle downstream breakage might be to do something along the lines of https://github.com/apache/arrow-rs/issues/3125 -- This is an automated

Re: [I] Rust Interval definition incorrect [arrow-rs]

2024-04-17 Thread via GitHub
pitrou commented on issue #5654: URL: https://github.com/apache/arrow-rs/issues/5654#issuecomment-2060833519 > @pitrou do you know if the integration tests cover the interval types? Yes, they do.

Re: [I] Rust Interval definition incorrect [arrow-rs]

2024-04-16 Thread via GitHub
avantgardnerio commented on issue #5654: URL: https://github.com/apache/arrow-rs/issues/5654#issuecomment-2060058201 > @avantgardnerio as the author of #2235 which appears to have switched these round, perhaps you could weigh in here Honestly, I don't recall the reasoning. I know at

Re: [I] Rust Interval definition incorrect [arrow-rs]

2024-04-16 Thread via GitHub
tustvold commented on issue #5654: URL: https://github.com/apache/arrow-rs/issues/5654#issuecomment-2060012409 @pitrou do you know if the integration tests cover the interval types? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to