conbench-apache-arrow[bot] commented on PR #41174:
URL: https://github.com/apache/arrow/pull/41174#issuecomment-2063134354
After merging your PR, Conbench analyzed the 6 benchmarking runs that have
been run so far on merge-commit 7003e90c113cec58a620deddf56af71eb305af2a.
There were no
lidavidm merged PR #41174:
URL: https://github.com/apache/arrow/pull/41174
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apac
github-actions[bot] commented on PR #41174:
URL: https://github.com/apache/arrow/pull/41174#issuecomment-2060360257
Revision: 590d4e9a165a3981a0476efe429a784fd58c68b2
Submitted crossbow builds: [ursacomputing/crossbow @
actions-c929748329](https://github.com/ursacomputing/crossbow/bra
vibhatha commented on PR #41174:
URL: https://github.com/apache/arrow/pull/41174#issuecomment-2060357817
@github-actions crossbow submit -g java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
vibhatha commented on PR #41174:
URL: https://github.com/apache/arrow/pull/41174#issuecomment-2060356542
But this PR is manageable. We can use the other spotless tickets to format
code and licenses.
--
This is an automated message from the Apache Git Service.
To respond to the message, p
vibhatha commented on PR #41174:
URL: https://github.com/apache/arrow/pull/41174#issuecomment-2060355456
> The previous PR formatted nearly everything.
Yes, except the Java. I looked into the changes. I am not an expert with
spotless, but this only formats the pom.
It would be
lidavidm commented on PR #41174:
URL: https://github.com/apache/arrow/pull/41174#issuecomment-2058123153
The previous PR formatted nearly everything.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
vibhatha commented on PR #41174:
URL: https://github.com/apache/arrow/pull/41174#issuecomment-2058102287
> I saw the spotless change but I assumed (wrongly) it was for Java files,
not `pom.xml`. My bad.
>
>
>
> I would argue that `pom.xml` have a style on their own, and that
vibhatha commented on PR #41174:
URL: https://github.com/apache/arrow/pull/41174#issuecomment-2058099320
This is formatting all poms. I thought we wanted a smaller diff as a
previous PR was closed for the length of it.
If this solves the problem, let's close the issues created per mo
lidavidm commented on PR #41174:
URL: https://github.com/apache/arrow/pull/41174#issuecomment-2058015411
I think we can do this first. @vibhatha would it conflict?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
laurentgo commented on PR #41174:
URL: https://github.com/apache/arrow/pull/41174#issuecomment-2057240581
I saw the spotless change but I assumed it was for Java files, not
`pom.xml`. I would argue that `pom.xml` are style on their own, and that
there's only a few of them (compared to the n
vibhatha commented on PR #41174:
URL: https://github.com/apache/arrow/pull/41174#issuecomment-2055944308
@laurentgo there is already and effort to add this module by module:
https://github.com/apache/arrow/issues/40757
--
This is an automated message from the Apache Git Service.
T
github-actions[bot] commented on PR #41174:
URL: https://github.com/apache/arrow/pull/41174#issuecomment-2052489444
:warning: GitHub issue #41173 **has been automatically assigned in GitHub**
to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the mes
13 matches
Mail list logo