conbench-apache-arrow[bot] commented on PR #41257:
URL: https://github.com/apache/arrow/pull/41257#issuecomment-2101900145
After merging your PR, Conbench analyzed the 0 benchmarking runs that have
been run so far on merge-commit 071ffaf2633eb58540a872514507ab362cc26fb4.
None of the
rok merged PR #41257:
URL: https://github.com/apache/arrow/pull/41257
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
rok commented on PR #41257:
URL: https://github.com/apache/arrow/pull/41257#issuecomment-2100249185
If there's no further comments I'll merge this today.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
rok commented on code in PR #41257:
URL: https://github.com/apache/arrow/pull/41257#discussion_r1592685582
##
docs/source/format/CanonicalExtensions.rst:
##
@@ -251,6 +251,27 @@ Variable shape tensor
Values inside each **data** tensor element are stored in
pitrou commented on code in PR #41257:
URL: https://github.com/apache/arrow/pull/41257#discussion_r1592675429
##
docs/source/format/CanonicalExtensions.rst:
##
@@ -251,6 +251,27 @@ Variable shape tensor
Values inside each **data** tensor element are stored in
jorisvandenbossche commented on code in PR #41257:
URL: https://github.com/apache/arrow/pull/41257#discussion_r1592671363
##
docs/source/format/CanonicalExtensions.rst:
##
@@ -251,6 +251,27 @@ Variable shape tensor
Values inside each **data** tensor element are stored in
rok commented on code in PR #41257:
URL: https://github.com/apache/arrow/pull/41257#discussion_r1592670297
##
docs/source/format/CanonicalExtensions.rst:
##
@@ -51,7 +51,7 @@ types:
3) Its serialization *must* be described in the proposal and should
not require
rok commented on code in PR #41257:
URL: https://github.com/apache/arrow/pull/41257#discussion_r1592667968
##
docs/source/format/CanonicalExtensions.rst:
##
@@ -51,7 +51,7 @@ types:
3) Its serialization *must* be described in the proposal and should
not require
pitrou commented on code in PR #41257:
URL: https://github.com/apache/arrow/pull/41257#discussion_r1592666250
##
docs/source/format/CanonicalExtensions.rst:
##
@@ -51,7 +51,7 @@ types:
3) Its serialization *must* be described in the proposal and should
not require
pitrou commented on code in PR #41257:
URL: https://github.com/apache/arrow/pull/41257#discussion_r1592665683
##
docs/source/format/CanonicalExtensions.rst:
##
@@ -51,7 +51,7 @@ types:
3) Its serialization *must* be described in the proposal and should
not require
rok commented on code in PR #41257:
URL: https://github.com/apache/arrow/pull/41257#discussion_r1592661795
##
docs/source/format/CanonicalExtensions.rst:
##
@@ -51,7 +51,7 @@ types:
3) Its serialization *must* be described in the proposal and should
not require
ianmcook commented on PR #41257:
URL: https://github.com/apache/arrow/pull/41257#issuecomment-2098556532
On line 54 of `CanonicalExtensions.rst`, JSON is cited as a hypothetical
example of a canonical extension type:
> for example, a trivial custom text format **or JSON** would be
pitrou commented on code in PR #41257:
URL: https://github.com/apache/arrow/pull/41257#discussion_r1592423422
##
docs/source/format/CanonicalExtensions.rst:
##
@@ -251,6 +251,27 @@ Variable shape tensor
Values inside each **data** tensor element are stored in
westonpace commented on code in PR #41257:
URL: https://github.com/apache/arrow/pull/41257#discussion_r1589739730
##
docs/source/format/CanonicalExtensions.rst:
##
@@ -251,6 +251,27 @@ Variable shape tensor
Values inside each **data** tensor element are stored in
jorisvandenbossche commented on code in PR #41257:
URL: https://github.com/apache/arrow/pull/41257#discussion_r1585935670
##
docs/source/format/CanonicalExtensions.rst:
##
@@ -251,6 +251,27 @@ Variable shape tensor
Values inside each **data** tensor element are stored in
progger-dev commented on code in PR #41257:
URL: https://github.com/apache/arrow/pull/41257#discussion_r1585672675
##
docs/source/format/CanonicalExtensions.rst:
##
@@ -251,6 +251,27 @@ Variable shape tensor
Values inside each **data** tensor element are stored in
rok commented on code in PR #41257:
URL: https://github.com/apache/arrow/pull/41257#discussion_r1585499203
##
docs/source/format/CanonicalExtensions.rst:
##
@@ -251,6 +251,27 @@ Variable shape tensor
Values inside each **data** tensor element are stored in
pitrou commented on code in PR #41257:
URL: https://github.com/apache/arrow/pull/41257#discussion_r1585434862
##
docs/source/format/CanonicalExtensions.rst:
##
@@ -251,6 +251,27 @@ Variable shape tensor
Values inside each **data** tensor element are stored in
progger-dev commented on code in PR #41257:
URL: https://github.com/apache/arrow/pull/41257#discussion_r1585322513
##
docs/source/format/CanonicalExtensions.rst:
##
@@ -251,6 +251,27 @@ Variable shape tensor
Values inside each **data** tensor element are stored in
jorisvandenbossche commented on code in PR #41257:
URL: https://github.com/apache/arrow/pull/41257#discussion_r1585269512
##
docs/source/format/CanonicalExtensions.rst:
##
@@ -251,6 +251,27 @@ Variable shape tensor
Values inside each **data** tensor element are stored in
rok commented on code in PR #41257:
URL: https://github.com/apache/arrow/pull/41257#discussion_r1585212898
##
docs/source/format/CanonicalExtensions.rst:
##
@@ -251,6 +251,27 @@ Variable shape tensor
Values inside each **data** tensor element are stored in
rok commented on code in PR #41257:
URL: https://github.com/apache/arrow/pull/41257#discussion_r1585212898
##
docs/source/format/CanonicalExtensions.rst:
##
@@ -251,6 +251,27 @@ Variable shape tensor
Values inside each **data** tensor element are stored in
rok commented on code in PR #41257:
URL: https://github.com/apache/arrow/pull/41257#discussion_r1585212898
##
docs/source/format/CanonicalExtensions.rst:
##
@@ -251,6 +251,27 @@ Variable shape tensor
Values inside each **data** tensor element are stored in
rok commented on code in PR #41257:
URL: https://github.com/apache/arrow/pull/41257#discussion_r1585219769
##
docs/source/format/CanonicalExtensions.rst:
##
@@ -251,6 +251,27 @@ Variable shape tensor
Values inside each **data** tensor element are stored in
rok commented on code in PR #41257:
URL: https://github.com/apache/arrow/pull/41257#discussion_r1585212898
##
docs/source/format/CanonicalExtensions.rst:
##
@@ -251,6 +251,27 @@ Variable shape tensor
Values inside each **data** tensor element are stored in
westonpace commented on code in PR #41257:
URL: https://github.com/apache/arrow/pull/41257#discussion_r1585081438
##
docs/source/format/CanonicalExtensions.rst:
##
@@ -251,6 +251,27 @@ Variable shape tensor
Values inside each **data** tensor element are stored in
jorisvandenbossche commented on code in PR #41257:
URL: https://github.com/apache/arrow/pull/41257#discussion_r1584195785
##
docs/source/format/CanonicalExtensions.rst:
##
@@ -251,6 +251,27 @@ Variable shape tensor
Values inside each **data** tensor element are stored in
ianmcook commented on code in PR #41257:
URL: https://github.com/apache/arrow/pull/41257#discussion_r1583809602
##
docs/source/format/CanonicalExtensions.rst:
##
@@ -251,6 +251,27 @@ Variable shape tensor
Values inside each **data** tensor element are stored in
emkornfield commented on code in PR #41257:
URL: https://github.com/apache/arrow/pull/41257#discussion_r1583465935
##
docs/source/format/CanonicalExtensions.rst:
##
@@ -251,6 +251,27 @@ Variable shape tensor
Values inside each **data** tensor element are stored in
rouault commented on code in PR #41257:
URL: https://github.com/apache/arrow/pull/41257#discussion_r1583444710
##
docs/source/format/CanonicalExtensions.rst:
##
@@ -251,6 +251,27 @@ Variable shape tensor
Values inside each **data** tensor element are stored in
emkornfield commented on code in PR #41257:
URL: https://github.com/apache/arrow/pull/41257#discussion_r1583441040
##
docs/source/format/CanonicalExtensions.rst:
##
@@ -251,6 +251,27 @@ Variable shape tensor
Values inside each **data** tensor element are stored in
progger-dev commented on code in PR #41257:
URL: https://github.com/apache/arrow/pull/41257#discussion_r1575445365
##
docs/source/format/CanonicalExtensions.rst:
##
@@ -251,6 +251,27 @@ Variable shape tensor
Values inside each **data** tensor element are stored in
rouault commented on code in PR #41257:
URL: https://github.com/apache/arrow/pull/41257#discussion_r1573896963
##
docs/source/format/CanonicalExtensions.rst:
##
@@ -251,6 +251,27 @@ Variable shape tensor
Values inside each **data** tensor element are stored in
progger-dev commented on code in PR #41257:
URL: https://github.com/apache/arrow/pull/41257#discussion_r1573871660
##
docs/source/format/CanonicalExtensions.rst:
##
@@ -251,6 +251,27 @@ Variable shape tensor
Values inside each **data** tensor element are stored in
wjones127 commented on code in PR #41257:
URL: https://github.com/apache/arrow/pull/41257#discussion_r1573348702
##
docs/source/format/CanonicalExtensions.rst:
##
@@ -251,6 +251,27 @@ Variable shape tensor
Values inside each **data** tensor element are stored in
rouault commented on code in PR #41257:
URL: https://github.com/apache/arrow/pull/41257#discussion_r1573296182
##
docs/source/format/CanonicalExtensions.rst:
##
@@ -251,6 +251,27 @@ Variable shape tensor
Values inside each **data** tensor element are stored in
rok commented on code in PR #41257:
URL: https://github.com/apache/arrow/pull/41257#discussion_r1573298088
##
docs/source/format/CanonicalExtensions.rst:
##
@@ -251,6 +251,27 @@ Variable shape tensor
Values inside each **data** tensor element are stored in
rok commented on code in PR #41257:
URL: https://github.com/apache/arrow/pull/41257#discussion_r1573298088
##
docs/source/format/CanonicalExtensions.rst:
##
@@ -251,6 +251,27 @@ Variable shape tensor
Values inside each **data** tensor element are stored in
jorisvandenbossche commented on code in PR #41257:
URL: https://github.com/apache/arrow/pull/41257#discussion_r1573281316
##
docs/source/format/CanonicalExtensions.rst:
##
@@ -251,6 +251,27 @@ Variable shape tensor
Values inside each **data** tensor element are stored in
rok commented on PR #41257:
URL: https://github.com/apache/arrow/pull/41257#issuecomment-2066401698
If there's nothing further here I'll call a ML vote later today.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
rok commented on code in PR #41257:
URL: https://github.com/apache/arrow/pull/41257#discussion_r1571516958
##
docs/source/format/CanonicalExtensions.rst:
##
@@ -251,6 +251,26 @@ Variable shape tensor
Values inside each **data** tensor element are stored in
rok commented on code in PR #41257:
URL: https://github.com/apache/arrow/pull/41257#discussion_r1571026818
##
docs/source/format/CanonicalExtensions.rst:
##
@@ -251,6 +251,26 @@ Variable shape tensor
Values inside each **data** tensor element are stored in
rok commented on code in PR #41257:
URL: https://github.com/apache/arrow/pull/41257#discussion_r1571026818
##
docs/source/format/CanonicalExtensions.rst:
##
@@ -251,6 +251,26 @@ Variable shape tensor
Values inside each **data** tensor element are stored in
lidavidm commented on code in PR #41257:
URL: https://github.com/apache/arrow/pull/41257#discussion_r1571508109
##
docs/source/format/CanonicalExtensions.rst:
##
@@ -251,6 +251,26 @@ Variable shape tensor
Values inside each **data** tensor element are stored in
rok commented on code in PR #41257:
URL: https://github.com/apache/arrow/pull/41257#discussion_r1571026818
##
docs/source/format/CanonicalExtensions.rst:
##
@@ -251,6 +251,26 @@ Variable shape tensor
Values inside each **data** tensor element are stored in
rok commented on code in PR #41257:
URL: https://github.com/apache/arrow/pull/41257#discussion_r1571026818
##
docs/source/format/CanonicalExtensions.rst:
##
@@ -251,6 +251,26 @@ Variable shape tensor
Values inside each **data** tensor element are stored in
pitrou commented on code in PR #41257:
URL: https://github.com/apache/arrow/pull/41257#discussion_r1571022394
##
docs/source/format/CanonicalExtensions.rst:
##
@@ -251,6 +251,25 @@ Variable shape tensor
Values inside each **data** tensor element are stored in
rok commented on code in PR #41257:
URL: https://github.com/apache/arrow/pull/41257#discussion_r1571018013
##
docs/source/format/CanonicalExtensions.rst:
##
@@ -251,6 +251,25 @@ Variable shape tensor
Values inside each **data** tensor element are stored in
rok commented on code in PR #41257:
URL: https://github.com/apache/arrow/pull/41257#discussion_r1571011302
##
docs/source/format/CanonicalExtensions.rst:
##
@@ -251,6 +251,24 @@ Variable shape tensor
Values inside each **data** tensor element are stored in
wjones127 commented on code in PR #41257:
URL: https://github.com/apache/arrow/pull/41257#discussion_r1570995188
##
docs/source/format/CanonicalExtensions.rst:
##
@@ -251,6 +251,24 @@ Variable shape tensor
Values inside each **data** tensor element are stored in
tustvold commented on code in PR #41257:
URL: https://github.com/apache/arrow/pull/41257#discussion_r1570982701
##
docs/source/format/CanonicalExtensions.rst:
##
@@ -251,6 +251,24 @@ Variable shape tensor
Values inside each **data** tensor element are stored in
tustvold commented on PR #41257:
URL: https://github.com/apache/arrow/pull/41257#issuecomment-2064252327
This makes sense to me. I did have a potentially stupid thought that perhaps
we just define a canonical "MIME" extension type, and that way avoid having to
define lots of MIME types,
wjones127 commented on code in PR #41257:
URL: https://github.com/apache/arrow/pull/41257#discussion_r1570967434
##
docs/source/format/CanonicalExtensions.rst:
##
@@ -251,6 +251,25 @@ Variable shape tensor
Values inside each **data** tensor element are stored in
rok commented on code in PR #41257:
URL: https://github.com/apache/arrow/pull/41257#discussion_r1569070238
##
docs/source/format/CanonicalExtensions.rst:
##
@@ -251,6 +251,25 @@ Variable shape tensor
Values inside each **data** tensor element are stored in
rok commented on code in PR #41257:
URL: https://github.com/apache/arrow/pull/41257#discussion_r1569069770
##
docs/source/format/CanonicalExtensions.rst:
##
@@ -251,6 +251,25 @@ Variable shape tensor
Values inside each **data** tensor element are stored in
pitrou commented on code in PR #41257:
URL: https://github.com/apache/arrow/pull/41257#discussion_r1569052310
##
docs/source/format/CanonicalExtensions.rst:
##
@@ -251,6 +251,25 @@ Variable shape tensor
Values inside each **data** tensor element are stored in
pitrou commented on code in PR #41257:
URL: https://github.com/apache/arrow/pull/41257#discussion_r1569050236
##
docs/source/format/CanonicalExtensions.rst:
##
@@ -251,6 +251,25 @@ Variable shape tensor
Values inside each **data** tensor element are stored in
pitrou commented on code in PR #41257:
URL: https://github.com/apache/arrow/pull/41257#discussion_r1569047346
##
docs/source/format/CanonicalExtensions.rst:
##
@@ -251,6 +251,25 @@ Variable shape tensor
Values inside each **data** tensor element are stored in
rok commented on PR #41257:
URL: https://github.com/apache/arrow/pull/41257#issuecomment-2061561335
@pitrou this is now fully JSONified. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
59 matches
Mail list logo