Re: [PR] Refactor `UnwrapCastInComparison` to implement `OptimizerRule::rewrite()` [arrow-datafusion]

peter-toth commented on PR #10087: URL: https://github.com/apache/arrow-datafusion/pull/10087#issuecomment-2061643740 @alamb, @jayzhan211 here is a follow-up PR to remove remaining `Expr` clones: https://github.com/apache/arrow-datafusion/pull/10115 -- This is an automated message from

Re: [PR] Refactor `UnwrapCastInComparison` to implement `OptimizerRule::rewrite()` [arrow-datafusion]

peter-toth commented on PR #10087: URL: https://github.com/apache/arrow-datafusion/pull/10087#issuecomment-2058512917 > There are still some `Expr` copies left in the actual implementation I noticed, but this gets a bunch of the structural copying out of the way I will try to

Re: [PR] Refactor `UnwrapCastInComparison` to implement `OptimizerRule::rewrite()` [arrow-datafusion]

jayzhan211 commented on PR #10087: URL: https://github.com/apache/arrow-datafusion/pull/10087#issuecomment-2058134930 Thanks @peter-toth -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Refactor `UnwrapCastInComparison` to implement `OptimizerRule::rewrite()` [arrow-datafusion]

jayzhan211 merged PR #10087: URL: https://github.com/apache/arrow-datafusion/pull/10087 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: