Re: [PR] GH-41186: [C++][Parquet][Doc] Denote PARQUET:field_id in parquet.rst [arrow]

2024-05-24 Thread via GitHub
pitrou commented on PR #41187: URL: https://github.com/apache/arrow/pull/41187#issuecomment-2130015812 It's ok @mapleFU ! There's no pressure to be always present :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] GH-41186: [C++][Parquet][Doc] Denote PARQUET:field_id in parquet.rst [arrow]

2024-05-24 Thread via GitHub
mapleFU commented on PR #41187: URL: https://github.com/apache/arrow/pull/41187#issuecomment-2130014680 @pitrou Thank for catching up! I'm a bit dizzy and sick these days, sorry for forgot to updating this -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] GH-41186: [C++][Parquet][Doc] Denote PARQUET:field_id in parquet.rst [arrow]

2024-05-23 Thread via GitHub
conbench-apache-arrow[bot] commented on PR #41187: URL: https://github.com/apache/arrow/pull/41187#issuecomment-2128428665 After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 8bcdc0f3849e616dc09b8c19bbc1387c1773639b. There were

Re: [PR] GH-41186: [C++][Parquet][Doc] Denote PARQUET:field_id in parquet.rst [arrow]

2024-05-23 Thread via GitHub
pitrou merged PR #41187: URL: https://github.com/apache/arrow/pull/41187 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] GH-41186: [C++][Parquet][Doc] Denote PARQUET:field_id in parquet.rst [arrow]

2024-05-13 Thread via GitHub
pitrou commented on PR #41187: URL: https://github.com/apache/arrow/pull/41187#issuecomment-2107871987 This is not what I suggested. "Limitations" is part of the "Types" section, but "Field id" is not. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] GH-41186: [C++][Parquet][Doc] Denote PARQUET:field_id in parquet.rst [arrow]

2024-05-13 Thread via GitHub
mapleFU commented on PR #41187: URL: https://github.com/apache/arrow/pull/41187#issuecomment-2107794529 ![1fd54f9f3e37c551adbb3166d4e9b255](https://github.com/apache/arrow/assets/24351052/c80c10d4-4baa-4e7d-9505-60c9be270ee9) Change to like this now -- This is an automated message

Re: [PR] GH-41186: [C++][Parquet][Doc] Denote PARQUET:field_id in parquet.rst [arrow]

2024-05-13 Thread via GitHub
pitrou commented on code in PR #41187: URL: https://github.com/apache/arrow/pull/41187#discussion_r1598410714 ## docs/source/cpp/parquet.rst: ## @@ -542,13 +542,28 @@ As an example, when serializing an Arrow LargeList to Parquet: :func:`ArrowWriterProperties::store_schema`

Re: [PR] GH-41186: [C++][Parquet][Doc] Denote PARQUET:field_id in parquet.rst [arrow]

2024-05-06 Thread via GitHub
github-actions[bot] commented on PR #41187: URL: https://github.com/apache/arrow/pull/41187#issuecomment-2096372219 Revision: 946a4bf202f2f591ec014958da0d255a5e7d Submitted crossbow builds: [ursacomputing/crossbow @

Re: [PR] GH-41186: [C++][Parquet][Doc] Denote PARQUET:field_id in parquet.rst [arrow]

2024-05-06 Thread via GitHub
mapleFU commented on PR #41187: URL: https://github.com/apache/arrow/pull/41187#issuecomment-2096363623 @github-actions crossbow submit preview-docs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] GH-41186: [C++][Parquet][Doc] Denote PARQUET:field_id in parquet.rst [arrow]

2024-05-06 Thread via GitHub
pitrou commented on code in PR #41187: URL: https://github.com/apache/arrow/pull/41187#discussion_r1591080513 ## docs/source/cpp/parquet.rst: ## @@ -542,6 +542,19 @@ As an example, when serializing an Arrow LargeList to Parquet: :func:`ArrowWriterProperties::store_schema`

Re: [PR] GH-41186: [C++][Parquet][Doc] Denote PARQUET:field_id in parquet.rst [arrow]

2024-04-25 Thread via GitHub
wgtmac commented on code in PR #41187: URL: https://github.com/apache/arrow/pull/41187#discussion_r1580506607 ## docs/source/cpp/parquet.rst: ## @@ -542,6 +542,19 @@ As an example, when serializing an Arrow LargeList to Parquet: :func:`ArrowWriterProperties::store_schema`

Re: [PR] GH-41186: [C++][Parquet][Doc] Denote PARQUET:field_id in parquet.rst [arrow]

2024-04-24 Thread via GitHub
mapleFU commented on PR #41187: URL: https://github.com/apache/arrow/pull/41187#issuecomment-2075397876 Oh, sorry for bothering, enjoy your traveling! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] GH-41186: [C++][Parquet][Doc] Denote PARQUET:field_id in parquet.rst [arrow]

2024-04-24 Thread via GitHub
jbonofre commented on PR #41187: URL: https://github.com/apache/arrow/pull/41187#issuecomment-2075391064 Sure thing ! I'm traveling this week but I should find time ;) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] GH-41186: [C++][Parquet][Doc] Denote PARQUET:field_id in parquet.rst [arrow]

2024-04-24 Thread via GitHub
mapleFU commented on PR #41187: URL: https://github.com/apache/arrow/pull/41187#issuecomment-2075387348 cc @jbonofre would you mind take a look since you're familiar with iceberg :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] GH-41186: [C++][Parquet][Doc] Denote PARQUET:field_id in parquet.rst [arrow]

2024-04-17 Thread via GitHub
mapleFU commented on code in PR #41187: URL: https://github.com/apache/arrow/pull/41187#discussion_r1569103822 ## docs/source/cpp/parquet.rst: ## @@ -571,6 +571,19 @@ More specifically, Parquet C++ supports: * EncryptionWithFooterKey and EncryptionWithColumnKey modes. *

Re: [PR] GH-41186: [C++][Parquet][Doc] Denote PARQUET:field_id in parquet.rst [arrow]

2024-04-17 Thread via GitHub
pitrou commented on code in PR #41187: URL: https://github.com/apache/arrow/pull/41187#discussion_r1569084922 ## docs/source/cpp/parquet.rst: ## @@ -571,6 +571,19 @@ More specifically, Parquet C++ supports: * EncryptionWithFooterKey and EncryptionWithColumnKey modes. *

Re: [PR] GH-41186: [C++][Parquet][Doc] Denote PARQUET:field_id in parquet.rst [arrow]

2024-04-17 Thread via GitHub
pitrou commented on code in PR #41187: URL: https://github.com/apache/arrow/pull/41187#discussion_r1569084382 ## docs/source/cpp/parquet.rst: ## @@ -571,6 +571,19 @@ More specifically, Parquet C++ supports: * EncryptionWithFooterKey and EncryptionWithColumnKey modes. *

Re: [PR] GH-41186: [C++][Parquet][Doc] Denote PARQUET:field_id in parquet.rst [arrow]

2024-04-17 Thread via GitHub
pitrou commented on code in PR #41187: URL: https://github.com/apache/arrow/pull/41187#discussion_r1569083748 ## docs/source/cpp/parquet.rst: ## @@ -571,6 +571,19 @@ More specifically, Parquet C++ supports: * EncryptionWithFooterKey and EncryptionWithColumnKey modes. *

Re: [PR] GH-41186: [C++][Parquet][Doc] Denote PARQUET:field_id in parquet.rst [arrow]

2024-04-17 Thread via GitHub
pitrou commented on code in PR #41187: URL: https://github.com/apache/arrow/pull/41187#discussion_r1569082708 ## docs/source/cpp/parquet.rst: ## @@ -571,6 +571,19 @@ More specifically, Parquet C++ supports: * EncryptionWithFooterKey and EncryptionWithColumnKey modes. *

Re: [PR] GH-41186: [C++][Parquet][Doc] Denote PARQUET:field_id in parquet.rst [arrow]

2024-04-14 Thread via GitHub
mapleFU commented on code in PR #41187: URL: https://github.com/apache/arrow/pull/41187#discussion_r1564770499 ## docs/source/cpp/parquet.rst: ## @@ -571,6 +571,19 @@ More specifically, Parquet C++ supports: * EncryptionWithFooterKey and EncryptionWithColumnKey modes. *

Re: [PR] GH-41186: [C++][Parquet][Doc] Denote PARQUET:field_id in parquet.rst [arrow]

2024-04-14 Thread via GitHub
wgtmac commented on code in PR #41187: URL: https://github.com/apache/arrow/pull/41187#discussion_r1564762713 ## docs/source/cpp/parquet.rst: ## @@ -571,6 +571,19 @@ More specifically, Parquet C++ supports: * EncryptionWithFooterKey and EncryptionWithColumnKey modes. *

Re: [PR] GH-41186: [C++][Parquet][Doc] Denote PARQUET:field_id in parquet.rst [arrow]

2024-04-13 Thread via GitHub
mapleFU commented on PR #41187: URL: https://github.com/apache/arrow/pull/41187#issuecomment-2053692516 @wgtmac @jorisvandenbossche This is just a doc improvement since this is already implemented -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] GH-41186: [C++][Parquet][Doc] Denote PARQUET:field_id in parquet.rst [arrow]

2024-04-13 Thread via GitHub
github-actions[bot] commented on PR #41187: URL: https://github.com/apache/arrow/pull/41187#issuecomment-2053692251 :warning: GitHub issue #41186 **has been automatically assigned in GitHub** to PR creator. -- This is an automated message from the Apache Git Service. To respond to the