github-actions[bot] commented on issue #7009:
URL: https://github.com/apache/arrow/pull/7009#issuecomment-617555901
https://issues.apache.org/jira/browse/ARROW-8552
This is an automated message from the Apache Git Service.
houqp opened a new pull request #7009:
URL: https://github.com/apache/arrow/pull/7009
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
github-actions[bot] commented on issue #7008:
URL: https://github.com/apache/arrow/pull/7008#issuecomment-617523989
https://issues.apache.org/jira/browse/ARROW-8551
This is an automated message from the Apache Git Service.
pprudhvi opened a new pull request #7008:
URL: https://github.com/apache/arrow/pull/7008
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
pprudhvi commented on issue #6990:
URL: https://github.com/apache/arrow/pull/6990#issuecomment-617519736
resolved with https://github.com/Homebrew/homebrew-core/pull/53445/files.
closing this
This is an automated message
cyb70289 commented on issue #6954:
URL: https://github.com/apache/arrow/pull/6954#issuecomment-617516947
> Maybe it was just a thought I had in my head but never expressed. Opened
https://issues.apache.org/jira/browse/ARROW-8531
Updated this patch to remove ARROW_USE_SIMD
wesm commented on issue #6578:
URL: https://github.com/apache/arrow/pull/6578#issuecomment-617515815
I haven't looked at the details of this binding too much, but I wanted to
let you know that I'm taking a closer look at the way that filter expressions
work in the datasets API in the
github-actions[bot] commented on issue #7007:
URL: https://github.com/apache/arrow/pull/7007#issuecomment-617494295
https://issues.apache.org/jira/browse/ARROW-8537
This is an automated message from the Apache Git Service.
cyb70289 opened a new pull request #7007:
URL: https://github.com/apache/arrow/pull/7007
Revert PR https://github.com/apache/arrow/pull/6986 as it introduces
big performance regression to BitmapAnd unaligned benchmark.
github-actions[bot] commented on issue #7006:
URL: https://github.com/apache/arrow/pull/7006#issuecomment-617490579
https://issues.apache.org/jira/browse/ARROW-8508
This is an automated message from the Apache Git Service.
markhildreth opened a new pull request #7006:
URL: https://github.com/apache/arrow/pull/7006
Potentially Fixes ARROW-8508
Fixed size list arrays sourced with a non-zero offset of their
child data was respecting this offset when calculating value offsets
in the `value_offset`
nealrichardson commented on issue #7005:
URL: https://github.com/apache/arrow/pull/7005#issuecomment-617477677
I believe the failure on Jira link might be expected: it's possible that the
pull-request token is not sufficiently authorized to run it. @kou does that
sound right?
I
github-actions[bot] commented on issue #7005:
URL: https://github.com/apache/arrow/pull/7005#issuecomment-617456224
https://issues.apache.org/jira/browse/ARROW-8550
This is an automated message from the Apache Git Service.
nealrichardson opened a new pull request #7005:
URL: https://github.com/apache/arrow/pull/7005
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
github-actions[bot] commented on issue #6995:
URL: https://github.com/apache/arrow/pull/6995#issuecomment-617445300
Revision: e7dbd9c977b765e618a40e997039be773c9f16bf
Submitted crossbow builds: [ursa-labs/crossbow @
nealrichardson commented on issue #6995:
URL: https://github.com/apache/arrow/pull/6995#issuecomment-617444872
@github-actions crossbow submit -g r
This is an automated message from the Apache Git Service.
To respond to the
github-actions[bot] commented on issue #6995:
URL: https://github.com/apache/arrow/pull/6995#issuecomment-617442386
https://issues.apache.org/jira/browse/ARROW-8549
This is an automated message from the Apache Git Service.
davidanthoff commented on a change in pull request #7001:
URL: https://github.com/apache/arrow/pull/7001#discussion_r412497174
##
File path: cpp/cmake_modules/FindThrift.cmake
##
@@ -100,7 +100,7 @@ if(Thrift_FOUND OR THRIFT_FOUND)
davidanthoff commented on a change in pull request #7001:
URL: https://github.com/apache/arrow/pull/7001#discussion_r412497174
##
File path: cpp/cmake_modules/FindThrift.cmake
##
@@ -100,7 +100,7 @@ if(Thrift_FOUND OR THRIFT_FOUND)
kou commented on a change in pull request #7001:
URL: https://github.com/apache/arrow/pull/7001#discussion_r412492656
##
File path: cpp/cmake_modules/FindThrift.cmake
##
@@ -100,7 +100,7 @@ if(Thrift_FOUND OR THRIFT_FOUND)
paddyhoran commented on issue #6306:
URL: https://github.com/apache/arrow/pull/6306#issuecomment-617402123
@nevi-me this needs a rebase now. Once you do that, I'll take a look so we
can get this merged.
This is an
wesm commented on a change in pull request #6744:
URL: https://github.com/apache/arrow/pull/6744#discussion_r412474320
##
File path: cpp/src/parquet/file_reader.h
##
@@ -117,6 +117,15 @@ class PARQUET_EXPORT ParquetFileReader {
// Returns the file metadata. Only one
wesm commented on a change in pull request #6744:
URL: https://github.com/apache/arrow/pull/6744#discussion_r412465641
##
File path: cpp/src/parquet/properties.h
##
@@ -56,10 +60,32 @@ class PARQUET_EXPORT ReaderProperties {
bool is_buffered_stream_enabled() const {
paddyhoran commented on a change in pull request #6980:
URL: https://github.com/apache/arrow/pull/6980#discussion_r412473292
##
File path: rust/arrow/src/array/builder.rs
##
@@ -236,6 +251,14 @@ impl BufferBuilderTrait for
BufferBuilder {
paddyhoran commented on issue #7004:
URL: https://github.com/apache/arrow/pull/7004#issuecomment-617399915
@kszucs it's failing due to `rustfmt` not being installed before testing the
flight crate, any idea why this would be the case? Sorry, I don't know much
about GitHub actions yet...
github-actions[bot] commented on issue #7004:
URL: https://github.com/apache/arrow/pull/7004#issuecomment-617398778
https://issues.apache.org/jira/browse/ARROW-3827
This is an automated message from the Apache Git Service.
paddyhoran commented on issue #6209:
URL: https://github.com/apache/arrow/pull/6209#issuecomment-617389640
Closing and I'll open a new PR.
This is an automated message from the Apache Git Service.
To respond to the message,
fsaintjacques commented on a change in pull request #7000:
URL: https://github.com/apache/arrow/pull/7000#discussion_r412452967
##
File path: python/pyarrow/tests/test_dataset.py
##
@@ -671,41 +669,29 @@ def test_fragments(tempdir):
f = fragments[0]
# file's schema
working-estimate opened a new issue #7003:
URL: https://github.com/apache/arrow/issues/7003
I have tried versions 0.15.1, 0.16.0, 0.17.0. Same error on all. I've seen
in other issues that co-installations of tensorflow and numpy might be causing
issues. I have tensorflow==1.14.0 and
fsaintjacques commented on issue #6986:
URL: https://github.com/apache/arrow/pull/6986#issuecomment-617368021
See either `archery benchmark diff --help` or the
[benchmark](https://arrow.apache.org/docs/developers/benchmarks.html) section
of the documentation. Archery can compare the same
davidanthoff commented on issue #7001:
URL: https://github.com/apache/arrow/pull/7001#issuecomment-617365369
> How does BinaryBuilder compile Windows binaries on Linux? Using MinGW?
Yes, it uses MinGW for Windows, but then it also cross-compiles to lots of
other platforms. The PR
kszucs commented on issue #6883:
URL: https://github.com/apache/arrow/pull/6883#issuecomment-617350272
The release is out, we can close this PR.
This is an automated message from the Apache Git Service.
To respond to the
fsaintjacques commented on a change in pull request #7000:
URL: https://github.com/apache/arrow/pull/7000#discussion_r412407398
##
File path: cpp/src/arrow/dataset/dataset.cc
##
@@ -72,36 +78,15 @@ Result> Dataset::NewScan() {
return NewScan(std::make_shared());
}
-bool
pitrou commented on issue #7002:
URL: https://github.com/apache/arrow/pull/7002#issuecomment-617339230
The original PR message is slightly misleading: both algorithms have the
same complexity (O(N) except for the sorting step which is O(N log N)).
However, it's true that the new algorithm
bkietz commented on a change in pull request #7000:
URL: https://github.com/apache/arrow/pull/7000#discussion_r412252930
##
File path: cpp/src/arrow/dataset/dataset.h
##
@@ -84,13 +82,12 @@ class ARROW_DS_EXPORT Fragment {
class ARROW_DS_EXPORT InMemoryFragment : public
github-actions[bot] commented on issue #7002:
URL: https://github.com/apache/arrow/pull/7002#issuecomment-617329923
https://issues.apache.org/jira/browse/ARROW-8543
This is an automated message from the Apache Git Service.
pitrou commented on a change in pull request #6959:
URL: https://github.com/apache/arrow/pull/6959#discussion_r412350484
##
File path: python/pyarrow/tests/test_extension_type.py
##
@@ -445,22 +445,28 @@ def test_parquet(tmpdir, registered_period_type):
import base64
pitrou commented on issue #7001:
URL: https://github.com/apache/arrow/pull/7001#issuecomment-617301935
(also, could you please open an issue on JIRA as explained above?)
This is an automated message from the Apache Git
pitrou commented on issue #7001:
URL: https://github.com/apache/arrow/pull/7001#issuecomment-617301716
How does `BinaryBuilder` compile Windows binaries on Linux? Using MinGW?
This is an automated message from the Apache Git
pitrou commented on a change in pull request #6959:
URL: https://github.com/apache/arrow/pull/6959#discussion_r412310009
##
File path: cpp/src/arrow/ipc/metadata_internal.cc
##
@@ -756,10 +737,35 @@ Status FieldFromFlatbuffer(const flatbuf::Field* field,
DictionaryMemo*
github-actions[bot] commented on issue #7001:
URL: https://github.com/apache/arrow/pull/7001#issuecomment-617271478
Thanks for opening a pull request!
Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW
Then could you
pitrou commented on a change in pull request #6959:
URL: https://github.com/apache/arrow/pull/6959#discussion_r412305089
##
File path: dev/archery/archery/integration/datagen.py
##
@@ -1401,6 +1437,18 @@ def generate_nested_dictionary_case():
davidanthoff opened a new pull request #7001:
URL: https://github.com/apache/arrow/pull/7001
With this patch I can cross-compile arrow from a Linux system, in particular
I can compile Windows binaries on a Linux system (using
https://binarybuilder.org/). I hope to eventually be able to
wesm commented on issue #6970:
URL: https://github.com/apache/arrow/pull/6970#issuecomment-617250883
+1. Appveyor build looks good
https://ci.appveyor.com/project/wesm/arrow/builds/32336612
This is an automated message from
jorisvandenbossche commented on a change in pull request #7000:
URL: https://github.com/apache/arrow/pull/7000#discussion_r412191161
##
File path: python/pyarrow/tests/test_dataset.py
##
@@ -671,41 +669,29 @@ def test_fragments(tempdir):
f = fragments[0]
# file's
github-actions[bot] commented on issue #6995:
URL: https://github.com/apache/arrow/pull/6995#issuecomment-617235575
Revision: f543317d36d39322bd339b49dd8867cbd3f2ad70
Submitted crossbow builds: [ursa-labs/crossbow @
nealrichardson commented on issue #6996:
URL: https://github.com/apache/arrow/pull/6996#issuecomment-617232353
¯\_(ツ)_/¯ maybe it's time to port this job to GHA
This is an automated message from the Apache Git Service.
To
wesm commented on issue #6986:
URL: https://github.com/apache/arrow/pull/6986#issuecomment-617228774
FWIW, we have some benchmark diffing code already written in
https://github.com/apache/arrow/blob/master/dev/archery/archery/benchmark
I'm not sure where this is documented /
pitrou commented on a change in pull request #6959:
URL: https://github.com/apache/arrow/pull/6959#discussion_r412227300
##
File path: dev/archery/archery/integration/datagen.py
##
@@ -1401,6 +1437,18 @@ def generate_nested_dictionary_case():
bkietz commented on a change in pull request #6959:
URL: https://github.com/apache/arrow/pull/6959#discussion_r412194818
##
File path: dev/archery/archery/integration/datagen.py
##
@@ -1401,6 +1437,18 @@ def generate_nested_dictionary_case():
jorisvandenbossche commented on a change in pull request #7000:
URL: https://github.com/apache/arrow/pull/7000#discussion_r412150862
##
File path: cpp/src/arrow/dataset/dataset.h
##
@@ -30,12 +30,22 @@
namespace arrow {
namespace dataset {
-/// \brief A granular piece of a
gramirezespinoza commented on issue #6977:
URL: https://github.com/apache/arrow/issues/6977#issuecomment-617178347
Waiting for #6970 to be approved/merged
This is an automated message from the Apache Git Service.
To respond
wesm commented on issue #6988:
URL: https://github.com/apache/arrow/pull/6988#issuecomment-617164152
The copy-pasta in the .yml files is a bummer. I hope one day for a higher
level specification of these tasks
This is an
github-actions[bot] commented on issue #6999:
URL: https://github.com/apache/arrow/pull/6999#issuecomment-617150142
https://issues.apache.org/jira/browse/ARROW-8542
This is an automated message from the Apache Git Service.
kszucs opened a new pull request #6999:
URL: https://github.com/apache/arrow/pull/6999
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
pitrou commented on issue #6981:
URL: https://github.com/apache/arrow/pull/6981#issuecomment-617126711
Perhaps. If the reader is compatible with those files, and roundtripping
works, then the writer is probably compliant as well.
pprudhvi commented on issue #6990:
URL: https://github.com/apache/arrow/pull/6990#issuecomment-617111538
lets wait till https://github.com/Homebrew/homebrew-core/pull/53445/files is
merged. see https://issues.apache.org/jira/browse/ARROW-8539
pitrou opened a new pull request #6997:
URL: https://github.com/apache/arrow/pull/6997
Example output:
```
---
Benchmark
liyafan82 commented on a change in pull request #6323:
URL: https://github.com/apache/arrow/pull/6323#discussion_r412070422
##
File path:
java/vector/src/test/java/org/apache/arrow/vector/TestLargeVector.java
##
@@ -0,0 +1,187 @@
+/*
+ * Licensed to the Apache Software
liyafan82 commented on a change in pull request #6323:
URL: https://github.com/apache/arrow/pull/6323#discussion_r412070083
##
File path:
java/vector/src/test/java/org/apache/arrow/vector/TestLargeVector.java
##
@@ -0,0 +1,187 @@
+/*
+ * Licensed to the Apache Software
liyafan82 commented on a change in pull request #6323:
URL: https://github.com/apache/arrow/pull/6323#discussion_r412067781
##
File path:
java/memory/src/main/java/org/apache/arrow/memory/NettyAllocationManager.java
##
@@ -34,31 +33,24 @@
static final
kiszk commented on issue #6981:
URL: https://github.com/apache/arrow/pull/6981#issuecomment-617087421
I think that the current test cases for parquet writer do not have tests to
verify the bit pattern of the generated parquet file. I will also create the
test case in another PR since they
pitrou commented on issue #6996:
URL: https://github.com/apache/arrow/pull/6996#issuecomment-617067706
Wow, that is compiling OpenSSL by hand?
This is an automated message from the Apache Git Service.
To respond to the
pitrou commented on a change in pull request #6991:
URL: https://github.com/apache/arrow/pull/6991#discussion_r412025224
##
File path: cpp/src/arrow/util/rle_encoding.h
##
@@ -414,6 +414,8 @@ static inline bool IndexInRange(int32_t idx, int32_t
dictionary_length) {
template
pitrou commented on issue #6996:
URL: https://github.com/apache/arrow/pull/6996#issuecomment-617061541
"The job exceeded the maximum log length, and has been terminated." --
restarting
This is an automated message from the
pitrou commented on issue #6986:
URL: https://github.com/apache/arrow/pull/6986#issuecomment-617033346
To be honest, `BitmapAnd` should probably be rewritten using
`Bitmap::VisitWords`.
But we can revert anyway if we fear regressions may appear in other
workloads.
cyb70289 commented on issue #6986:
URL: https://github.com/apache/arrow/pull/6986#issuecomment-616978252
This change introduces severe branch misses in certain conditions. See perf
logs below. I changed benchmark code to run only the problematic test case.
Without this patch
67 matches
Mail list logo
