zgramana edited a comment on pull request #6121:
URL: https://github.com/apache/arrow/pull/6121#issuecomment-618756547
@eerhardt I'd like to chime in to say that I have just come across this
conversation late--and *after* implementing an alternative approach which much
more in-line with
sunchao edited a comment on pull request #6949:
URL: https://github.com/apache/arrow/pull/6949#issuecomment-618740530
Yes I think it is beneficial to avoid dropping buffers with `seek`, although
it will be nice if the `seek_relative` will be stabilized soon so we can just
use that.
sunchao commented on pull request #6949:
URL: https://github.com/apache/arrow/pull/6949#issuecomment-618740530
Yes I think it is beneficial to avoid dropping buffers with `seek`, although
it will be nice if the `seek_relative` will be stabilized soon so we can just
use that.
>
zgramana edited a comment on pull request #6121:
URL: https://github.com/apache/arrow/pull/6121#issuecomment-618756547
@eerhardt I'd like to chime in to say that I have just come across this
conversation late--and *after* implementing an alternative approach which much
more in-line with
zgramana commented on pull request #6121:
URL: https://github.com/apache/arrow/pull/6121#issuecomment-618756547
@eerhardt I'd like to chime in that I have just come across this
conversation after implementing an alternative approach much more in line with
other Arrow language
cyb70289 commented on pull request #6954:
URL: https://github.com/apache/arrow/pull/6954#issuecomment-618782973
> Is the function `Armv8CrcHashParallel` used somewhere? Sorry if I overlook
it.
It's not used. Actually the whole file hash_util.h is not used per [this
github-actions[bot] commented on pull request #7028:
URL: https://github.com/apache/arrow/pull/7028#issuecomment-618731413
https://issues.apache.org/jira/browse/ARROW-8575
This is an automated message from the Apache Git
paddyhoran commented on a change in pull request #6306:
URL: https://github.com/apache/arrow/pull/6306#discussion_r414234200
##
File path: rust/arrow/src/compute/kernels/sort.rs
##
@@ -0,0 +1,671 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more
nealrichardson opened a new pull request #7028:
URL: https://github.com/apache/arrow/pull/7028
Instead of adding a PR comment of "This needs rebase" and wait for the
author to get around to it, with this workflow you can just type "rebase" and
GHA will do it for you. If it rebases
zgramana edited a comment on pull request #6121:
URL: https://github.com/apache/arrow/pull/6121#issuecomment-618756547
@eerhardt I'd like to chime in to say that I have just come across this
conversation late--and *after* implementing an alternative approach which much
more in-line with
mcassels commented on a change in pull request #6770:
URL: https://github.com/apache/arrow/pull/6770#discussion_r414276380
##
File path: rust/datafusion/src/utils.rs
##
@@ -120,6 +143,7 @@ pub fn array_value_to_string(column: array::ArrayRef, row:
usize) -> Result {
mcassels commented on a change in pull request #6770:
URL: https://github.com/apache/arrow/pull/6770#discussion_r414276861
##
File path: rust/datafusion/src/logicalplan.rs
##
@@ -828,8 +828,8 @@ mod tests {
.build()?;
let expected = "Projection: #id\
-
paddyhoran commented on a change in pull request #7004:
URL: https://github.com/apache/arrow/pull/7004#discussion_r414240892
##
File path: rust/arrow/src/array/equal.rs
##
@@ -1046,6 +1062,30 @@ impl PartialEq for Value {
}
}
+impl JsonEqual for UnionArray {
+fn
paddyhoran commented on pull request #7004:
URL: https://github.com/apache/arrow/pull/7004#issuecomment-618761556
@andygrove just going to leave a general comment as it's all related.
Overall, I felt this PR was getting big, I was trying to avoid getting into
the IPC stuff in this
paddyhoran commented on a change in pull request #6980:
URL: https://github.com/apache/arrow/pull/6980#discussion_r414230710
##
File path: rust/arrow/src/array/builder.rs
##
@@ -236,6 +251,14 @@ impl BufferBuilderTrait for
BufferBuilder {
paddyhoran commented on pull request #7024:
URL: https://github.com/apache/arrow/pull/7024#issuecomment-618749586
CI is failing again, I thought this was fixed by #8558
This is an automated message from the Apache Git
paddyhoran commented on a change in pull request #7004:
URL: https://github.com/apache/arrow/pull/7004#discussion_r414241189
##
File path: rust/arrow/src/array/mod.rs
##
@@ -85,6 +85,7 @@ mod array;
mod builder;
mod data;
mod equal;
+mod union;
Review comment:
Yea,
pitrou commented on a change in pull request #6985:
URL: https://github.com/apache/arrow/pull/6985#discussion_r413696312
##
File path: cpp/cmake_modules/SetupCxxFlags.cmake
##
@@ -40,12 +40,13 @@ if(ARROW_CPU_FLAG STREQUAL "x86")
set(CXX_SUPPORTS_SSE4_2 TRUE)
else()
nevi-me opened a new pull request #7018:
URL: https://github.com/apache/arrow/pull/7018
When a user compiles the `flight` crate, a `build.rs` script is invoked.
This script recursively looks for the `format/Flight.proto` path. A user might
not have that path, as they would not have cloned
pitrou commented on a change in pull request #6959:
URL: https://github.com/apache/arrow/pull/6959#discussion_r413762177
##
File path: python/pyarrow/tests/test_extension_type.py
##
@@ -445,22 +445,28 @@ def test_parquet(tmpdir, registered_period_type):
import base64
pitrou commented on issue #6954:
URL: https://github.com/apache/arrow/pull/6954#issuecomment-618329962
cc @emkornfield
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
pitrou commented on a change in pull request #6744:
URL: https://github.com/apache/arrow/pull/6744#discussion_r413715323
##
File path: cpp/src/arrow/filesystem/s3fs_benchmark.cc
##
@@ -331,10 +358,64 @@ BENCHMARK_DEFINE_F(MinioFixture,
ReadCoalesced500Mib)(benchmark::State&
lidavidm commented on a change in pull request #6744:
URL: https://github.com/apache/arrow/pull/6744#discussion_r413744080
##
File path: cpp/src/parquet/file_reader.cc
##
@@ -212,6 +237,21 @@ class SerializedFile : public ParquetFileReader::Contents {
file_metadata_ =
lidavidm commented on a change in pull request #6744:
URL: https://github.com/apache/arrow/pull/6744#discussion_r413757274
##
File path: cpp/src/parquet/file_reader.cc
##
@@ -212,6 +237,21 @@ class SerializedFile : public ParquetFileReader::Contents {
file_metadata_ =
jorisvandenbossche commented on a change in pull request #6959:
URL: https://github.com/apache/arrow/pull/6959#discussion_r413750283
##
File path: python/pyarrow/tests/test_extension_type.py
##
@@ -445,22 +445,28 @@ def test_parquet(tmpdir, registered_period_type):
import
pitrou commented on a change in pull request #6744:
URL: https://github.com/apache/arrow/pull/6744#discussion_r413760028
##
File path: cpp/src/parquet/file_reader.cc
##
@@ -212,6 +237,21 @@ class SerializedFile : public ParquetFileReader::Contents {
file_metadata_ =
pitrou commented on a change in pull request #6744:
URL: https://github.com/apache/arrow/pull/6744#discussion_r413760214
##
File path: cpp/src/parquet/file_reader.cc
##
@@ -536,6 +577,14 @@ std::shared_ptr
ParquetFileReader::RowGroup(int i) {
return
github-actions[bot] commented on issue #7018:
URL: https://github.com/apache/arrow/pull/7018#issuecomment-618349230
https://issues.apache.org/jira/browse/ARROW-8536
This is an automated message from the Apache Git Service.
lidavidm commented on a change in pull request #6744:
URL: https://github.com/apache/arrow/pull/6744#discussion_r413763701
##
File path: cpp/src/parquet/file_reader.cc
##
@@ -212,6 +237,21 @@ class SerializedFile : public ParquetFileReader::Contents {
file_metadata_ =
emkornfield commented on issue #6985:
URL: https://github.com/apache/arrow/pull/6985#issuecomment-618231752
CC @wesm @pitrou I think this is ready for review now.
This is an automated message from the Apache Git Service.
To
kszucs commented on issue #6998:
URL: https://github.com/apache/arrow/pull/6998#issuecomment-618328429
@kou updated
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
jorisvandenbossche commented on a change in pull request #7000:
URL: https://github.com/apache/arrow/pull/7000#discussion_r413622598
##
File path: cpp/src/arrow/dataset/file_parquet.cc
##
@@ -402,23 +401,21 @@ Result ParquetFileFormat::ScanFile(
}
Result>
wesm commented on issue #7017:
URL: https://github.com/apache/arrow/issues/7017#issuecomment-618352283
Can you send an email to one of the mailing lists or open a JIRA if you want
to propose a development project?
This is
pitrou commented on a change in pull request #6744:
URL: https://github.com/apache/arrow/pull/6744#discussion_r413747770
##
File path: cpp/src/parquet/file_reader.cc
##
@@ -212,6 +237,21 @@ class SerializedFile : public ParquetFileReader::Contents {
file_metadata_ =
lidavidm commented on a change in pull request #6744:
URL: https://github.com/apache/arrow/pull/6744#discussion_r413759177
##
File path: cpp/src/parquet/file_reader.cc
##
@@ -212,6 +237,21 @@ class SerializedFile : public ParquetFileReader::Contents {
file_metadata_ =
jorisvandenbossche commented on issue #6992:
URL: https://github.com/apache/arrow/pull/6992#issuecomment-618366876
cc @wesm @xhochy @BryanCutler are you fine with
1) a hard required minimal pandas version? (meaning: we don't use the pandas
integration if an older version is
emkornfield commented on a change in pull request #6985:
URL: https://github.com/apache/arrow/pull/6985#discussion_r413533870
##
File path: cpp/src/parquet/column_reader.cc
##
@@ -50,6 +51,141 @@ using arrow::internal::checked_cast;
namespace parquet {
+namespace {
+
emkornfield commented on a change in pull request #6985:
URL: https://github.com/apache/arrow/pull/6985#discussion_r413576031
##
File path: cpp/src/parquet/column_reader.cc
##
@@ -50,6 +51,140 @@ using arrow::internal::checked_cast;
namespace parquet {
+namespace {
+
emkornfield commented on a change in pull request #6985:
URL: https://github.com/apache/arrow/pull/6985#discussion_r413576031
##
File path: cpp/src/parquet/column_reader.cc
##
@@ -50,6 +51,140 @@ using arrow::internal::checked_cast;
namespace parquet {
+namespace {
+
rok commented on issue #6667:
URL: https://github.com/apache/arrow/pull/6667#issuecomment-618295149
Thanks @mrkn! :)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
emkornfield edited a comment on issue #6985:
URL: https://github.com/apache/arrow/pull/6985#issuecomment-618231752
CC @wesm @pitrou I think this is ready for review now. Will take a closer
look at CI failures tomorrow.
This
emkornfield commented on a change in pull request #6985:
URL: https://github.com/apache/arrow/pull/6985#discussion_r413575153
##
File path: cpp/cmake_modules/SetupCxxFlags.cmake
##
@@ -40,12 +40,13 @@ if(ARROW_CPU_FLAG STREQUAL "x86")
set(CXX_SUPPORTS_SSE4_2 TRUE)
nevi-me commented on issue #6972:
URL: https://github.com/apache/arrow/pull/6972#issuecomment-618293330
> I also think it is fine for the moment to ignore the use case where the
schema varies between record batches and file a separate issue for that.
Just on this point, there
emkornfield commented on a change in pull request #6985:
URL: https://github.com/apache/arrow/pull/6985#discussion_r413576741
##
File path: cpp/src/parquet/column_reader.cc
##
@@ -50,6 +51,140 @@ using arrow::internal::checked_cast;
namespace parquet {
+namespace {
+
rdettai commented on issue #6949:
URL: https://github.com/apache/arrow/pull/6949#issuecomment-618235600
I'll work on your comments today.
What about the problem we are trying to fix here? Do you agree with the
benefits of this fix ?
Also, I'm not sure why a `Mutex` was used
rdettai edited a comment on issue #6949:
URL: https://github.com/apache/arrow/pull/6949#issuecomment-618235600
I'll work on your comments today.
What about the problem we are trying to fix here? Do you agree with the
benefits of this fix ?
Also, I'm not sure why a `Mutex` was
wesm commented on issue #6992:
URL: https://github.com/apache/arrow/pull/6992#issuecomment-618459883
I'm OK with this. The maintenance burden of supporting several years' worth
of pandas releases seems like a lot to bear. If there are parties which are
affected by this they should
pitrou commented on issue #6846:
URL: https://github.com/apache/arrow/pull/6846#issuecomment-618464806
The CI failure looks unrelated, will merge.
This is an automated message from the Apache Git Service.
To respond to the
mayuropensource opened a new pull request #7020:
URL: https://github.com/apache/arrow/pull/7020
JIRA: https://issues.apache.org/jira/browse/ARROW-8562
This change is not actually used until
https://github.com/apache/arrow/pull/6744 (@lidavidm) is pushed, however, it
doesn't need to
kszucs opened a new pull request #7021:
URL: https://github.com/apache/arrow/pull/7021
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
vertexclique commented on a change in pull request #6980:
URL: https://github.com/apache/arrow/pull/6980#discussion_r413951534
##
File path: rust/arrow/src/array/builder.rs
##
@@ -236,6 +251,14 @@ impl BufferBuilderTrait for
BufferBuilder {
vertexclique commented on a change in pull request #6980:
URL: https://github.com/apache/arrow/pull/6980#discussion_r413951534
##
File path: rust/arrow/src/array/builder.rs
##
@@ -236,6 +251,14 @@ impl BufferBuilderTrait for
BufferBuilder {
vertexclique commented on a change in pull request #6980:
URL: https://github.com/apache/arrow/pull/6980#discussion_r413951534
##
File path: rust/arrow/src/array/builder.rs
##
@@ -236,6 +251,14 @@ impl BufferBuilderTrait for
BufferBuilder {
markhildreth commented on a change in pull request #6972:
URL: https://github.com/apache/arrow/pull/6972#discussion_r413951619
##
File path: rust/parquet/src/encodings/rle.rs
##
@@ -830,7 +826,7 @@ mod tests {
values.clear();
let mut rng =
kiszk commented on a change in pull request #6985:
URL: https://github.com/apache/arrow/pull/6985#discussion_r413970301
##
File path: cpp/src/parquet/level_conversion.h
##
@@ -0,0 +1,191 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor
github-actions[bot] commented on issue #7019:
URL: https://github.com/apache/arrow/pull/7019#issuecomment-618528458
Revision: 5bcfeab4c9bacc0b3a262a7522bfaf985025d3ec
Submitted crossbow builds: [ursa-labs/crossbow @
paddyhoran commented on a change in pull request #6980:
URL: https://github.com/apache/arrow/pull/6980#discussion_r413903768
##
File path: rust/arrow/src/array/builder.rs
##
@@ -236,6 +251,14 @@ impl BufferBuilderTrait for
BufferBuilder {
kiszk commented on a change in pull request #6985:
URL: https://github.com/apache/arrow/pull/6985#discussion_r413908372
##
File path: cpp/src/parquet/column_reader.cc
##
@@ -50,6 +51,140 @@ using arrow::internal::checked_cast;
namespace parquet {
+namespace {
+
+inline
lidavidm commented on a change in pull request #7020:
URL: https://github.com/apache/arrow/pull/7020#discussion_r413923773
##
File path: cpp/src/arrow/io/caching.h
##
@@ -27,6 +27,44 @@
namespace arrow {
namespace io {
+
+struct ARROW_EXPORT CacheOptions {
+ static
mayuropensource opened a new pull request #7022:
URL: https://github.com/apache/arrow/pull/7022
_(Recreating the PR from a clean repo, sorry about earlier PR which was not
cleanly merged)._
**JIRA:** https://issues.apache.org/jira/browse/ARROW-8562
This change is not actually
markhildreth commented on issue #6972:
URL: https://github.com/apache/arrow/pull/6972#issuecomment-618501806
@andygrove Thanks for the feedback. I have updated the PR with a less leaky
API. I also fixed the type inference problem that was caused by the new
dependency.
@nevi-me True
markhildreth edited a comment on issue #6972:
URL: https://github.com/apache/arrow/pull/6972#issuecomment-618501806
@andygrove Thanks for the feedback. I have updated the PR with a less leaky
API. I also fixed the type inference problem that was caused by the new
dependency.
markhildreth edited a comment on issue #6972:
URL: https://github.com/apache/arrow/pull/6972#issuecomment-618501806
@andygrove Thanks for the feedback. I have updated the PR with a less leaky
API. I also tweaked the parquet test to workaround the new type inference
changes.
markhildreth commented on a change in pull request #6972:
URL: https://github.com/apache/arrow/pull/6972#discussion_r413951619
##
File path: rust/parquet/src/encodings/rle.rs
##
@@ -830,7 +826,7 @@ mod tests {
values.clear();
let mut rng =
kiszk commented on a change in pull request #6985:
URL: https://github.com/apache/arrow/pull/6985#discussion_r413954827
##
File path: cpp/src/parquet/level_conversion_test.cc
##
@@ -0,0 +1,162 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more
wesm commented on issue #7020:
URL: https://github.com/apache/arrow/pull/7020#issuecomment-618508772
@mayuropensource it's not necessary to open a new PR when you want to redo
your commits, you can just force push your branch
kiszk commented on a change in pull request #6985:
URL: https://github.com/apache/arrow/pull/6985#discussion_r413953833
##
File path: cpp/src/parquet/column_reader.cc
##
@@ -50,6 +51,140 @@ using arrow::internal::checked_cast;
namespace parquet {
+namespace {
+
+inline
kiszk commented on a change in pull request #6985:
URL: https://github.com/apache/arrow/pull/6985#discussion_r413960907
##
File path: cpp/src/parquet/level_conversion.h
##
@@ -0,0 +1,191 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor
markhildreth commented on a change in pull request #7006:
URL: https://github.com/apache/arrow/pull/7006#discussion_r413958397
##
File path: rust/arrow/src/array/array.rs
##
@@ -2592,6 +2619,15 @@ mod tests {
assert_eq!(DataType::Int32, list_array.value_type());
nealrichardson commented on issue #7019:
URL: https://github.com/apache/arrow/pull/7019#issuecomment-618527651
@github-actions crossbow submit homebrew-cpp
This is an automated message from the Apache Git Service.
To respond
github-actions[bot] commented on issue #7021:
URL: https://github.com/apache/arrow/pull/7021#issuecomment-618494095
Thanks for opening a pull request!
Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW
Then could you
kiszk commented on a change in pull request #6985:
URL: https://github.com/apache/arrow/pull/6985#discussion_r413954827
##
File path: cpp/src/parquet/level_conversion_test.cc
##
@@ -0,0 +1,162 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more
markhildreth commented on a change in pull request #7006:
URL: https://github.com/apache/arrow/pull/7006#discussion_r413958397
##
File path: rust/arrow/src/array/array.rs
##
@@ -2592,6 +2619,15 @@ mod tests {
assert_eq!(DataType::Int32, list_array.value_type());
vertexclique commented on a change in pull request #6980:
URL: https://github.com/apache/arrow/pull/6980#discussion_r413972358
##
File path: rust/arrow/src/array/builder.rs
##
@@ -236,6 +251,14 @@ impl BufferBuilderTrait for
BufferBuilder {
github-actions[bot] commented on issue #7020:
URL: https://github.com/apache/arrow/pull/7020#issuecomment-618472360
Thanks for opening a pull request!
Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW
Then could you
kiszk commented on a change in pull request #6985:
URL: https://github.com/apache/arrow/pull/6985#discussion_r413905959
##
File path: cpp/src/parquet/column_reader.cc
##
@@ -50,6 +51,140 @@ using arrow::internal::checked_cast;
namespace parquet {
+namespace {
+
+inline
mayuropensource commented on issue #7020:
URL: https://github.com/apache/arrow/pull/7020#issuecomment-618486378
I messed up some commits. Will create a new one.
This is an automated message from the Apache Git Service.
To
markhildreth commented on issue #6972:
URL: https://github.com/apache/arrow/pull/6972#issuecomment-618506903
From a purely practical standpoint, this PR is ready for further review and
merging. If approved, I would probably add some minor issue for the following:
* Trying to avoid the
bryantbiggs commented on issue #4140:
URL: https://github.com/apache/arrow/pull/4140#issuecomment-618512883
thanks @andygrove !
This is an automated message from the Apache Git Service.
To respond to the message, please log
BryanCutler commented on issue #6992:
URL: https://github.com/apache/arrow/pull/6992#issuecomment-618517973
Sounds good to me. FWIW, Spark also has a minimum Pandas version set at
0.23.2.
This is an automated message from
tustvold commented on a change in pull request #6980:
URL: https://github.com/apache/arrow/pull/6980#discussion_r413969298
##
File path: rust/arrow/src/array/builder.rs
##
@@ -236,6 +251,14 @@ impl BufferBuilderTrait for
BufferBuilder {
markhildreth commented on a change in pull request #7006:
URL: https://github.com/apache/arrow/pull/7006#discussion_r413958397
##
File path: rust/arrow/src/array/array.rs
##
@@ -2592,6 +2619,15 @@ mod tests {
assert_eq!(DataType::Int32, list_array.value_type());
markhildreth commented on a change in pull request #7006:
URL: https://github.com/apache/arrow/pull/7006#discussion_r413958397
##
File path: rust/arrow/src/array/array.rs
##
@@ -2592,6 +2619,15 @@ mod tests {
assert_eq!(DataType::Int32, list_array.value_type());
xhochy opened a new pull request #7023:
URL: https://github.com/apache/arrow/pull/7023
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
pitrou commented on a change in pull request #6744:
URL: https://github.com/apache/arrow/pull/6744#discussion_r41381
##
File path: cpp/src/parquet/file_reader.cc
##
@@ -212,6 +237,21 @@ class SerializedFile : public ParquetFileReader::Contents {
file_metadata_ =
pitrou commented on a change in pull request #6744:
URL: https://github.com/apache/arrow/pull/6744#discussion_r413800208
##
File path: cpp/src/parquet/file_reader.cc
##
@@ -212,6 +237,21 @@ class SerializedFile : public ParquetFileReader::Contents {
file_metadata_ =
fsaintjacques commented on a change in pull request #6979:
URL: https://github.com/apache/arrow/pull/6979#discussion_r413814578
##
File path: python/pyarrow/_parquet.pyx
##
@@ -1083,6 +1084,50 @@ cdef class ParquetReader:
def set_use_threads(self, bint use_threads):
lidavidm commented on a change in pull request #6744:
URL: https://github.com/apache/arrow/pull/6744#discussion_r413797661
##
File path: cpp/src/parquet/file_reader.cc
##
@@ -536,6 +577,14 @@ std::shared_ptr
ParquetFileReader::RowGroup(int i) {
return
lidavidm commented on a change in pull request #6744:
URL: https://github.com/apache/arrow/pull/6744#discussion_r413798078
##
File path: cpp/src/arrow/filesystem/s3fs_benchmark.cc
##
@@ -331,10 +358,64 @@ BENCHMARK_DEFINE_F(MinioFixture,
ReadCoalesced500Mib)(benchmark::State&
pitrou commented on a change in pull request #6744:
URL: https://github.com/apache/arrow/pull/6744#discussion_r413810237
##
File path: cpp/src/parquet/file_reader.cc
##
@@ -536,6 +577,14 @@ std::shared_ptr
ParquetFileReader::RowGroup(int i) {
return
fsaintjacques commented on a change in pull request #6979:
URL: https://github.com/apache/arrow/pull/6979#discussion_r413811549
##
File path: cpp/src/parquet/arrow/reader.cc
##
@@ -260,12 +260,28 @@ class FileReaderImpl : public FileReader {
Status
fsaintjacques commented on a change in pull request #6979:
URL: https://github.com/apache/arrow/pull/6979#discussion_r413812220
##
File path: python/pyarrow/_parquet.pxd
##
@@ -334,7 +334,7 @@ cdef extern from "parquet/api/reader.h" namespace "parquet"
nogil:
andygrove commented on a change in pull request #7009:
URL: https://github.com/apache/arrow/pull/7009#discussion_r413857080
##
File path: rust/parquet/src/record/api.rs
##
@@ -50,6 +50,33 @@ impl Row {
pub fn len() -> usize {
self.fields.len()
}
+
+pub
github-actions[bot] commented on issue #7019:
URL: https://github.com/apache/arrow/pull/7019#issuecomment-618456824
https://issues.apache.org/jira/browse/ARROW-8569
This is an automated message from the Apache Git Service.
lidavidm commented on a change in pull request #6744:
URL: https://github.com/apache/arrow/pull/6744#discussion_r413792469
##
File path: cpp/src/parquet/file_reader.cc
##
@@ -212,6 +237,21 @@ class SerializedFile : public ParquetFileReader::Contents {
file_metadata_ =
nealrichardson opened a new pull request #7019:
URL: https://github.com/apache/arrow/pull/7019
See https://github.com/apache/arrow/pull/6996#issuecomment-618053499
This is an automated message from the Apache Git Service.
To
pitrou commented on issue #6846:
URL: https://github.com/apache/arrow/pull/6846#issuecomment-618404946
I rebased and improved the tests slightly. Also opened some issues for some
oddities.
This is an automated message from
pitrou commented on a change in pull request #6744:
URL: https://github.com/apache/arrow/pull/6744#discussion_r413783259
##
File path: cpp/src/parquet/file_reader.cc
##
@@ -212,6 +237,21 @@ class SerializedFile : public ParquetFileReader::Contents {
file_metadata_ =
tustvold commented on issue #6980:
URL: https://github.com/apache/arrow/pull/6980#issuecomment-618389453
Rebased on current master and the CI now builds :tada:
This is an automated message from the Apache Git Service.
To
lidavidm commented on a change in pull request #6744:
URL: https://github.com/apache/arrow/pull/6744#discussion_r413819271
##
File path: cpp/src/parquet/file_reader.cc
##
@@ -212,6 +237,21 @@ class SerializedFile : public ParquetFileReader::Contents {
file_metadata_ =
1 - 100 of 129 matches
Mail list logo