[GitHub] [arrow] liyafan82 commented on a change in pull request #7347: ARROW-8230: [Java] Remove netty dependency from arrow-memory

liyafan82 commented on a change in pull request #7347: URL: https://github.com/apache/arrow/pull/7347#discussion_r437116925 ## File path: java/memory/src/main/java/io/netty/buffer/NettyArrowBuf.java ## @@ -404,7 +407,7 @@ protected int _getUnsignedMediumLE(int index) {

[GitHub] [arrow] kou opened a new pull request #7381: ARROW-9074: [GLib] Add missing arrow-json check

kou opened a new pull request #7381: URL: https://github.com/apache/arrow/pull/7381 It's required. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [arrow] jedbrown commented on a change in pull request #7314: ARROW-8996: [C++] SSE runtime support for aggregate sum dense kernel

jedbrown commented on a change in pull request #7314: URL: https://github.com/apache/arrow/pull/7314#discussion_r437479652 ## File path: cpp/src/arrow/compute/kernels/aggregate_basic_sse.cc ## @@ -0,0 +1,355 @@ +// Licensed to the Apache Software Foundation (ASF) under one +//

[GitHub] [arrow] kszucs commented on pull request #6512: ARROW-8430: [CI] Configure self-hosted runners for Github Actions [WIP][skip ci]

kszucs commented on pull request #6512: URL: https://github.com/apache/arrow/pull/6512#issuecomment-640917421 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [arrow] jianxind opened a new pull request #7383: ARROW-9077: [C++] Fix aggregate/scalar-compare benchmark null_percent calculation

jianxind opened a new pull request #7383: URL: https://github.com/apache/arrow/pull/7383 Correct both to use the new defined boilerplate. Signed-off-by: Frank Du This is an automated message from the Apache Git

[GitHub] [arrow] andygrove closed pull request #7306: ARROW-3688: [Rust] Add append_values for primitive builders

andygrove closed pull request #7306: URL: https://github.com/apache/arrow/pull/7306 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow] vertexclique commented on a change in pull request #7379: ARROW-9062 [RUST] json reader dictionary support

vertexclique commented on a change in pull request #7379: URL: https://github.com/apache/arrow/pull/7379#discussion_r437210110 ## File path: rust/arrow/src/json/reader.rs ## @@ -448,42 +453,55 @@ impl Reader { let mut builder =

[GitHub] [arrow] svenwb opened a new pull request #7379: ARROW-9062 [RUST] json reader dictionary support

svenwb opened a new pull request #7379: URL: https://github.com/apache/arrow/pull/7379 Changes in this PR allow the JSON Reader to read into Arrow arrays of type dictionary. This is an automated message from the Apache Git

[GitHub] [arrow] pitrou commented on pull request #7356: ARROW-9034: [C++] Implement "BinaryBitBlockCounter", add single-word functions to BitBlockCounter

pitrou commented on pull request #7356: URL: https://github.com/apache/arrow/pull/7356#issuecomment-640664623 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [arrow] bkietz opened a new pull request #7378: ARROW-8866: [C++] Split UNION into SPARSE_UNION and DENSE_UNION

bkietz opened a new pull request #7378: URL: https://github.com/apache/arrow/pull/7378 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [arrow] bkietz closed pull request #7341: ARROW-9042: [C++] Add Subtract and Multiply arithmetic kernels with wrap-around behavior

bkietz closed pull request #7341: URL: https://github.com/apache/arrow/pull/7341 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow] wesm closed pull request #7356: ARROW-9034: [C++] Implement "BinaryBitBlockCounter", add single-word functions to BitBlockCounter

wesm closed pull request #7356: URL: https://github.com/apache/arrow/pull/7356 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [arrow] jorisvandenbossche commented on pull request #7350: ARROW-6602: [Doc] Add a feature/implementation matrix

jorisvandenbossche commented on pull request #7350: URL: https://github.com/apache/arrow/pull/7350#issuecomment-641175393 > > I would make this part of the top-level README, minimally via a link. > > Well, we cannot make a link until the stable docs are uploaded unfortunately :-/

[GitHub] [arrow] xhochy commented on a change in pull request #7308: ARROW-6978: [R] Add bindings for sum and mean compute kernels

xhochy commented on a change in pull request #7308: URL: https://github.com/apache/arrow/pull/7308#discussion_r436745441 ## File path: r/DESCRIPTION ## @@ -60,6 +60,7 @@ Collate: 'chunked-array.R' 'io.R' 'compression.R' +'scalar.R' Review comment: Is

[GitHub] [arrow] kszucs commented on pull request #7376: ARROW-9043: [Go][FOLLOWUP] Move license file copy to correct location

kszucs commented on pull request #7376: URL: https://github.com/apache/arrow/pull/7376#issuecomment-640607901 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [arrow] pitrou commented on a change in pull request #7349: ARROW-8766: [Python] Allow implementing filesystems in Python

pitrou commented on a change in pull request #7349: URL: https://github.com/apache/arrow/pull/7349#discussion_r437451340 ## File path: cpp/src/arrow/python/filesystem.h ## @@ -0,0 +1,115 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

[GitHub] [arrow] wesm closed pull request #7181: ARROW-8799: [C++][Parquet] NestedListReader needs to handle empty item batches

wesm closed pull request #7181: URL: https://github.com/apache/arrow/pull/7181 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [arrow] wesm commented on a change in pull request #7382: ARROW-5760: [C++] New compute::Take implementation for better performance, faster dispatch, smaller code size / faster compilation

wesm commented on a change in pull request #7382: URL: https://github.com/apache/arrow/pull/7382#discussion_r43712 ## File path: cpp/src/arrow/compute/kernels/vector_take.cc ## @@ -38,46 +52,758 @@ std::unique_ptr InitTake(KernelContext*, const KernelInitArgs& args

[GitHub] [arrow] github-actions[bot] commented on pull request #7384: ARROW-9082: [Rust] - Stream reader fail when steam not ended with (opt…

github-actions[bot] commented on pull request #7384: URL: https://github.com/apache/arrow/pull/7384#issuecomment-641383006 https://issues.apache.org/jira/browse/ARROW-9082 This is an automated message from the Apache Git

[GitHub] [arrow] mcassels commented on a change in pull request #6770: ARROW-7842: [Rust] [Parquet] implement array_reader for list type columns

mcassels commented on a change in pull request #6770: URL: https://github.com/apache/arrow/pull/6770#discussion_r437067752 ## File path: rust/arrow/src/ipc/convert.rs ## @@ -518,11 +518,12 @@ pub(crate) fn get_fb_field_type<'a: 'b, 'b>( ) }

[GitHub] [arrow] kszucs edited a comment on pull request #7374: ARROW-9064: [APT] Use --no-install-recommends

kszucs edited a comment on pull request #7374: URL: https://github.com/apache/arrow/pull/7374#issuecomment-641256271 > I want to object this mass change because of the same reason as [#6590 (comment)](https://github.com/apache/arrow/pull/6590#issuecomment-607668777) . > > There are

[GitHub] [arrow] pitrou commented on pull request #7314: ARROW-8996: [C++] SSE runtime support for aggregate sum dense kernel

pitrou commented on pull request #7314: URL: https://github.com/apache/arrow/pull/7314#issuecomment-641136788 > Just find a document(https://dl.acm.org/doi/pdf/10.1145/3178433.3178435 PAGE 7, Table 6: Comparison of various SIMD wrappers.) Some SIMD helper(simdpp/xsimd) has performance

[GitHub] [arrow] nealrichardson commented on a change in pull request #7281: ARROW-9046: [C++][R] Put more things in type_fwds

nealrichardson commented on a change in pull request #7281: URL: https://github.com/apache/arrow/pull/7281#discussion_r437017534 ## File path: python/pyarrow/includes/libarrow.pxd ## @@ -1186,10 +1186,10 @@ cdef extern from "arrow/io/api.h" namespace "arrow::io" nogil:

[GitHub] [arrow] wesm commented on pull request #7382: ARROW-5760: [C++] New compute::Take implementation for better performance, faster dispatch, smaller code size / faster compilation

wesm commented on pull request #7382: URL: https://github.com/apache/arrow/pull/7382#issuecomment-641027598 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [arrow] wesm opened a new pull request #7376: ARROW-9043: [Go][FOLLOWUP] Move license file again to correct location

wesm opened a new pull request #7376: URL: https://github.com/apache/arrow/pull/7376 See https://github.com/apache/arrow/pull/7355#issuecomment-640584322 This is an automated message from the Apache Git Service. To respond

[GitHub] [arrow] nealrichardson commented on a change in pull request #7308: ARROW-6978: [R] Add bindings for sum and mean compute kernels

nealrichardson commented on a change in pull request #7308: URL: https://github.com/apache/arrow/pull/7308#discussion_r436861446 ## File path: r/DESCRIPTION ## @@ -60,6 +60,7 @@ Collate: 'chunked-array.R' 'io.R' 'compression.R' +'scalar.R' Review comment:

[GitHub] [arrow] pitrou commented on a change in pull request #7378: ARROW-8866: [C++] Split UNION into SPARSE_UNION and DENSE_UNION

pitrou commented on a change in pull request #7378: URL: https://github.com/apache/arrow/pull/7378#discussion_r436932116 ## File path: cpp/src/arrow/c/bridge.cc ## @@ -1320,14 +1324,16 @@ struct ArrayImporter { Status Visit(const UnionType& type) { auto mode =

[GitHub] [arrow] pitrou commented on a change in pull request #7282: ARROW-8958: [FlightRPC][Python] implement DoExchange

pitrou commented on a change in pull request #7282: URL: https://github.com/apache/arrow/pull/7282#discussion_r436778188 ## File path: python/pyarrow/_flight.pyx ## @@ -844,8 +856,27 @@ cdef class FlightStreamReader(MetadataRecordBatchReader): (

[GitHub] [arrow] liyafan82 commented on a change in pull request #7326: ARROW-9010: [Java] Framework and interface changes for RecordBatch IPC buffer compression

liyafan82 commented on a change in pull request #7326: URL: https://github.com/apache/arrow/pull/7326#discussion_r436654884 ## File path: java/vector/src/main/java/org/apache/arrow/vector/compression/CompressionUtility.java ## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache

[GitHub] [arrow] kou commented on pull request #7368: ARROW-9058: [Packaging][wheel] Use sourceforge.net to download Boost

kou commented on pull request #7368: URL: https://github.com/apache/arrow/pull/7368#issuecomment-640889744 I don't know the reason. Sorry. `tools/bcp` was removed in Boost 1.71.0. It may be the reason. This is an

[GitHub] [arrow] pitrou commented on pull request #7363: ARROW-9051: [GLib] Refer Array related objects from Array

pitrou commented on pull request #7363: URL: https://github.com/apache/arrow/pull/7363#issuecomment-640644658 Don't you use a Buffer subclass that owns a GLib buffer? This is an automated message from the Apache Git Service.

[GitHub] [arrow] pitrou commented on pull request #7299: ARROW-8487: [FlightRPC] Provide a way to target a particular payload size

pitrou commented on pull request #7299: URL: https://github.com/apache/arrow/pull/7299#issuecomment-640771646 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [arrow] wesm commented on pull request #7356: ARROW-9034: [C++] Implement "BinaryBitBlockCounter", add single-word functions to BitBlockCounter

wesm commented on pull request #7356: URL: https://github.com/apache/arrow/pull/7356#issuecomment-640673030 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [arrow] pitrou commented on a change in pull request #7356: ARROW-9034: [C++] Implement "BinaryBitBlockCounter", add single-word functions to BitBlockCounter

pitrou commented on a change in pull request #7356: URL: https://github.com/apache/arrow/pull/7356#discussion_r436753353 ## File path: cpp/src/arrow/util/bit_block_counter.h ## @@ -19,37 +19,108 @@ #include +#include "arrow/util/bit_util.h" +#include

[GitHub] [arrow] github-actions[bot] commented on pull request #7376: ARROW-9043: [Go][FOLLOWUP] Move license file copy to correct location

github-actions[bot] commented on pull request #7376: URL: https://github.com/apache/arrow/pull/7376#issuecomment-640604967 https://issues.apache.org/jira/browse/ARROW-9043 This is an automated message from the Apache Git

[GitHub] [arrow] wesm opened a new pull request #7382: ARROW-5760: [C++] New compute::Take implementation for better performance, faster dispatch, smaller code size

wesm opened a new pull request #7382: URL: https://github.com/apache/arrow/pull/7382 I was going to work in Filter in this PR but it got to be too much to review so I'll tackle that in a separate PR. Summary of what's in this PR: * Uses BitBlockCounter to speed up processing

[GitHub] [arrow] kou closed pull request #7363: ARROW-9051: [GLib] Refer Array related objects from Array

kou closed pull request #7363: URL: https://github.com/apache/arrow/pull/7363 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [arrow] pitrou closed pull request #7282: ARROW-8958: [FlightRPC][Python] implement DoExchange

pitrou closed pull request #7282: URL: https://github.com/apache/arrow/pull/7282 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow] eyalleshem opened a new pull request #7384: ARROW-9082: [Rust] - Stream reader fail when steam not ended with (opt…

eyalleshem opened a new pull request #7384: URL: https://github.com/apache/arrow/pull/7384 …ional) 0x 0x This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [arrow] wesm commented on pull request #7376: ARROW-9043: [Go][FOLLOWUP] Move license file again to correct location

wesm commented on pull request #7376: URL: https://github.com/apache/arrow/pull/7376#issuecomment-640598148 @jba can you please confirm this is correct. In the future a PR would be welcome This is an automated message from

[GitHub] [arrow] wesm commented on pull request #7378: ARROW-8866: [C++] Split UNION into SPARSE_UNION and DENSE_UNION

wesm commented on pull request #7378: URL: https://github.com/apache/arrow/pull/7378#issuecomment-640849143 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [arrow] kou opened a new pull request #7380: ARROW-9073: [C++] Fix RapidJSON include directory detection with RapidJSONConfig.cmake

kou opened a new pull request #7380: URL: https://github.com/apache/arrow/pull/7380 RapidJSONConfig.cmake provides RAPIDJSON_INCLUDE_DIRS (including the last "S") not RAPIDJSON_INCLUDE_DIR. This is an automated message

[GitHub] [arrow] lidavidm commented on pull request #7299: ARROW-8487: [FlightRPC] Provide a way to target a particular payload size

lidavidm commented on pull request #7299: URL: https://github.com/apache/arrow/pull/7299#issuecomment-640793323 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [arrow] liyafan82 commented on pull request #7326: ARROW-9010: [Java] Framework and interface changes for RecordBatch IPC buffer compression

liyafan82 commented on pull request #7326: URL: https://github.com/apache/arrow/pull/7326#issuecomment-640584596 Thanks a lot for your good comments. Please see my reply in line. > Looks good, few minor comments. It would be good to see this in a test (if that is

[GitHub] [arrow] github-actions[bot] commented on pull request #7375: ARROW-9066: [Python] Raise correct error in isnull()

github-actions[bot] commented on pull request #7375: URL: https://github.com/apache/arrow/pull/7375#issuecomment-640533797 https://issues.apache.org/jira/browse/ARROW-9066 This is an automated message from the Apache Git

[GitHub] [arrow] jianxind commented on a change in pull request #7382: ARROW-5760: [C++] New compute::Take implementation for better performance, faster dispatch, smaller code size / faster compilatio

jianxind commented on a change in pull request #7382: URL: https://github.com/apache/arrow/pull/7382#discussion_r437195110 ## File path: cpp/src/arrow/compute/benchmark_util.h ## @@ -77,12 +77,18 @@ struct RegressionArgs { const int64_t size; // proportion of nulls in

[GitHub] [arrow] fsaintjacques opened a new pull request #7377: ARROW-8726: [C++] Filename should not be part of DirectoryPartitioning

fsaintjacques opened a new pull request #7377: URL: https://github.com/apache/arrow/pull/7377 As the name of the class imply, only directory should be considered for partitions values. This is an automated message from the

[GitHub] [arrow] nealrichardson commented on pull request #7281: ARROW-9046: [C++][R] Put more things in type_fwds

nealrichardson commented on pull request #7281: URL: https://github.com/apache/arrow/pull/7281#issuecomment-640902096 @bkietz would you mind finishing this up and merging? Looks like there's Windows C++ test failures and an odd lint failure.

[GitHub] [arrow] github-actions[bot] commented on pull request #7382: ARROW-5760: [C++] New compute::Take implementation for better performance, faster dispatch, smaller code size / faster compilation

github-actions[bot] commented on pull request #7382: URL: https://github.com/apache/arrow/pull/7382#issuecomment-641025248 https://issues.apache.org/jira/browse/ARROW-5760 This is an automated message from the Apache Git

[GitHub] [arrow] xhochy closed pull request #7381: ARROW-9074: [GLib] Add missing arrow-json check

xhochy closed pull request #7381: URL: https://github.com/apache/arrow/pull/7381 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow] pitrou commented on pull request #7350: ARROW-6602: [Doc] Add a feature/implementation matrix

pitrou commented on pull request #7350: URL: https://github.com/apache/arrow/pull/7350#issuecomment-640684761 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [arrow] kou commented on a change in pull request #7364: ARROW-9052: [CI][MinGW] Enable Gandiva

kou commented on a change in pull request #7364: URL: https://github.com/apache/arrow/pull/7364#discussion_r436991040 ## File path: ci/scripts/cpp_test.sh ## @@ -32,13 +32,36 @@ export LD_LIBRARY_PATH=${ARROW_HOME}/${CMAKE_INSTALL_LIBDIR:-lib}:${LD_LIBRARY_P # to retrieve

[GitHub] [arrow] andygrove closed pull request #7371: ARROW-8736: [Rust] [DataFusion] Table API should provide a schema() method

andygrove closed pull request #7371: URL: https://github.com/apache/arrow/pull/7371 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow] jorisvandenbossche commented on pull request #7349: ARROW-8766: [Python] Allow implementing filesystems in Python

jorisvandenbossche commented on pull request #7349: URL: https://github.com/apache/arrow/pull/7349#issuecomment-641187317 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [arrow] lidavidm commented on a change in pull request #7282: ARROW-8958: [FlightRPC][Python] implement DoExchange

lidavidm commented on a change in pull request #7282: URL: https://github.com/apache/arrow/pull/7282#discussion_r436795302 ## File path: python/pyarrow/_flight.pyx ## @@ -844,8 +856,27 @@ cdef class FlightStreamReader(MetadataRecordBatchReader): (

[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #7349: ARROW-8766: [Python] Allow implementing filesystems in Python

jorisvandenbossche commented on a change in pull request #7349: URL: https://github.com/apache/arrow/pull/7349#discussion_r437373988 ## File path: python/pyarrow/_fs.pyx ## @@ -685,3 +756,234 @@ cdef class _MockFileSystem(FileSystem): cdef init(self, const

[GitHub] [arrow] github-actions[bot] commented on pull request #7377: ARROW-8726: [C++] Filename should not be part of DirectoryPartitioning

github-actions[bot] commented on pull request #7377: URL: https://github.com/apache/arrow/pull/7377#issuecomment-640695624 https://issues.apache.org/jira/browse/ARROW-8726 This is an automated message from the Apache Git

[GitHub] [arrow] wesm commented on pull request #7366: ARROW-8781: [CI][MinGW] Enable ccache

wesm commented on pull request #7366: URL: https://github.com/apache/arrow/pull/7366#issuecomment-640655342 hooray! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [arrow] xhochy closed pull request #7380: ARROW-9073: [C++] Fix RapidJSON include directory detection with RapidJSONConfig.cmake

xhochy closed pull request #7380: URL: https://github.com/apache/arrow/pull/7380 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow] pitrou closed pull request #7375: ARROW-9066: [Python] Raise correct error in isnull()

pitrou closed pull request #7375: URL: https://github.com/apache/arrow/pull/7375 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow] lidavidm closed pull request #7299: ARROW-8487: [FlightRPC] Provide a way to target a particular payload size

lidavidm closed pull request #7299: URL: https://github.com/apache/arrow/pull/7299 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow] nealrichardson commented on pull request #7368: ARROW-9058: [Packaging][wheel] Use sourceforge.net to download Boost

nealrichardson commented on pull request #7368: URL: https://github.com/apache/arrow/pull/7368#issuecomment-640688177 Why do these scripts use a different boost version than our cmake default (1.71.0)? This is an automated

[GitHub] [arrow] wesm edited a comment on pull request #7126: [C++][Python] Remove boost_regex dependency

wesm edited a comment on pull request #7126: URL: https://github.com/apache/arrow/pull/7126#issuecomment-640648593 That's annoying. I have a feeling we may end up vendoring Thrift itself and applying small patches to it for things like this (it's "only" 18 KLOC). We could discuss on the

[GitHub] [arrow] BryanCutler commented on pull request #6316: ARROW-7717: [CI] Have nightly integration test for Spark's latest release

BryanCutler commented on pull request #6316: URL: https://github.com/apache/arrow/pull/6316#issuecomment-640794485 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [arrow] jba commented on pull request #7376: ARROW-9043: [Go][FOLLOWUP] Move license file copy to correct location

jba commented on pull request #7376: URL: https://github.com/apache/arrow/pull/7376#issuecomment-640600339 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [arrow] kszucs commented on pull request #6316: ARROW-7717: [CI] Have nightly integration test for Spark's latest release

kszucs commented on pull request #6316: URL: https://github.com/apache/arrow/pull/6316#issuecomment-640833928 Thanks You! Although Spark 2 seems to fail as well. This is an automated message from the Apache Git Service. To

[GitHub] [arrow] chrish42 commented on pull request #7110: ARROW-8952: [C++] WIP Support for textual, JSON schema representation

chrish42 commented on pull request #7110: URL: https://github.com/apache/arrow/pull/7110#issuecomment-640771658 @emkornfield I had checked earlier, and those generated files didn't have the actual Flatbuffers schema for the `Schema` class in them, which is what is needed to generate a

[GitHub] [arrow] bkietz commented on pull request #7378: ARROW-8866: [C++] Split UNION into SPARSE_UNION and DENSE_UNION

bkietz commented on pull request #7378: URL: https://github.com/apache/arrow/pull/7378#issuecomment-640878504 @wesm no problem it didn't take much time. Sparse and Dense were basically distinct code paths already in vector_selection_internal. No need to rebase yours; rebasing this one

[GitHub] [arrow] nevi-me closed pull request #7365: ARROW-9007: [Rust] Support appending array data to builders

nevi-me closed pull request #7365: URL: https://github.com/apache/arrow/pull/7365 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow] wesm edited a comment on pull request #7378: ARROW-8866: [C++] Split UNION into SPARSE_UNION and DENSE_UNION

wesm edited a comment on pull request #7378: URL: https://github.com/apache/arrow/pull/7378#issuecomment-640849143 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [arrow] kszucs commented on pull request #7364: ARROW-9052: [CI][MinGW] Enable Gandiva

kszucs commented on pull request #7364: URL: https://github.com/apache/arrow/pull/7364#issuecomment-640882163 Merging on green. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [arrow] cyb70289 commented on a change in pull request #7373: ARROW-8974: [C++] Simplify TransferBitmap

cyb70289 commented on a change in pull request #7373: URL: https://github.com/apache/arrow/pull/7373#discussion_r437098352 ## File path: cpp/src/arrow/util/bitmap_ops.cc ## @@ -298,52 +297,52 @@ void TransferBitmap(const uint8_t* data, int64_t offset, int64_t length,

[GitHub] [arrow] wesm commented on a change in pull request #7341: ARROW-9042: [C++] Add Subtract and Multiply arithmetic kernels with wrap-around behavior

wesm commented on a change in pull request #7341: URL: https://github.com/apache/arrow/pull/7341#discussion_r437083061 ## File path: cpp/src/arrow/compute/kernels/codegen_internal.h ## @@ -337,25 +337,6 @@ void ScalarPrimitiveExecUnary(KernelContext* ctx, const ExecBatch&

[GitHub] [arrow] wesm commented on pull request #7383: ARROW-9077: [C++] Fix aggregate/scalar-compare benchmark null_percent calculation

wesm commented on pull request #7383: URL: https://github.com/apache/arrow/pull/7383#issuecomment-641364824 Thanks for fixing (and apologies for the slight carelessness on my part) This is an automated message from the

[GitHub] [arrow] github-actions[bot] commented on pull request #7383: ARROW-9077: [C++] Fix aggregate/scalar-compare benchmark null_percent calculation

github-actions[bot] commented on pull request #7383: URL: https://github.com/apache/arrow/pull/7383#issuecomment-641091736 https://issues.apache.org/jira/browse/ARROW-9077 This is an automated message from the Apache Git

[GitHub] [arrow] bkietz commented on pull request #7181: ARROW-8799: [C++][Parquet] NestedListReader needs to handle empty item batches

bkietz commented on pull request #7181: URL: https://github.com/apache/arrow/pull/7181#issuecomment-640759188 Confirmed, this resolves the issue This is an automated message from the Apache Git Service. To respond to the

[GitHub] [arrow] bkietz commented on a change in pull request #7378: ARROW-8866: [C++] Split UNION into SPARSE_UNION and DENSE_UNION

bkietz commented on a change in pull request #7378: URL: https://github.com/apache/arrow/pull/7378#discussion_r436930007 ## File path: cpp/src/arrow/c/bridge.cc ## @@ -1320,14 +1324,16 @@ struct ArrayImporter { Status Visit(const UnionType& type) { auto mode =

[GitHub] [arrow] kszucs closed pull request #7364: ARROW-9052: [CI][MinGW] Enable Gandiva

kszucs closed pull request #7364: URL: https://github.com/apache/arrow/pull/7364 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow] jba commented on pull request #7355: ARROW-9043: [Go] Temporarily copy LICENSE.txt to go/

jba commented on pull request #7355: URL: https://github.com/apache/arrow/pull/7355#issuecomment-640584322 Sorry to be a pain, folks. But the LICENSE file needs to be at the go module root, which is `go/arrow`. This is an

[GitHub] [arrow] github-actions[bot] commented on pull request #7379: ARROW-9062 [RUST] json reader dictionary support

github-actions[bot] commented on pull request #7379: URL: https://github.com/apache/arrow/pull/7379#issuecomment-640885205 https://issues.apache.org/jira/browse/ARROW-9062 This is an automated message from the Apache Git

<    1   2