[GitHub] [arrow] wesm closed pull request #6592: ARROW-8089: [C++] Port the toolchain build from Appveyor to Github Actions

2020-06-23 Thread GitBox
wesm closed pull request #6592: URL: https://github.com/apache/arrow/pull/6592 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [arrow] kou commented on pull request #7449: ARROW-9133: [C++] Add utf8_upper and utf8_lower

2020-06-23 Thread GitBox
kou commented on pull request #7449: URL: https://github.com/apache/arrow/pull/7449#issuecomment-648518023 I've added a workaround we already used: https://github.com/apache/arrow/pull/7449/commits/782499f8641da4a23d86125bcc812546107f2ce5 But it doesn't solve this yet. I'm try

[GitHub] [arrow] sagnikc-dremio commented on a change in pull request #7402: ARROW-9099: [C++][Gandiva] Implement trim function for string

2020-06-23 Thread GitBox
sagnikc-dremio commented on a change in pull request #7402: URL: https://github.com/apache/arrow/pull/7402#discussion_r444588872 ## File path: cpp/src/gandiva/precompiled/string_ops.cc ## @@ -284,6 +284,49 @@ const char* reverse_utf8(gdv_int64 context, const char* data, gdv_in

[GitHub] [arrow] hcoona commented on pull request #7493: ARROW-9183: [C++] Fix build with clang & old libstdc++.

2020-06-23 Thread GitBox
hcoona commented on pull request #7493: URL: https://github.com/apache/arrow/pull/7493#issuecomment-648542491 Got it. It seems that the gcc 4.8.5 is released later than gcc 4.9.2 & gcc 5.1. I'll take a future investigation on how to detect the missing of `std::atomic_load` overloads. ---

[GitHub] [arrow] wesm commented on pull request #7528: ARROW-8933: [C++] Trim redundant generated code from compute/kernels/vector_hash.cc

2020-06-23 Thread GitBox
wesm commented on pull request #7528: URL: https://github.com/apache/arrow/pull/7528#issuecomment-648561165 +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [arrow] wesm closed pull request #7528: ARROW-8933: [C++] Trim redundant generated code from compute/kernels/vector_hash.cc

2020-06-23 Thread GitBox
wesm closed pull request #7528: URL: https://github.com/apache/arrow/pull/7528 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [arrow] wesm commented on pull request #7530: ARROW-8934: [C++] Enable `compute::Subtract` with timestamp inputs to return duration

2020-06-23 Thread GitBox
wesm commented on pull request #7530: URL: https://github.com/apache/arrow/pull/7530#issuecomment-648561822 +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [arrow] wesm closed pull request #7530: ARROW-8934: [C++] Enable `compute::Subtract` with timestamp inputs to return duration

2020-06-23 Thread GitBox
wesm closed pull request #7530: URL: https://github.com/apache/arrow/pull/7530 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [arrow] wesm commented on pull request #7501: ARROW-9192: [Rust] run clippy to lint arrow crate in CI

2020-06-23 Thread GitBox
wesm commented on pull request #7501: URL: https://github.com/apache/arrow/pull/7501#issuecomment-648562595 Hm I think this lint step should be merged into the main Lint workflow. @kszucs can you help? This is an automated m

[GitHub] [arrow] houqp commented on pull request #7501: ARROW-9192: [Rust] run clippy to lint arrow crate in CI

2020-06-23 Thread GitBox
houqp commented on pull request #7501: URL: https://github.com/apache/arrow/pull/7501#issuecomment-648576776 @kszucs let me know if there is anything i can help to move it to the main lint workflow. This is an automated mess

[GitHub] [arrow] praveenbingo closed pull request #7402: ARROW-9099: [C++][Gandiva] Implement trim function for string

2020-06-23 Thread GitBox
praveenbingo closed pull request #7402: URL: https://github.com/apache/arrow/pull/7402 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [arrow] romainfrancois commented on a change in pull request #7524: ARROW-8899 [R] Add R metadata like pandas metadata for round-trip fidelity

2020-06-23 Thread GitBox
romainfrancois commented on a change in pull request #7524: URL: https://github.com/apache/arrow/pull/7524#discussion_r444675449 ## File path: r/tests/testthat/test-Table.R ## @@ -334,5 +334,5 @@ test_that("Table metadata", { test_that("Table handles null type (ARROW-7064)",

[GitHub] [arrow] romainfrancois commented on a change in pull request #7524: ARROW-8899 [R] Add R metadata like pandas metadata for round-trip fidelity

2020-06-23 Thread GitBox
romainfrancois commented on a change in pull request #7524: URL: https://github.com/apache/arrow/pull/7524#discussion_r444682932 ## File path: r/R/table.R ## @@ -202,7 +210,27 @@ Table$create <- function(..., schema = NULL) { #' @export as.data.frame.Table <- function(x, ro

<    1   2