pitrou commented on a change in pull request #7695:
URL: https://github.com/apache/arrow/pull/7695#discussion_r453525042
##
File path: docs/source/cpp/compute.rst
##
@@ -0,0 +1,419 @@
+.. Licensed to the Apache Software Foundation (ASF) under one
+.. or more contributor
sir-sigurd opened a new pull request #7725:
URL: https://github.com/apache/arrow/pull/7725
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
pitrou commented on a change in pull request #7695:
URL: https://github.com/apache/arrow/pull/7695#discussion_r453525416
##
File path: docs/source/cpp/compute.rst
##
@@ -0,0 +1,419 @@
+.. Licensed to the Apache Software Foundation (ASF) under one
+.. or more contributor
pitrou commented on pull request #7695:
URL: https://github.com/apache/arrow/pull/7695#issuecomment-657449500
I could give a try to list tables, but otherwise I think CSV or JSON would
be a major PITA to edit later.
This is
pitrou commented on pull request #7695:
URL: https://github.com/apache/arrow/pull/7695#issuecomment-657454065
Ok, list tables may be workable, but they don't make it easy to review docs
simply by reading the source reST code. I'd rather keep the usual reST layout,
unless you're using an
pitrou commented on a change in pull request #7695:
URL: https://github.com/apache/arrow/pull/7695#discussion_r453571743
##
File path: docs/source/cpp/compute.rst
##
@@ -0,0 +1,419 @@
+.. Licensed to the Apache Software Foundation (ASF) under one
+.. or more contributor
jorisvandenbossche commented on a change in pull request #7704:
URL: https://github.com/apache/arrow/pull/7704#discussion_r453580484
##
File path: cpp/src/parquet/arrow/reader.cc
##
@@ -780,11 +741,29 @@ Status GetReader(const SchemaField& field, const
std::shared_ptr&
jorisvandenbossche commented on a change in pull request #7704:
URL: https://github.com/apache/arrow/pull/7704#discussion_r453580484
##
File path: cpp/src/parquet/arrow/reader.cc
##
@@ -780,11 +741,29 @@ Status GetReader(const SchemaField& field, const
std::shared_ptr&
pitrou commented on a change in pull request #7695:
URL: https://github.com/apache/arrow/pull/7695#discussion_r453520967
##
File path: docs/source/cpp/compute.rst
##
@@ -0,0 +1,419 @@
+.. Licensed to the Apache Software Foundation (ASF) under one
+.. or more contributor
pitrou commented on pull request #7695:
URL: https://github.com/apache/arrow/pull/7695#issuecomment-657467563
So there are three formats to choose from:
* "full" reST table layout:
```restructuredtext
nevi-me commented on pull request #7693:
URL: https://github.com/apache/arrow/pull/7693#issuecomment-657473066
Hey @maxburke, may you please kindly rebase this. I can't push to
urbanlogiq's fork, access rights issues.
This
jorgecarleitao opened a new pull request #7723:
URL: https://github.com/apache/arrow/pull/7723
This is required when the library is used by other applications that
leverage a long-living context.
This is an automated
jorisvandenbossche commented on a change in pull request #7695:
URL: https://github.com/apache/arrow/pull/7695#discussion_r453541169
##
File path: docs/source/cpp/compute.rst
##
@@ -0,0 +1,419 @@
+.. Licensed to the Apache Software Foundation (ASF) under one
+.. or more
pitrou commented on a change in pull request #7695:
URL: https://github.com/apache/arrow/pull/7695#discussion_r453521794
##
File path: docs/source/cpp/compute.rst
##
@@ -0,0 +1,419 @@
+.. Licensed to the Apache Software Foundation (ASF) under one
+.. or more contributor
maartenbreddels commented on pull request #7656:
URL: https://github.com/apache/arrow/pull/7656#issuecomment-657470241
> ah I think I figured out the mystery of the failed compilation -- it's
caused by the missing utf8proc.
Of course, now the error msg makes sense. Thanks for
github-actions[bot] commented on pull request #7723:
URL: https://github.com/apache/arrow/pull/7723#issuecomment-657408873
https://issues.apache.org/jira/browse/ARROW-9425
This is an automated message from the Apache Git
sbinet closed pull request #7712:
URL: https://github.com/apache/arrow/pull/7712
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
jorgecarleitao opened a new pull request #7724:
URL: https://github.com/apache/arrow/pull/7724
Allows users to know what names can be passed to `table()`.
This is an automated message from the Apache Git Service.
To respond
github-actions[bot] commented on pull request #7725:
URL: https://github.com/apache/arrow/pull/7725#issuecomment-657498276
Thanks for opening a pull request!
Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW
Then
mr-smidge commented on pull request #7654:
URL: https://github.com/apache/arrow/pull/7654#issuecomment-657438635
> In general, DateTimeOffset is the preferred type to use when talking about
dates and times. The reasoning is because exactly what you point out in the
JIRA issue -
github-actions[bot] commented on pull request #7724:
URL: https://github.com/apache/arrow/pull/7724#issuecomment-657463084
https://issues.apache.org/jira/browse/ARROW-9427
This is an automated message from the Apache Git
pitrou edited a comment on pull request #7695:
URL: https://github.com/apache/arrow/pull/7695#issuecomment-657467563
So there are three formats to choose from:
* "full" reST table layout:
```restructuredtext
sbinet commented on pull request #7712:
URL: https://github.com/apache/arrow/pull/7712#issuecomment-657458768
probably more mine (mistake) than yours :)
This is an automated message from the Apache Git Service.
To respond to
jorisvandenbossche commented on a change in pull request #7695:
URL: https://github.com/apache/arrow/pull/7695#discussion_r453541169
##
File path: docs/source/cpp/compute.rst
##
@@ -0,0 +1,419 @@
+.. Licensed to the Apache Software Foundation (ASF) under one
+.. or more
mr-smidge commented on a change in pull request #7671:
URL: https://github.com/apache/arrow/pull/7671#discussion_r453692211
##
File path: csharp/src/Apache.Arrow/Arrays/BinaryArray.cs
##
@@ -66,87 +66,158 @@ protected BuilderBase(IArrowType dataType)
mr-smidge commented on pull request #7671:
URL: https://github.com/apache/arrow/pull/7671#issuecomment-657595775
> This is looking really good. I just have a few comments, and then it
should be ready to merge.
All comments should be addressed now :smile:.
jorisvandenbossche commented on pull request #7272:
URL: https://github.com/apache/arrow/pull/7272#issuecomment-657595819
@pitrou could you check the C++ test?
This is an automated message from the Apache Git Service.
To
github-actions[bot] commented on pull request #7732:
URL: https://github.com/apache/arrow/pull/7732#issuecomment-657640362
Thanks for opening a pull request!
Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW
Then
github-actions[bot] commented on pull request #7726:
URL: https://github.com/apache/arrow/pull/7726#issuecomment-657562660
https://issues.apache.org/jira/browse/ARROW-8574
This is an automated message from the Apache Git
jorisvandenbossche edited a comment on pull request #7272:
URL: https://github.com/apache/arrow/pull/7272#issuecomment-657595819
@pitrou could you check the C++ test?
(fixing the linting issue)
This is an automated
kszucs commented on pull request #7728:
URL: https://github.com/apache/arrow/pull/7728#issuecomment-657629261
@github-actions crossbow submit wheel-osx-cp37m
This is an automated message from the Apache Git Service.
To
jorisvandenbossche commented on pull request #6979:
URL: https://github.com/apache/arrow/pull/6979#issuecomment-657539765
@wjones1 sorry for the slow follow-up. Could you rebase the PR?
This is an automated message from the
pitrou opened a new pull request #7727:
URL: https://github.com/apache/arrow/pull/7727
Some bits were left uninitialized in the expected boolean array.
Also fix some warnings.
This is an automated message from the
mr-smidge commented on a change in pull request #7654:
URL: https://github.com/apache/arrow/pull/7654#discussion_r453675969
##
File path: csharp/src/Apache.Arrow/Arrays/DelegatingArrayBuilder.cs
##
@@ -0,0 +1,96 @@
jorgecarleitao opened a new pull request #7729:
URL: https://github.com/apache/arrow/pull/7729
This is written on top of #7687, so we should merge the other first.
This does not include any optimization to actually use this operation. We
need to work out in a future PR.
jorgecarleitao commented on pull request #7729:
URL: https://github.com/apache/arrow/pull/7729#issuecomment-657614516
One thing that is not clear to me yet is the idiom to handle RecordBatch and
partitions. My understanding is that a Partition can be executed in parallel
(thread), but a
jorisvandenbossche merged pull request #7725:
URL: https://github.com/apache/arrow/pull/7725
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
github-actions[bot] commented on pull request #7728:
URL: https://github.com/apache/arrow/pull/7728#issuecomment-657630349
Revision: 3918afa462f461c4c3e63858fa7273b8354e3e8c
Submitted crossbow builds: [ursa-labs/crossbow @
pitrou commented on pull request #7695:
URL: https://github.com/apache/arrow/pull/7695#issuecomment-657557007
> Does that include tables which use the file: directive to refer to an
out-of-line table source?
Do you mean you would like to edit a CSV table in a spreadsheet?
nevi-me closed pull request #7726:
URL: https://github.com/apache/arrow/pull/7726
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
mr-smidge commented on a change in pull request #7671:
URL: https://github.com/apache/arrow/pull/7671#discussion_r453690625
##
File path: csharp/src/Apache.Arrow/Arrays/BinaryArray.cs
##
@@ -66,87 +66,158 @@ protected BuilderBase(IArrowType dataType)
mr-smidge commented on a change in pull request #7671:
URL: https://github.com/apache/arrow/pull/7671#discussion_r453690533
##
File path: csharp/src/Apache.Arrow/Arrays/BinaryArray.cs
##
@@ -66,87 +66,158 @@ protected BuilderBase(IArrowType dataType)
mr-smidge commented on a change in pull request #7671:
URL: https://github.com/apache/arrow/pull/7671#discussion_r453690865
##
File path: csharp/src/Apache.Arrow/Arrays/BinaryArray.cs
##
@@ -66,87 +66,158 @@ protected BuilderBase(IArrowType dataType)
andygrove closed pull request #7713:
URL: https://github.com/apache/arrow/pull/7713
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
github-actions[bot] commented on pull request #7731:
URL: https://github.com/apache/arrow/pull/7731#issuecomment-657629920
https://issues.apache.org/jira/browse/ARROW-9428
This is an automated message from the Apache Git
bkietz commented on pull request #7695:
URL: https://github.com/apache/arrow/pull/7695#issuecomment-657556478
> I could give a try to list tables, but otherwise I think CSV or JSON would
be a major PITA to edit later.
Does that include tables which use the `file:` directive to refer
kszucs commented on a change in pull request #7684:
URL: https://github.com/apache/arrow/pull/7684#discussion_r453648012
##
File path: cpp/src/arrow/array/util.cc
##
@@ -323,15 +336,52 @@ class RepeatedArrayFactory {
return Status::OK();
}
- Status Visit(const
kszucs commented on a change in pull request #7684:
URL: https://github.com/apache/arrow/pull/7684#discussion_r453648012
##
File path: cpp/src/arrow/array/util.cc
##
@@ -323,15 +336,52 @@ class RepeatedArrayFactory {
return Status::OK();
}
- Status Visit(const
github-actions[bot] commented on pull request #7727:
URL: https://github.com/apache/arrow/pull/7727#issuecomment-657587626
https://issues.apache.org/jira/browse/ARROW-9436
This is an automated message from the Apache Git
jorisvandenbossche commented on pull request #7725:
URL: https://github.com/apache/arrow/pull/7725#issuecomment-657615407
Thanks!
This is an automated message from the Apache Git Service.
To respond to the message, please
jorgecarleitao commented on pull request #7729:
URL: https://github.com/apache/arrow/pull/7729#issuecomment-657615416
Another point of contest here is that I have not tested what happens to rows
with one key whose value is null.
kszucs commented on pull request #7728:
URL: https://github.com/apache/arrow/pull/7728#issuecomment-657626261
This heavily increases the build time (by ~1000s), I'm trying to find an
alternative solution.
This is an
mr-smidge commented on a change in pull request #7654:
URL: https://github.com/apache/arrow/pull/7654#discussion_r453673591
##
File path: csharp/src/Apache.Arrow/Arrays/DateArrayBuilder.cs
##
@@ -0,0 +1,179 @@
github-actions[bot] commented on pull request #7728:
URL: https://github.com/apache/arrow/pull/7728#issuecomment-657587629
https://issues.apache.org/jira/browse/ARROW-9437
This is an automated message from the Apache Git
github-actions[bot] commented on pull request #7728:
URL: https://github.com/apache/arrow/pull/7728#issuecomment-657587490
Revision: bc1fecf8cd87c4415803afee53f85edd9ccab3ce
Submitted crossbow builds: [ursa-labs/crossbow @
github-actions[bot] commented on pull request #7729:
URL: https://github.com/apache/arrow/pull/7729#issuecomment-657604297
https://issues.apache.org/jira/browse/ARROW-9420
This is an automated message from the Apache Git
vertexclique opened a new pull request #7726:
URL: https://github.com/apache/arrow/pull/7726
@andygrove @nevi-me @paddyhoran
This is an automated message from the Apache Git Service.
To respond to the message, please log on
mr-smidge commented on a change in pull request #7654:
URL: https://github.com/apache/arrow/pull/7654#discussion_r453670993
##
File path: csharp/src/Apache.Arrow/Arrays/Date32Array.cs
##
@@ -55,16 +70,39 @@ public Date32Array(ArrayData data)
public override void
pitrou opened a new pull request #7730:
URL: https://github.com/apache/arrow/pull/7730
Also make some optional arguments keyword-only.
This is an automated message from the Apache Git Service.
To respond to the message,
bkietz commented on a change in pull request #7704:
URL: https://github.com/apache/arrow/pull/7704#discussion_r453715480
##
File path: cpp/src/parquet/arrow/reader.cc
##
@@ -780,11 +741,29 @@ Status GetReader(const SchemaField& field, const
std::shared_ptr&
Status
pitrou opened a new pull request #7731:
URL: https://github.com/apache/arrow/pull/7731
Use Result-returning AllocateBuffer() version in example.
Also improve cross-referencing in some places.
This is an automated
kszucs opened a new pull request #7732:
URL: https://github.com/apache/arrow/pull/7732
Using the existing numpydoc checker in archery. I've enabled a single rule
to check undocumented arguments.
This is an automated message
kszucs commented on pull request #7684:
URL: https://github.com/apache/arrow/pull/7684#issuecomment-657537128
It supports MapScalar, but not the union scalar because we'd need to have
the type_code information stored in the union scalar value in order to properly
reconstruct a union array
kszucs opened a new pull request #7728:
URL: https://github.com/apache/arrow/pull/7728
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
kszucs commented on pull request #7728:
URL: https://github.com/apache/arrow/pull/7728#issuecomment-657586351
@github-actions crossbow submit wheel-osx-*
This is an automated message from the Apache Git Service.
To respond
andygrove closed pull request #7724:
URL: https://github.com/apache/arrow/pull/7724
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
andygrove closed pull request #7723:
URL: https://github.com/apache/arrow/pull/7723
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
github-actions[bot] commented on pull request #7730:
URL: https://github.com/apache/arrow/pull/7730#issuecomment-657618643
https://issues.apache.org/jira/browse/ARROW-9333
This is an automated message from the Apache Git
wesm commented on a change in pull request #7684:
URL: https://github.com/apache/arrow/pull/7684#discussion_r453807979
##
File path: cpp/src/arrow/array/array_test.cc
##
@@ -384,6 +398,40 @@ TEST_F(TestArray, TestMakeArrayFromScalar) {
}
}
+TEST_F(TestArray,
wesm closed pull request #7684:
URL: https://github.com/apache/arrow/pull/7684
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
wesm closed pull request #7695:
URL: https://github.com/apache/arrow/pull/7695
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
pitrou commented on a change in pull request #7733:
URL: https://github.com/apache/arrow/pull/7733#discussion_r453835979
##
File path: cpp/src/arrow/array/data.cc
##
@@ -105,6 +106,22 @@ std::shared_ptr ArrayData::Slice(int64_t off,
int64_t len) const {
return copy;
}
bkietz commented on a change in pull request #7733:
URL: https://github.com/apache/arrow/pull/7733#discussion_r453851648
##
File path: cpp/src/arrow/buffer.cc
##
@@ -43,6 +44,56 @@ Result> Buffer::CopySlice(const
int64_t start,
return std::move(new_buffer);
}
+namespace
jorisvandenbossche opened a new pull request #7737:
URL: https://github.com/apache/arrow/pull/7737
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
wesm opened a new pull request #7738:
URL: https://github.com/apache/arrow/pull/7738
Example output:
```
In [1]: pa.show_versions()
kszucs commented on a change in pull request #7684:
URL: https://github.com/apache/arrow/pull/7684#discussion_r453896254
##
File path: cpp/src/arrow/array/array_test.cc
##
@@ -384,6 +398,40 @@ TEST_F(TestArray, TestMakeArrayFromScalar) {
}
}
+TEST_F(TestArray,
wesm closed pull request #7731:
URL: https://github.com/apache/arrow/pull/7731
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
wesm edited a comment on pull request #7695:
URL: https://github.com/apache/arrow/pull/7695#issuecomment-657697264
I guess it's a matter of perspective. I don't feel at all comfortable
editing the RST tables, whereas I would be fine editing a CSV file. Many text
editors (e.g. emacs, vim)
pitrou commented on a change in pull request #7733:
URL: https://github.com/apache/arrow/pull/7733#discussion_r453833175
##
File path: cpp/src/arrow/buffer.cc
##
@@ -43,6 +44,56 @@ Result> Buffer::CopySlice(const
int64_t start,
return std::move(new_buffer);
}
+namespace
bkietz commented on a change in pull request #7733:
URL: https://github.com/apache/arrow/pull/7733#discussion_r453830282
##
File path: cpp/src/arrow/buffer.cc
##
@@ -43,6 +44,56 @@ Result> Buffer::CopySlice(const
int64_t start,
return std::move(new_buffer);
}
+namespace
pitrou commented on a change in pull request #7733:
URL: https://github.com/apache/arrow/pull/7733#discussion_r453832881
##
File path: cpp/src/arrow/array/data.cc
##
@@ -105,6 +106,22 @@ std::shared_ptr ArrayData::Slice(int64_t off,
int64_t len) const {
return copy;
}
pitrou commented on a change in pull request #7733:
URL: https://github.com/apache/arrow/pull/7733#discussion_r453833318
##
File path: cpp/src/arrow/array/concatenate.cc
##
@@ -151,6 +151,10 @@ static Status PutOffsets(const std::shared_ptr&
src, Offset first_offset
github-actions[bot] commented on pull request #7734:
URL: https://github.com/apache/arrow/pull/7734#issuecomment-657714889
https://issues.apache.org/jira/browse/ARROW-8480
This is an automated message from the Apache Git
github-actions[bot] commented on pull request #7733:
URL: https://github.com/apache/arrow/pull/7733#issuecomment-657714890
https://issues.apache.org/jira/browse/ARROW-9439
This is an automated message from the Apache Git
wesm opened a new pull request #7735:
URL: https://github.com/apache/arrow/pull/7735
Using a fairly large IPC stream file:
Before:
```
In [1]: timeit pa.ipc.open_stream('nyctaxi.arrow').read_all()
129 ms ± 1.51 ms per loop (mean ± std. dev. of 7 runs, 10 loops each)
github-actions[bot] commented on pull request #7737:
URL: https://github.com/apache/arrow/pull/7737#issuecomment-657742505
https://issues.apache.org/jira/browse/ARROW-9445
This is an automated message from the Apache Git
kszucs commented on pull request #7728:
URL: https://github.com/apache/arrow/pull/7728#issuecomment-657656109
@github-actions crossbow submit wheel-osx-cp37m
This is an automated message from the Apache Git Service.
To
bkietz commented on a change in pull request #7731:
URL: https://github.com/apache/arrow/pull/7731#discussion_r453792540
##
File path: docs/source/cpp/memory.rst
##
@@ -71,11 +74,12 @@ You can allocate a buffer yourself by calling one of the
:func:`arrow::AllocateBuffer` or
github-actions[bot] commented on pull request #7728:
URL: https://github.com/apache/arrow/pull/7728#issuecomment-657674145
Revision: c0a81d435f49e437334e2f12fa0b666b92bdaf3c
Submitted crossbow builds: [ursa-labs/crossbow @
github-actions[bot] commented on pull request #7727:
URL: https://github.com/apache/arrow/pull/7727#issuecomment-657674238
Revision: 5bb36e669d872a07a3848b669670316627000282
Submitted crossbow builds: [ursa-labs/crossbow @
pitrou commented on pull request #7695:
URL: https://github.com/apache/arrow/pull/7695#issuecomment-657699568
The three options I would be comfortable with are those I proposed in my
comment above. I think it would be clumsy to have to edit separate _files_
using a spreadsheet editor to
pitrou commented on pull request #7656:
URL: https://github.com/apache/arrow/pull/7656#issuecomment-657721811
Ah, I hadn't noticed this was merged. This will need documenting in
[docs/source/cpp/compute.rst](https://github.com/apache/arrow/blob/master/docs/source/cpp/compute.rst).
wesm commented on pull request #7735:
URL: https://github.com/apache/arrow/pull/7735#issuecomment-657722389
We could also add a `validate` option to `read_all` if there are concerns
about the result being invalid
This is an
pitrou commented on a change in pull request #7733:
URL: https://github.com/apache/arrow/pull/7733#discussion_r453864724
##
File path: cpp/src/arrow/buffer.cc
##
@@ -43,6 +44,56 @@ Result> Buffer::CopySlice(const
int64_t start,
return std::move(new_buffer);
}
+namespace
wesm commented on pull request #7656:
URL: https://github.com/apache/arrow/pull/7656#issuecomment-657737598
Yes, indeed.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
pitrou commented on pull request #7735:
URL: https://github.com/apache/arrow/pull/7735#issuecomment-657749727
`pyarrow_wrap_array` doesn't validate, so perhaps we should drop validation
from `pyarrow_wrap_table` as well (and instead validate in interested
consumers).
wesm commented on pull request #7735:
URL: https://github.com/apache/arrow/pull/7735#issuecomment-657755356
Good point. I will look to see what the validation check was added
(presumably it was to fix some segfault)
This is
wesm edited a comment on pull request #7735:
URL: https://github.com/apache/arrow/pull/7735#issuecomment-657755356
Good point. I will look to see why the validation check was added
(presumably it was to fix some segfault)
github-actions[bot] commented on pull request #7738:
URL: https://github.com/apache/arrow/pull/7738#issuecomment-657755738
https://issues.apache.org/jira/browse/ARROW-9446
This is an automated message from the Apache Git
kszucs commented on pull request #7727:
URL: https://github.com/apache/arrow/pull/7727#issuecomment-657657578
@github-actions crossbow submit conda-cpp-valgrind
This is an automated message from the Apache Git Service.
To
1 - 100 of 176 matches
Mail list logo
