[GitHub] [arrow] alamb commented on pull request #8172: ARROW-9937: [Rust] [DataFusion] Improved aggregations

2020-09-20 Thread GitBox
alamb commented on pull request #8172: URL: https://github.com/apache/arrow/pull/8172#issuecomment-695767060 Thanks @jorgecarleitao -- I don't feel strongly about the ScalarValue thign This is an automated message from the

[GitHub] [arrow] alamb edited a comment on pull request #8172: ARROW-9937: [Rust] [DataFusion] Improved aggregations

2020-09-20 Thread GitBox
alamb edited a comment on pull request #8172: URL: https://github.com/apache/arrow/pull/8172#issuecomment-695767060 Thanks @jorgecarleitao -- I don't feel strongly about the ScalarValue thing This is an automated message

[GitHub] [arrow] github-actions[bot] commented on pull request #8225: ARROW-10046: [Rust] [DataFusion] Made `*Iterator` implement Iterator

2020-09-20 Thread GitBox
github-actions[bot] commented on pull request #8225: URL: https://github.com/apache/arrow/pull/8225#issuecomment-695772272 https://issues.apache.org/jira/browse/ARROW-10046 This is an automated message from the Apache Git

[GitHub] [arrow] jorgecarleitao opened a new pull request #8225: ARROW-10046: [Rust] [DataFusion] Made `*Iterator` implement Iterator

2020-09-20 Thread GitBox
jorgecarleitao opened a new pull request #8225: URL: https://github.com/apache/arrow/pull/8225 This is a proposal to change how we programmatically iterate over record batches in arrow and datafusion. Instead of ``` pub fn collect( it: Arc>, ) -> Result> {

[GitHub] [arrow] nevi-me commented on a change in pull request #8199: ARROW-10019: [Rust] Add substring kernel

2020-09-20 Thread GitBox
nevi-me commented on a change in pull request #8199: URL: https://github.com/apache/arrow/pull/8199#discussion_r491702713 ## File path: rust/arrow/src/compute/kernels/substring.rs ## @@ -0,0 +1,226 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

[GitHub] [arrow] github-actions[bot] commented on pull request #8226: ARROW-10048: [Rust] Fixed error in computing min/max with null entries.

2020-09-20 Thread GitBox
github-actions[bot] commented on pull request #8226: URL: https://github.com/apache/arrow/pull/8226#issuecomment-695813753 https://issues.apache.org/jira/browse/ARROW-10048 This is an automated message from the Apache Git

[GitHub] [arrow] xhochy opened a new pull request #8228: ARROW-10049: [C++/Python] Sync conda recipe with conda-forge

2020-09-20 Thread GitBox
xhochy opened a new pull request #8228: URL: https://github.com/apache/arrow/pull/8228 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [arrow] xhochy commented on pull request #8228: ARROW-10049: [C++/Python] Sync conda recipe with conda-forge

2020-09-20 Thread GitBox
xhochy commented on pull request #8228: URL: https://github.com/apache/arrow/pull/8228#issuecomment-695829727 @github-actions crossbow submit -g conda This is an automated message from the Apache Git Service. To respond to

[GitHub] [arrow] github-actions[bot] commented on pull request #8228: ARROW-10049: [C++/Python] Sync conda recipe with conda-forge

2020-09-20 Thread GitBox
github-actions[bot] commented on pull request #8228: URL: https://github.com/apache/arrow/pull/8228#issuecomment-695829873 Revision: b4e4a8ca7ce8e922edf539bf416ef709c0cc57b3 Submitted crossbow builds: [ursa-labs/crossbow @

[GitHub] [arrow] jhorstmann commented on pull request #8223: ARROW-10040: [Rust] Add slice that realigns Buffer

2020-09-20 Thread GitBox
jhorstmann commented on pull request #8223: URL: https://github.com/apache/arrow/pull/8223#issuecomment-695831200 Hi @nevi-me I guess I have to thank you for pushing this topic. I played around today with a different approach today that uses an iterator over the validity mask and returns

[GitHub] [arrow] github-actions[bot] commented on pull request #8227: ARROW-9946: [R] Check `sink` argument class in `ParquetFileWriter`

2020-09-20 Thread GitBox
github-actions[bot] commented on pull request #8227: URL: https://github.com/apache/arrow/pull/8227#issuecomment-695821544 https://issues.apache.org/jira/browse/ARROW-9946 This is an automated message from the Apache Git

[GitHub] [arrow] jorgecarleitao commented on issue #8217: How to transform the Arrow data column to array of array efficiently?

2020-09-20 Thread GitBox
jorgecarleitao commented on issue #8217: URL: https://github.com/apache/arrow/issues/8217#issuecomment-695783084 Hi @Zarca, 1. In any particular language? 2. Arrow is a columnar format. Thus, it is already formatted like you wrote. If you mean is the transpose (i.e. `array[i]`

[GitHub] [arrow] andygrove commented on pull request #8172: ARROW-9937: [Rust] [DataFusion] Improved aggregations

2020-09-20 Thread GitBox
andygrove commented on pull request #8172: URL: https://github.com/apache/arrow/pull/8172#issuecomment-695804151 @jorgecarleitao This needs rebasing against master. I ran into compilation issues after merging master into this branch. ``` error[E0308]: mismatched types -->

[GitHub] [arrow] andygrove commented on a change in pull request #8172: ARROW-9937: [Rust] [DataFusion] Improved aggregations

2020-09-20 Thread GitBox
andygrove commented on a change in pull request #8172: URL: https://github.com/apache/arrow/pull/8172#discussion_r491702697 ## File path: rust/datafusion/src/sql/planner.rs ## @@ -343,7 +343,7 @@ impl<'a, S: SchemaProvider> SqlToRel<'a, S> { match *limit {

[GitHub] [arrow] github-actions[bot] commented on pull request #8228: ARROW-10049: [C++/Python] Sync conda recipe with conda-forge

2020-09-20 Thread GitBox
github-actions[bot] commented on pull request #8228: URL: https://github.com/apache/arrow/pull/8228#issuecomment-695830006 https://issues.apache.org/jira/browse/ARROW-10049 This is an automated message from the Apache Git

[GitHub] [arrow] andygrove closed pull request #8102: ARROW-9902: [Rust] [DataFusion] Add array() built-in function

2020-09-20 Thread GitBox
andygrove closed pull request #8102: URL: https://github.com/apache/arrow/pull/8102 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow] liyafan82 commented on pull request #8194: ARROW-10017: [Java] Fix LargeMemoryUtil long conversion

2020-09-20 Thread GitBox
liyafan82 commented on pull request #8194: URL: https://github.com/apache/arrow/pull/8194#issuecomment-695884515 Merging. Thanks for the PR @pwoody This is an automated message from the Apache Git Service. To respond to the

[GitHub] [arrow] xhochy commented on pull request #8228: ARROW-10049: [C++/Python] Sync conda recipe with conda-forge

2020-09-20 Thread GitBox
xhochy commented on pull request #8228: URL: https://github.com/apache/arrow/pull/8228#issuecomment-695915665 @github-actions crossbow submit -g conda This is an automated message from the Apache Git Service. To respond to

[GitHub] [arrow] liyafan82 commented on pull request #8214: ARROW-9965: [Java] Improve performance of BaseFixedWidthVector.setSafe by optimizing capacity calculations

2020-09-20 Thread GitBox
liyafan82 commented on pull request #8214: URL: https://github.com/apache/arrow/pull/8214#issuecomment-695873809 @josiahyan Thank you for the additional details. I think one of your concern is that, the underlying buffers can be changed unintentionally, which lefts the vector in an

[GitHub] [arrow] liyafan82 closed pull request #8194: ARROW-10017: [Java] Fix LargeMemoryUtil long conversion

2020-09-20 Thread GitBox
liyafan82 closed pull request #8194: URL: https://github.com/apache/arrow/pull/8194 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow] github-actions[bot] commented on pull request #8230: ARROW-10050: [C++][Gandiva] Implement concat() in Gandiva for up to 10 arguments

2020-09-20 Thread GitBox
github-actions[bot] commented on pull request #8230: URL: https://github.com/apache/arrow/pull/8230#issuecomment-695901406 https://issues.apache.org/jira/browse/ARROW-10050 This is an automated message from the Apache Git

[GitHub] [arrow] zeroshade commented on pull request #8175: ARROW-8601: [Go][Flight] Implementations Flight RPC server and client

2020-09-20 Thread GitBox
zeroshade commented on pull request #8175: URL: https://github.com/apache/arrow/pull/8175#issuecomment-695894267 Bump. Can someone please give this a review so we can get this merged? Thanks. This is an automated message

[GitHub] [arrow] naman1996 opened a new pull request #8231: Arrow 10023: [C++][Gandiva] Implement split_part function in gandiva

2020-09-20 Thread GitBox
naman1996 opened a new pull request #8231: URL: https://github.com/apache/arrow/pull/8231 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [arrow] xieqi opened a new pull request #8229: ARROW-9579: [C++] Provide the plugin API to support customized compression codec for parquet

2020-09-20 Thread GitBox
xieqi opened a new pull request #8229: URL: https://github.com/apache/arrow/pull/8229 This PR provide plugin framework for parquet to support customized compression codec , please see proposal https://docs.google.com/document/d/1W_TxVRN7WV1wBVOTdbxngzBek1nTolMlJWy6aqC6WG8/edit

[GitHub] [arrow] github-actions[bot] commented on pull request #8229: ARROW-9579: [C++] Provide the plugin API to support customized compression codec for parquet

2020-09-20 Thread GitBox
github-actions[bot] commented on pull request #8229: URL: https://github.com/apache/arrow/pull/8229#issuecomment-695862390 https://issues.apache.org/jira/browse/ARROW-9579 This is an automated message from the Apache Git

[GitHub] [arrow] xhochy commented on pull request #8228: ARROW-10049: [C++/Python] Sync conda recipe with conda-forge

2020-09-20 Thread GitBox
xhochy commented on pull request #8228: URL: https://github.com/apache/arrow/pull/8228#issuecomment-695904997 @github-actions crossbow submit conda-linux-gcc-py36-cpu This is an automated message from the Apache

[GitHub] [arrow] xhochy commented on pull request #8228: ARROW-10049: [C++/Python] Sync conda recipe with conda-forge

2020-09-20 Thread GitBox
xhochy commented on pull request #8228: URL: https://github.com/apache/arrow/pull/8228#issuecomment-695904892 @github-actions crossbow submit conda-linux-gcc-py36-cpu -- This is an automated message

[GitHub] [arrow] xhochy removed a comment on pull request #8228: ARROW-10049: [C++/Python] Sync conda recipe with conda-forge

2020-09-20 Thread GitBox
xhochy removed a comment on pull request #8228: URL: https://github.com/apache/arrow/pull/8228#issuecomment-695904892 @github-actions crossbow submit conda-linux-gcc-py36-cpu -- This is an automated

[GitHub] [arrow] cyb70289 commented on pull request #8232: ARROW-10051: [C++][Compute] Make aggregate kernel state mutable

2020-09-20 Thread GitBox
cyb70289 commented on pull request #8232: URL: https://github.com/apache/arrow/pull/8232#issuecomment-695913785 **Benchmark mode kernel on Xeon Gold 5218** - clang-9 ``` benchmark baselinecontender change % 27

[GitHub] [arrow] sagnikc-dremio opened a new pull request #8230: ARROW-10050: [C++][Gandiva] Implement concat() in Gandiva for up to 10 arguments

2020-09-20 Thread GitBox
sagnikc-dremio opened a new pull request #8230: URL: https://github.com/apache/arrow/pull/8230 concat() is already implemented for 2 arguments in Gandiva. This PR attempts to implement concat() for up to 10 utf8 strings.

[GitHub] [arrow] github-actions[bot] commented on pull request #8228: ARROW-10049: [C++/Python] Sync conda recipe with conda-forge

2020-09-20 Thread GitBox
github-actions[bot] commented on pull request #8228: URL: https://github.com/apache/arrow/pull/8228#issuecomment-695905448 Revision: 1a282a5774732835c8678b6329e32256054b8dc3 Submitted crossbow builds: [ursa-labs/crossbow @

[GitHub] [arrow] github-actions[bot] commented on pull request #8231: Arrow 10023: [C++][Gandiva] Implement split_part function in gandiva

2020-09-20 Thread GitBox
github-actions[bot] commented on pull request #8231: URL: https://github.com/apache/arrow/pull/8231#issuecomment-695912228 Thanks for opening a pull request! Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW Then

[GitHub] [arrow] cyb70289 opened a new pull request #8232: ARROW-10051: [C++][Compute] Make aggregate kernel state mutable

2020-09-20 Thread GitBox
cyb70289 opened a new pull request #8232: URL: https://github.com/apache/arrow/pull/8232 Aggregate kernel consumes one batch and output a `state`, which is then merged with other batches. Currently, `state` parameter is defined as `const KernelState&` in `merge` interface. It may