[GitHub] [arrow] github-actions[bot] commented on pull request #8242: ARROW-10065: [Rust] Simplify code (+500, -1k)

2020-09-22 Thread GitBox
github-actions[bot] commented on pull request #8242: URL: https://github.com/apache/arrow/pull/8242#issuecomment-696821165 https://issues.apache.org/jira/browse/ARROW-10065 This is an automated message from the Apache Git

[GitHub] [arrow] emkornfield commented on a change in pull request #7326: ARROW-9010: [Java] Framework and interface changes for RecordBatch IPC buffer compression

2020-09-22 Thread GitBox
emkornfield commented on a change in pull request #7326: URL: https://github.com/apache/arrow/pull/7326#discussion_r493187630 ## File path: java/vector/src/main/java/org/apache/arrow/vector/compression/CompressionCodec.java ## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache

[GitHub] [arrow] kiszk edited a comment on pull request #8210: ARROW-10031: [CI][Java] Support Java benchmark in Ursabot

2020-09-22 Thread GitBox
kiszk edited a comment on pull request #8210: URL: https://github.com/apache/arrow/pull/8210#issuecomment-697119568 @liyafan82 Thank you for your comment. I will set these two properties as default for Java benchmarking .

[GitHub] [arrow] liyafan82 commented on pull request #8214: ARROW-9965: [Java] Improve performance of BaseFixedWidthVector.setSafe by optimizing capacity calculations

2020-09-22 Thread GitBox
liyafan82 commented on pull request #8214: URL: https://github.com/apache/arrow/pull/8214#issuecomment-697114813 Thank you all for the fruitful discussion. One small reminder for @josiahyan : to cache the buffer capacity, it is sufficient to use an `int` instead of a `long`

[GitHub] [arrow] liyafan82 commented on pull request #8210: ARROW-10031: [CI][Java] Support Java benchmark in Ursabot

2020-09-22 Thread GitBox
liyafan82 commented on pull request #8210: URL: https://github.com/apache/arrow/pull/8210#issuecomment-697118857 @kiszk Thank you for doing this. Please note that when running the benchmarks, some flags should be configured properly. They can be set through environmental variables:

[GitHub] [arrow] pitrou closed pull request #8136: ARROW-9078: [C++] Parquet read / write extension type with nested storage type

2020-09-22 Thread GitBox
pitrou closed pull request #8136: URL: https://github.com/apache/arrow/pull/8136 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow] cyb70289 commented on pull request #8232: ARROW-10051: [C++][Compute] Make aggregate kernel state mutable

2020-09-22 Thread GitBox
cyb70289 commented on pull request #8232: URL: https://github.com/apache/arrow/pull/8232#issuecomment-696485953 CI failure is about flight test. Looks not related. https://ci.appveyor.com/project/ApacheSoftwareFoundation/arrow/builds/35331179/job/i7l5oi2mxnwytd4q#L1788

[GitHub] [arrow] emkornfield commented on pull request #8219: ARROW-9603: [C++] Fix parquet write to not assume leaf-array validity bitmaps have the same values as parent structs

2020-09-22 Thread GitBox
emkornfield commented on pull request #8219: URL: https://github.com/apache/arrow/pull/8219#issuecomment-696503073 @xhochy did you want to review? This is an automated message from the Apache Git Service. To respond to the

[GitHub] [arrow] xhochy closed pull request #8239: ARROW-10064: [C++] Resolve compile warnings on Apple Clang 12

2020-09-22 Thread GitBox
xhochy closed pull request #8239: URL: https://github.com/apache/arrow/pull/8239 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow] kszucs closed pull request #8228: ARROW-10049: [C++/Python] Sync conda recipe with conda-forge

2020-09-22 Thread GitBox
kszucs closed pull request #8228: URL: https://github.com/apache/arrow/pull/8228 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow] emkornfield commented on a change in pull request #8219: ARROW-9603: [C++] Fix parquet write to not assume leaf-array validity bitmaps have the same values as parent structs

2020-09-22 Thread GitBox
emkornfield commented on a change in pull request #8219: URL: https://github.com/apache/arrow/pull/8219#discussion_r492461706 ## File path: cpp/src/parquet/arrow/arrow_reader_writer_test.cc ## @@ -2360,6 +2361,49 @@ TEST(ArrowReadWrite, SingleColumnNullableStruct) { 3);

[GitHub] [arrow] wesm closed pull request #7789: PARQUET-1878: [C++] lz4 codec is not compatible with Hadoop Lz4Codec

2020-09-22 Thread GitBox
wesm closed pull request #7789: URL: https://github.com/apache/arrow/pull/7789 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [arrow] kiszk commented on pull request #8210: ARROW-10031: [CI][Java] Support Java benchmark in Ursabot

2020-09-22 Thread GitBox
kiszk commented on pull request #8210: URL: https://github.com/apache/arrow/pull/8210#issuecomment-697119568 @liyafan82 Thank you for your comment. I will set these two properties as default. This is an automated message

[GitHub] [arrow] xieqi commented on pull request #8229: ARROW-9579: [C++] Provide the plugin API to support customized compression codec for parquet

2020-09-22 Thread GitBox
xieqi commented on pull request #8229: URL: https://github.com/apache/arrow/pull/8229#issuecomment-697120706 @pitrou For Parquet write, the end-user still use the standard GZip as the compression codec, we add a compression_plugin API in parquet WriterProperties Builder, the end-user

[GitHub] [arrow] emkornfield commented on a change in pull request #7214: ARROW-8842: [Java] fix ListVector's setValueCount to set inner vector's value count correctly

2020-09-22 Thread GitBox
emkornfield commented on a change in pull request #7214: URL: https://github.com/apache/arrow/pull/7214#discussion_r493188671 ## File path: java/vector/src/main/java/org/apache/arrow/vector/complex/ListVector.java ## @@ -844,7 +844,7 @@ public void setValueCount(int

<    1   2   3