stuartcarnie commented on pull request #8175:
URL: https://github.com/apache/arrow/pull/8175#issuecomment-698748217
Yes, thanks!
This is an automated message from the Apache Git Service.
To respond to the message, please
romainfrancois commented on a change in pull request #8256:
URL: https://github.com/apache/arrow/pull/8256#discussion_r494775017
##
File path: r/src/arrow_cpp11.h
##
@@ -310,4 +312,32 @@ enable_if_enum as_sexp(E e) {
return as_sexp(static_cast(e));
}
+template
+SEXP
romainfrancois commented on a change in pull request #8256:
URL: https://github.com/apache/arrow/pull/8256#discussion_r494775915
##
File path: r/src/compute.cpp
##
@@ -123,19 +123,19 @@ arrow::Datum as_cpp(SEXP x) {
SEXP from_datum(arrow::Datum datum) {
Review comment:
cyb70289 commented on pull request #8269:
URL: https://github.com/apache/arrow/pull/8269#issuecomment-698754806
Dev / Lint ci failure looks not related.
```
INFO:archery:Running Docker linter
apache-rat license violation: go/arrow/flight/Flight_grpc.pb.go
apache-rat license
romainfrancois commented on a change in pull request #8256:
URL: https://github.com/apache/arrow/pull/8256#discussion_r494783594
##
File path: r/R/compute.R
##
@@ -127,15 +127,15 @@ match_arrow.Array <- function(x, table, ...) {
if (!inherits(table, c("Array",
romainfrancois edited a comment on pull request #8256:
URL: https://github.com/apache/arrow/pull/8256#issuecomment-698808913
``` r
library(tidyverse)
brio::read_lines("~/git/apache/arrow/r/src/arrowExports.cpp") %>%
str_subset("^std::[a-z]+_ptr<") %>%
str_remove("
romainfrancois commented on pull request #8256:
URL: https://github.com/apache/arrow/pull/8256#issuecomment-698808913
``` r
library(tidyverse)
brio::read_lines("~/git/apache/arrow/r/src/arrowExports.cpp") %>%
str_subset("^std::[a-z]+_ptr<") %>%
str_remove(" .*$") %>%
xubinlaile opened a new issue #8270:
URL: https://github.com/apache/arrow/issues/8270
i use
pa.RecordBatch.from_pandas(df) met an error ,as the picture
show
josiahyan commented on pull request #8214:
URL: https://github.com/apache/arrow/pull/8214#issuecomment-698863342
@liyafan82 thanks for the detailed review!
This is an automated message from the Apache Git Service.
To respond
emkornfield merged pull request #8268:
URL: https://github.com/apache/arrow/pull/8268
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
cyb70289 edited a comment on pull request #8269:
URL: https://github.com/apache/arrow/pull/8269#issuecomment-698754806
Dev / Lint ci failure looks not related.
```
INFO:archery:Running Docker linter
apache-rat license violation: go/arrow/flight/Flight_grpc.pb.go
apache-rat
josiahyan commented on pull request #8214:
URL: https://github.com/apache/arrow/pull/8214#issuecomment-698085225
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
github-actions[bot] commented on pull request #8262:
URL: https://github.com/apache/arrow/pull/8262#issuecomment-698514562
https://issues.apache.org/jira/browse/ARROW-10040
This is an automated message from the Apache Git
github-actions[bot] commented on pull request #8251:
URL: https://github.com/apache/arrow/pull/8251#issuecomment-698083388
https://issues.apache.org/jira/browse/ARROW-10075
This is an automated message from the Apache Git
nealrichardson closed pull request #8187:
URL: https://github.com/apache/arrow/pull/8187
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
github-actions[bot] commented on pull request #8258:
URL: https://github.com/apache/arrow/pull/8258#issuecomment-698378613
https://issues.apache.org/jira/browse/ARROW-9769
This is an automated message from the Apache Git
nealrichardson commented on a change in pull request #8197:
URL: https://github.com/apache/arrow/pull/8197#discussion_r494396737
##
File path: r/R/ipc_stream.R
##
@@ -90,16 +90,18 @@ write_to_raw <- function(x, format = c("stream", "file")) {
#' open.
#' @param as_data_frame
zeroshade commented on pull request #8175:
URL: https://github.com/apache/arrow/pull/8175#issuecomment-698560159
@wesm @sbinet @stuartcarnie @mindhash bump
This is an automated message from the Apache Git Service.
To respond
bkietz commented on a change in pull request #8261:
URL: https://github.com/apache/arrow/pull/8261#discussion_r494491830
##
File path: cpp/src/arrow/filesystem/s3fs.cc
##
@@ -459,6 +459,24 @@ class S3Client : public Aws::S3::S3Client {
}
};
+// In AWS SDK < 1.8,
pitrou closed pull request #8219:
URL: https://github.com/apache/arrow/pull/8219
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
pitrou closed pull request #8253:
URL: https://github.com/apache/arrow/pull/8253
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
pitrou closed pull request #8250:
URL: https://github.com/apache/arrow/pull/8250
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
pitrou commented on a change in pull request #8219:
URL: https://github.com/apache/arrow/pull/8219#discussion_r494170006
##
File path: cpp/src/parquet/column_writer.cc
##
@@ -1130,37 +1188,61 @@ class TypedColumnWriterImpl : public ColumnWriterImpl,
public TypedColumnWriter<
github-actions[bot] commented on pull request #8254:
URL: https://github.com/apache/arrow/pull/8254#issuecomment-698218312
Thanks for opening a pull request!
Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW
Then
wesm opened a new pull request #8272:
URL: https://github.com/apache/arrow/pull/8272
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
kszucs opened a new pull request #8273:
URL: https://github.com/apache/arrow/pull/8273
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
kszucs closed pull request #8238:
URL: https://github.com/apache/arrow/pull/8238
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
jorisvandenbossche commented on pull request #8255:
URL: https://github.com/apache/arrow/pull/8255#issuecomment-698878811
> I was using that functionality. So I'm interested to see how I can replace
it.
And so I am interested to understand how you were using it, to know what to
maartenbreddels opened a new pull request #8271:
URL: https://github.com/apache/arrow/pull/8271
Contains:
* split_pattern kernel with max_split and reverse option
* split_whitespace_ascii similar to Python's bytes.split
* split_whitespace_utf8 similar to Python's str.split
github-actions[bot] commented on pull request #8256:
URL: https://github.com/apache/arrow/pull/8256#issuecomment-698302396
https://issues.apache.org/jira/browse/ARROW-9001
This is an automated message from the Apache Git
pitrou commented on pull request #8257:
URL: https://github.com/apache/arrow/pull/8257#issuecomment-698422412
Feel free to merge when done @xhochy
This is an automated message from the Apache Git Service.
To respond to the
github-actions[bot] commented on pull request #8268:
URL: https://github.com/apache/arrow/pull/8268#issuecomment-698712466
Thanks for opening a pull request!
Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW
Then
jorisvandenbossche commented on pull request #8255:
URL: https://github.com/apache/arrow/pull/8255#issuecomment-698297797
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
MingyuZhong commented on a change in pull request #8266:
URL: https://github.com/apache/arrow/pull/8266#discussion_r494673844
##
File path: cpp/src/arrow/util/basic_decimal.cc
##
@@ -248,40 +247,50 @@ BasicDecimal128& BasicDecimal128::operator>>=(uint32_t
bits) {
return
romainfrancois commented on pull request #8256:
URL: https://github.com/apache/arrow/pull/8256#issuecomment-698321096
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
romainfrancois commented on a change in pull request #8246:
URL: https://github.com/apache/arrow/pull/8246#discussion_r494093172
##
File path: r/tests/testthat/test-arrow.R
##
@@ -47,3 +47,12 @@ r_only({
)
})
})
+
+test_that("arrow gracefully fails to load objects
xhochy commented on pull request #8257:
URL: https://github.com/apache/arrow/pull/8257#issuecomment-698320564
@github-actions crossbow submit conda-linux-*-aarch64
This is an automated message from the Apache Git Service.
To
pitrou commented on pull request #8252:
URL: https://github.com/apache/arrow/pull/8252#issuecomment-698310908
Thank you @emkornfield !
This is an automated message from the Apache Git Service.
To respond to the message,
stuartcarnie commented on pull request #8175:
URL: https://github.com/apache/arrow/pull/8175#issuecomment-698748217
Yes, thanks!
This is an automated message from the Apache Git Service.
To respond to the message, please
pitrou commented on pull request #8259:
URL: https://github.com/apache/arrow/pull/8259#issuecomment-698400806
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
pitrou commented on pull request #8253:
URL: https://github.com/apache/arrow/pull/8253#issuecomment-698219691
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
bkietz commented on pull request #8188:
URL: https://github.com/apache/arrow/pull/8188#issuecomment-698590377
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
github-actions[bot] commented on pull request #8255:
URL: https://github.com/apache/arrow/pull/8255#issuecomment-698302399
https://issues.apache.org/jira/browse/ARROW-9518
This is an automated message from the Apache Git
wesm closed pull request #8175:
URL: https://github.com/apache/arrow/pull/8175
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
lidavidm commented on pull request #8265:
URL: https://github.com/apache/arrow/pull/8265#issuecomment-698565344
CC @rymurr, this is the other half of the earlier PR.
This is an automated message from the Apache Git Service.
liyafan82 commented on a change in pull request #8214:
URL: https://github.com/apache/arrow/pull/8214#discussion_r494118200
##
File path:
java/vector/src/main/java/org/apache/arrow/vector/BaseFixedWidthVector.java
##
@@ -48,7 +48,8 @@
implements FixedWidthVector,
github-actions[bot] commented on pull request #8259:
URL: https://github.com/apache/arrow/pull/8259#issuecomment-698405495
https://issues.apache.org/jira/browse/ARROW-10083
This is an automated message from the Apache Git
github-actions[bot] commented on pull request #8261:
URL: https://github.com/apache/arrow/pull/8261#issuecomment-698461217
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
romainfrancois commented on pull request #8246:
URL: https://github.com/apache/arrow/pull/8246#issuecomment-698219857
Is there something I can use to demangle the type name ?
``` r
arrow:::Array__length(1)
#> Error in arrow:::Array__length(1): Invalid R object for
pitrou commented on pull request #8254:
URL: https://github.com/apache/arrow/pull/8254#issuecomment-698276915
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
kszucs edited a comment on pull request #8175:
URL: https://github.com/apache/arrow/pull/8175#issuecomment-698922798
```
apache-rat license violation: go/arrow/flight/Flight_grpc.pb.go
apache-rat license violation: go/arrow/flight/example_flight_server_test.go
```
These
jhorstmann commented on a change in pull request #8260:
URL: https://github.com/apache/arrow/pull/8260#discussion_r494974111
##
File path: rust/arrow/src/compute/kernels/length.rs
##
@@ -17,52 +17,56 @@
//! Defines kernel for length of a string array
-use crate::array::*;
kszucs commented on pull request #8175:
URL: https://github.com/apache/arrow/pull/8175#issuecomment-698922798
```
apache-rat license violation: go/arrow/flight/Flight_grpc.pb.go
apache-rat license violation: go/arrow/flight/example_flight_server_test.go
```
These files
romainfrancois edited a comment on pull request #8256:
URL: https://github.com/apache/arrow/pull/8256#issuecomment-698808913
``` r
library(tidyverse)
brio::read_lines("~/git/apache/arrow/r/src/arrowExports.cpp") %>%
str_subset("^std::[a-z]+_ptr<") %>%
str_remove("
cyb70289 edited a comment on pull request #8269:
URL: https://github.com/apache/arrow/pull/8269#issuecomment-698754806
Dev / Lint ci failure looks not related.
```
INFO:archery:Running Docker linter
apache-rat license violation: go/arrow/flight/Flight_grpc.pb.go
apache-rat
bkietz commented on pull request #8261:
URL: https://github.com/apache/arrow/pull/8261#issuecomment-698588161
Passing Travis: https://travis-ci.org/github/pitrou/arrow/builds/730048965
This is an automated message from the
bkietz commented on a change in pull request #8187:
URL: https://github.com/apache/arrow/pull/8187#discussion_r494388617
##
File path: cpp/src/arrow/filesystem/filesystem.cc
##
@@ -457,18 +458,52 @@ Status CopyFiles(const std::vector& sources,
kiszk commented on pull request #8245:
URL: https://github.com/apache/arrow/pull/8245#issuecomment-698541508
Looks good.
In my environment, while `benchmark.forks` works, `benchmark.warmups` and
`benchmark.runs` do not work. In other words, the following command executes
the
github-actions[bot] commented on pull request #8265:
URL: https://github.com/apache/arrow/pull/8265#issuecomment-698569882
https://issues.apache.org/jira/browse/ARROW-9586
This is an automated message from the Apache Git
pitrou commented on a change in pull request #8187:
URL: https://github.com/apache/arrow/pull/8187#discussion_r494324838
##
File path: cpp/src/arrow/filesystem/filesystem.cc
##
@@ -457,18 +458,52 @@ Status CopyFiles(const std::vector& sources,
romainfrancois commented on a change in pull request #8256:
URL: https://github.com/apache/arrow/pull/8256#discussion_r494775017
##
File path: r/src/arrow_cpp11.h
##
@@ -310,4 +312,32 @@ enable_if_enum as_sexp(E e) {
return as_sexp(static_cast(e));
}
+template
+SEXP
nevi-me closed pull request #8129:
URL: https://github.com/apache/arrow/pull/8129
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
liyafan82 commented on pull request #8214:
URL: https://github.com/apache/arrow/pull/8214#issuecomment-698713708
@jacques-n Do you have any more comments?
This is an automated message from the Apache Git Service.
To respond
cyb70289 commented on pull request #8269:
URL: https://github.com/apache/arrow/pull/8269#issuecomment-698754806
Dev / Lint ci failure looks not related.
```
INFO:archery:Running Docker linter
apache-rat license violation: go/arrow/flight/Flight_grpc.pb.go
apache-rat license
bkietz commented on a change in pull request #8246:
URL: https://github.com/apache/arrow/pull/8246#discussion_r494456605
##
File path: r/src/arrow_cpp11.h
##
@@ -157,8 +157,15 @@ struct ns {
template
Pointer r6_to_pointer(SEXP self) {
- return reinterpret_cast(
-
github-actions[bot] commented on pull request #8271:
URL: https://github.com/apache/arrow/pull/8271#issuecomment-698894038
https://issues.apache.org/jira/browse/ARROW-9991
This is an automated message from the Apache Git
xhochy closed pull request #8257:
URL: https://github.com/apache/arrow/pull/8257
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
nealrichardson commented on pull request #8261:
URL: https://github.com/apache/arrow/pull/8261#issuecomment-698499743
@github-actions crossbow submit homebrew-r-autobrew
This is an automated message from the Apache Git
kiszk edited a comment on pull request #8245:
URL: https://github.com/apache/arrow/pull/8245#issuecomment-698541508
Thank you. Looks good.
In my environment, while `benchmark.forks` works, `benchmark.warmups` and
`benchmark.runs` do not work. In other words, the following command
pitrou closed pull request #8252:
URL: https://github.com/apache/arrow/pull/8252
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
github-actions[bot] commented on pull request #8263:
URL: https://github.com/apache/arrow/pull/8263#issuecomment-698551795
https://issues.apache.org/jira/browse/ARROW-10086
This is an automated message from the Apache Git
pitrou closed pull request #8232:
URL: https://github.com/apache/arrow/pull/8232
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
romainfrancois commented on a change in pull request #8197:
URL: https://github.com/apache/arrow/pull/8197#discussion_r494325934
##
File path: r/R/ipc_stream.R
##
@@ -90,16 +90,18 @@ write_to_raw <- function(x, format = c("stream", "file")) {
#' open.
#' @param as_data_frame
nealrichardson commented on pull request #8256:
URL: https://github.com/apache/arrow/pull/8256#issuecomment-698445894
> So in short we would create the R6 object in C++ and don't have to
manipulate the external pointers in R ?
Ideally, right?
> We would retain the same
josiahyan commented on a change in pull request #8214:
URL: https://github.com/apache/arrow/pull/8214#discussion_r494256371
##
File path:
java/vector/src/main/java/org/apache/arrow/vector/BaseFixedWidthVector.java
##
@@ -48,7 +48,8 @@
implements FixedWidthVector,
dhirschfeld commented on pull request #8255:
URL: https://github.com/apache/arrow/pull/8255#issuecomment-698636329
Thanks for the ping. I was using that functionality. So I'm interested to
see how I can replace it.
My goal is to pass objects (mapping of arrays, dataframes and
emkornfield commented on pull request #8259:
URL: https://github.com/apache/arrow/pull/8259#issuecomment-698423036
+1. Not in front my personal computer but I can merge later if you don't
get to it first.
This is an
pitrou commented on pull request #8261:
URL: https://github.com/apache/arrow/pull/8261#issuecomment-698479206
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
github-actions[bot] commented on pull request #8273:
URL: https://github.com/apache/arrow/pull/8273#issuecomment-698936382
https://issues.apache.org/jira/browse/ARROW-10092
This is an automated message from the Apache Git
pitrou closed pull request #8209:
URL: https://github.com/apache/arrow/pull/8209
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
ggershinsky commented on a change in pull request #8023:
URL: https://github.com/apache/arrow/pull/8023#discussion_r494067420
##
File path: cpp/src/parquet/encryption/properties_driven_crypto_factory.h
##
@@ -0,0 +1,205 @@
+// Licensed to the Apache Software Foundation (ASF)
github-actions[bot] commented on pull request #8266:
URL: https://github.com/apache/arrow/pull/8266#issuecomment-698619108
Thanks for opening a pull request!
Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW
Then
nealrichardson closed pull request #8259:
URL: https://github.com/apache/arrow/pull/8259
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
github-actions[bot] commented on pull request #8264:
URL: https://github.com/apache/arrow/pull/8264#issuecomment-698561533
https://issues.apache.org/jira/browse/ARROW-8618
This is an automated message from the Apache Git
github-actions[bot] commented on pull request #8250:
URL: https://github.com/apache/arrow/pull/8250#issuecomment-698083389
https://issues.apache.org/jira/browse/ARROW-10074
This is an automated message from the Apache Git
bkietz commented on a change in pull request #8256:
URL: https://github.com/apache/arrow/pull/8256#discussion_r494467875
##
File path: r/src/compute.cpp
##
@@ -123,19 +123,19 @@ arrow::Datum as_cpp(SEXP x) {
SEXP from_datum(arrow::Datum datum) {
Review comment:
nealrichardson commented on pull request #8267:
URL: https://github.com/apache/arrow/pull/8267#issuecomment-698632120
@github-actions crossbow submit *docs
This is an automated message from the Apache Git Service.
To respond
nevi-me closed pull request #8242:
URL: https://github.com/apache/arrow/pull/8242
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
bkietz commented on pull request #8187:
URL: https://github.com/apache/arrow/pull/8187#issuecomment-698590587
Non-Apache Travis: https://travis-ci.org/github/bkietz/arrow/builds/730077798
This is an automated message from
github-actions[bot] commented on pull request #8257:
URL: https://github.com/apache/arrow/pull/8257#issuecomment-698321520
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
bkietz commented on pull request #8188:
URL: https://github.com/apache/arrow/pull/8188#issuecomment-698887227
@jorisvandenbossche PTAL
This is an automated message from the Apache Git Service.
To respond to the message,
emkornfield commented on pull request #8253:
URL: https://github.com/apache/arrow/pull/8253#issuecomment-698371159
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
github-actions[bot] commented on pull request #8260:
URL: https://github.com/apache/arrow/pull/8260#issuecomment-698461216
https://issues.apache.org/jira/browse/ARROW-10084
This is an automated message from the Apache Git
github-actions[bot] commented on pull request #8253:
URL: https://github.com/apache/arrow/pull/8253#issuecomment-698083387
https://issues.apache.org/jira/browse/ARROW-10077
This is an automated message from the Apache Git
github-actions[bot] commented on pull request #8252:
URL: https://github.com/apache/arrow/pull/8252#issuecomment-698083386
https://issues.apache.org/jira/browse/ARROW-10076
This is an automated message from the Apache Git
pitrou closed pull request #8251:
URL: https://github.com/apache/arrow/pull/8251
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
nealrichardson commented on a change in pull request #8246:
URL: https://github.com/apache/arrow/pull/8246#discussion_r494391841
##
File path: r/src/arrow_cpp11.h
##
@@ -157,8 +157,15 @@ struct ns {
template
Pointer r6_to_pointer(SEXP self) {
- return reinterpret_cast(
-
pitrou commented on a change in pull request #8261:
URL: https://github.com/apache/arrow/pull/8261#discussion_r494460508
##
File path: cpp/src/arrow/filesystem/s3fs.cc
##
@@ -459,6 +459,24 @@ class S3Client : public Aws::S3::S3Client {
}
};
+// In AWS SDK < 1.8,
nealrichardson commented on a change in pull request #8256:
URL: https://github.com/apache/arrow/pull/8256#discussion_r494402171
##
File path: r/R/compute.R
##
@@ -127,15 +127,15 @@ match_arrow.Array <- function(x, table, ...) {
if (!inherits(table, c("Array",
kiszk commented on pull request #8254:
URL: https://github.com/apache/arrow/pull/8254#issuecomment-698309732
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
1 - 100 of 198 matches
Mail list logo
