[GitHub] [arrow] Bei-z commented on a change in pull request #8542: ARROW-10407: [C++] Add BasicDecimal256 Division Support

2020-11-11 Thread GitBox
Bei-z commented on a change in pull request #8542: URL: https://github.com/apache/arrow/pull/8542#discussion_r521719927 ## File path: cpp/src/arrow/util/decimal_test.cc ## @@ -1296,6 +1296,56 @@ TEST(Decimal256Test, Multiply) { } } +TEST(Decimal256Test, Divide) { +

[GitHub] [arrow] ivotron opened a new pull request #8647: ARROW-10549: [C++][Dataset] RADOS dataset

2020-11-11 Thread GitBox
ivotron opened a new pull request #8647: URL: https://github.com/apache/arrow/pull/8647 This PR contains a basic implementation of the Dataset API on Ceph that uses the librados C++ API to defer evaluation of expressions to a RADOS storage backend. The storage-side code is included, as

[GitHub] [arrow] nealrichardson edited a comment on pull request #8256: ARROW-9001: [R] Box outputs as correct type in call_function

2020-11-11 Thread GitBox
nealrichardson edited a comment on pull request #8256: URL: https://github.com/apache/arrow/pull/8256#issuecomment-725644439 @kszucs For some reason the `test-r-linux-as-cran` job (branch) isn't being created on crossbow. Unfortunately the crossbow output (e.g.

[GitHub] [arrow] nealrichardson closed pull request #8579: ARROW-10481: [R] Bindings to add, remove, replace Table columns

2020-11-11 Thread GitBox
nealrichardson closed pull request #8579: URL: https://github.com/apache/arrow/pull/8579 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [arrow] github-actions[bot] commented on pull request #8644: [WIP] Align written buffers to specified value

2020-11-11 Thread GitBox
github-actions[bot] commented on pull request #8644: URL: https://github.com/apache/arrow/pull/8644#issuecomment-725703424 Thanks for opening a pull request! Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW Then

[GitHub] [arrow] carols10cents commented on pull request #8641: ARROW-8853: [Rust] [Integration Testing] Enable Flight tests

2020-11-11 Thread GitBox
carols10cents commented on pull request #8641: URL: https://github.com/apache/arrow/pull/8641#issuecomment-725647689 The archery unit tests [are failing with this error](https://github.com/apache/arrow/pull/8641/checks?check_run_id=1386664293#step:7:19): ``` E ImportError:

[GitHub] [arrow] nealrichardson opened a new pull request #8643: ARROW-10522: [R] Allow rename Table and RecordBatch columns with names()

2020-11-11 Thread GitBox
nealrichardson opened a new pull request #8643: URL: https://github.com/apache/arrow/pull/8643 Replaces #8616, which I accidentally git broke. cc @ianmcook This is an automated message from the Apache Git Service. To respond

[GitHub] [arrow] wesm commented on a change in pull request #7507: ARROW-8797: [C++] Read RecordBatch in a different endian

2020-11-11 Thread GitBox
wesm commented on a change in pull request #7507: URL: https://github.com/apache/arrow/pull/7507#discussion_r521655583 ## File path: cpp/src/arrow/type.h ## @@ -1604,13 +1605,26 @@ class ARROW_EXPORT FieldRef { //

[GitHub] [arrow] vertexclique commented on pull request #8635: ARROW-10551: [Rust] Fix unreproducible benches

2020-11-11 Thread GitBox
vertexclique commented on pull request #8635: URL: https://github.com/apache/arrow/pull/8635#issuecomment-725714558 @alamb I am unsure about the seedable_rng behavior right now. But let's go with this one. You can check the results here:

[GitHub] [arrow] github-actions[bot] commented on pull request #8645: ARROW-10561: [Rust] Small simplification of `write` and `write_bytes`

2020-11-11 Thread GitBox
github-actions[bot] commented on pull request #8645: URL: https://github.com/apache/arrow/pull/8645#issuecomment-725727007 https://issues.apache.org/jira/browse/ARROW-10561 This is an automated message from the Apache Git

[GitHub] [arrow] nealrichardson commented on pull request #8256: ARROW-9001: [R] Box outputs as correct type in call_function

2020-11-11 Thread GitBox
nealrichardson commented on pull request #8256: URL: https://github.com/apache/arrow/pull/8256#issuecomment-725644439 @kszucs For some reason the `test-r-linux-as-cran` job (branch) isn't being created on crossbow. Unfortunately the crossbow output (e.g.

[GitHub] [arrow] github-actions[bot] commented on pull request #8643: ARROW-10522: [R] Allow rename Table and RecordBatch columns with names()

2020-11-11 Thread GitBox
github-actions[bot] commented on pull request #8643: URL: https://github.com/apache/arrow/pull/8643#issuecomment-725660537 https://issues.apache.org/jira/browse/ARROW-10522 This is an automated message from the Apache Git

[GitHub] [arrow] kou commented on pull request #8256: ARROW-9001: [R] Box outputs as correct type in call_function

2020-11-11 Thread GitBox
kou commented on pull request #8256: URL: https://github.com/apache/arrow/pull/8256#issuecomment-725660754 FYI: https://github.com/apache/arrow/pull/8386#issuecomment-725085209 This is an automated message from the Apache

[GitHub] [arrow] njwhite opened a new pull request #8644: [WIP] Align written buffers to specified value

2020-11-11 Thread GitBox
njwhite opened a new pull request #8644: URL: https://github.com/apache/arrow/pull/8644 See mailing list discussion for now This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [arrow] cyb70289 commented on a change in pull request #8637: ARROW-10021: [C++][Compute] Return top-n modes in mode kernel

2020-11-11 Thread GitBox
cyb70289 commented on a change in pull request #8637: URL: https://github.com/apache/arrow/pull/8637#discussion_r521776788 ## File path: docs/source/cpp/compute.rst ## @@ -140,7 +140,7 @@ Aggregations

[GitHub] [arrow] jorgecarleitao closed pull request #8639: ARROW-10559: [Rust][DataFusion] Split up logical_plan/mod.rs into sub modules

2020-11-11 Thread GitBox
jorgecarleitao closed pull request #8639: URL: https://github.com/apache/arrow/pull/8639 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [arrow] github-actions[bot] commented on pull request #8647: ARROW-10549: [C++][Dataset] RADOS dataset

2020-11-11 Thread GitBox
github-actions[bot] commented on pull request #8647: URL: https://github.com/apache/arrow/pull/8647#issuecomment-725759470 https://issues.apache.org/jira/browse/ARROW-10549 This is an automated message from the Apache Git

[GitHub] [arrow] github-actions[bot] commented on pull request #8648: ARROW-7906: [C++] Add ORC write support

2020-11-11 Thread GitBox
github-actions[bot] commented on pull request #8648: URL: https://github.com/apache/arrow/pull/8648#issuecomment-725811236 https://issues.apache.org/jira/browse/ARROW-7906 This is an automated message from the Apache Git

[GitHub] [arrow] mathyingzhou opened a new pull request #8648: ARROW-7906: [C++] Add ORC write support

2020-11-11 Thread GitBox
mathyingzhou opened a new pull request #8648: URL: https://github.com/apache/arrow/pull/8648 This pull request tracks the progress on adding ORC write support. The functionality is not complete yet. However for most types the process of populating a ColumnVectorBatch in ORC using data

[GitHub] [arrow] arw2019 commented on pull request #8294: ARROW-1846: [C++][Compute] Implement "any" reduction kernel for boolean data

2020-11-11 Thread GitBox
arw2019 commented on pull request #8294: URL: https://github.com/apache/arrow/pull/8294#issuecomment-725852668 Turning to draft while I work on the rebase This is an automated message from the Apache Git Service. To respond

[GitHub] [arrow] kiszk commented on a change in pull request #7507: ARROW-8797: [C++] Read RecordBatch in a different endian

2020-11-11 Thread GitBox
kiszk commented on a change in pull request #7507: URL: https://github.com/apache/arrow/pull/7507#discussion_r521763175 ## File path: cpp/src/arrow/type.h ## @@ -1604,13 +1605,26 @@ class ARROW_EXPORT FieldRef { //

[GitHub] [arrow] cyb70289 commented on a change in pull request #8637: ARROW-10021: [C++][Compute] Return top-n modes in mode kernel

2020-11-11 Thread GitBox
cyb70289 commented on a change in pull request #8637: URL: https://github.com/apache/arrow/pull/8637#discussion_r521865256 ## File path: cpp/src/arrow/compute/kernels/aggregate_mode.cc ## @@ -205,35 +243,59 @@ struct ModeImpl : public ScalarAggregator {

[GitHub] [arrow] cyb70289 commented on a change in pull request #8637: ARROW-10021: [C++][Compute] Return top-n modes in mode kernel

2020-11-11 Thread GitBox
cyb70289 commented on a change in pull request #8637: URL: https://github.com/apache/arrow/pull/8637#discussion_r521865103 ## File path: cpp/src/arrow/compute/api_aggregate.h ## @@ -76,6 +76,18 @@ struct ARROW_EXPORT MinMaxOptions : public FunctionOptions { enum Mode

[GitHub] [arrow] cyb70289 commented on a change in pull request #8637: ARROW-10021: [C++][Compute] Return top-n modes in mode kernel

2020-11-11 Thread GitBox
cyb70289 commented on a change in pull request #8637: URL: https://github.com/apache/arrow/pull/8637#discussion_r521865178 ## File path: cpp/src/arrow/compute/kernels/aggregate_mode.cc ## @@ -28,6 +29,9 @@ namespace internal { namespace { +constexpr char kModeFieldName[]

[GitHub] [arrow] cyb70289 commented on pull request #8637: ARROW-10021: [C++][Compute] Return top-n modes in mode kernel

2020-11-11 Thread GitBox
cyb70289 commented on pull request #8637: URL: https://github.com/apache/arrow/pull/8637#issuecomment-725891740 Python unit test failed. I'm updating mode kernel python binding per cpp changes. This is an automated message

<    1   2