[GitHub] [arrow] kou commented on a diff in pull request #33660: GH-33659: [Developer Tools] Add definition of Breaking Change and Critical Fix

2023-01-18 Thread GitBox
kou commented on code in PR #33660: URL: https://github.com/apache/arrow/pull/33660#discussion_r1080723781 ## docs/source/developers/reviewing.rst: ## @@ -255,3 +255,43 @@ Social aspects * Like any communication, code reviews are governed by the Apache `Code of Conduct

[GitHub] [arrow-datafusion-python] andygrove opened a new issue, #138: Add example that calls a Python UDF from SQL

2023-01-18 Thread GitBox
andygrove opened a new issue, #138: URL: https://github.com/apache/arrow-datafusion-python/issues/138 **Is your feature request related to a problem or challenge? Please describe what you are trying to do.** Add example that calls a Python UDF from SQL **Describe the solution you'd

[GitHub] [arrow] kou commented on issue #33773: [Docs][Release] Add vcpkg-port update script to release magement guide

2023-01-18 Thread GitBox
kou commented on issue #33773: URL: https://github.com/apache/arrow/issues/33773#issuecomment-1396333470 Ah, sorry. I forgot this. Could you work on this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [arrow] ava6969 commented on issue #33747: [C++] Published new library panda-apache

2023-01-18 Thread GitBox
ava6969 commented on issue #33747: URL: https://github.com/apache/arrow/issues/33747#issuecomment-1396337269 thanks just did -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [arrow] kou commented on issue #33733: [Packaging] Amazon Linux 2 RPMs - openssl-devel cannot coexist with openssl11-devel and breaks installing arrow-devel

2023-01-18 Thread GitBox
kou commented on issue #33733: URL: https://github.com/apache/arrow/issues/33733#issuecomment-1396338565 OK. We can remove `arrow-devel` after we install `red-arrow` gem. Does `gem install red-arrow && yum remove -y arrow-devel` work with your use case? -- This is an automated message fro

[GitHub] [arrow] westonpace commented on pull request #33738: GH-33737: [C++] simplify exec plan tracing

2023-01-18 Thread GitBox
westonpace commented on PR #33738: URL: https://github.com/apache/arrow/pull/33738#issuecomment-1396340861 Here's a trace from a dataset write. There are still things that could be cleaned up here. Pretty much all of the `DatasetWriter::` traces are a mix of active CPU time and idle I/O t

[GitHub] [arrow] kou commented on pull request #33751: WIP: [Release] Verify release-11.0.0-rc0

2023-01-18 Thread GitBox
kou commented on PR #33751: URL: https://github.com/apache/arrow/pull/33751#issuecomment-1396345063 @github-actions crossbow submit --group verify-rc-binaries --group verify-rc-wheels --param release=11.0.0 --param rc=0 -- This is an automated message from the Apache Git Service. To resp

[GitHub] [arrow] ursabot commented on pull request #33682: GH-33681: [JS] Update flatbuffers

2023-01-18 Thread GitBox
ursabot commented on PR #33682: URL: https://github.com/apache/arrow/pull/33682#issuecomment-1396348022 Benchmark runs are scheduled for baseline = 85a111f8d5cef3a668c9cf8c47ccb943048e50f6 and contender = 627caf3fe63ef3eebd9a3eb25367e5f05cb20c00. 627caf3fe63ef3eebd9a3eb25367e5f05cb20c00 is

[GitHub] [arrow] github-actions[bot] commented on pull request #33751: WIP: [Release] Verify release-11.0.0-rc0

2023-01-18 Thread GitBox
github-actions[bot] commented on PR #33751: URL: https://github.com/apache/arrow/pull/33751#issuecomment-1396348454 Revision: f10f5cfd1376fb0e602334588b3f3624d41dee7d Submitted crossbow builds: [ursacomputing/crossbow @ actions-1f979c18ed](https://github.com/ursacomputing/crossbow/bra

[GitHub] [arrow] kou commented on pull request #33716: WIP: DO NOT MERGE: Apache Arrow Flight SQL adapter for PostgreSQL plan

2023-01-18 Thread GitBox
kou commented on PR #33716: URL: https://github.com/apache/arrow/pull/33716#issuecomment-1396362498 @alamb @jacobmarble Thanks for your comments! > It might help to start this document with an expected usecase. It makes sense. I'll add it. > I originally thought it was to

[GitHub] [arrow] lidavidm commented on pull request #33716: WIP: DO NOT MERGE: Apache Arrow Flight SQL adapter for PostgreSQL plan

2023-01-18 Thread GitBox
lidavidm commented on PR #33716: URL: https://github.com/apache/arrow/pull/33716#issuecomment-1396367552 Yes, the ADBC driver wraps libpq and should let you work with other databases that use the PostgreSQL wire protocol, with the caveat that it has to convert the data (of course).

[GitHub] [arrow] assignUser commented on pull request #33751: WIP: [Release] Verify release-11.0.0-rc0

2023-01-18 Thread GitBox
assignUser commented on PR #33751: URL: https://github.com/apache/arrow/pull/33751#issuecomment-1396368957 The pytest seg fault is also happening in verification https://github.com/ursacomputing/crossbow/actions/runs/3954649758/jobs/6772203240#step:5:2810 -- This is an automated message f

[GitHub] [arrow-rs] Frankonly opened a new pull request, #3560: Update pyarrow method call with kwargs

2023-01-18 Thread GitBox
Frankonly opened a new pull request, #3560: URL: https://github.com/apache/arrow-rs/pull/3560 # Which issue does this PR close? Closes #3543 # Rationale for this change A follow up PR of #3544 # What changes are included in this PR? Pass k

[GitHub] [arrow-rs] Frankonly commented on a diff in pull request #3544: Update pyarrow method call to avoid warning

2023-01-18 Thread GitBox
Frankonly commented on code in PR #3544: URL: https://github.com/apache/arrow-rs/pull/3544#discussion_r1080755836 ## arrow/src/pyarrow.rs: ## @@ -196,7 +196,8 @@ impl PyArrowConvert for RecordBatch { let module = py.import("pyarrow")?; let class = module.geta

[GitHub] [arrow] vibhatha commented on a diff in pull request #33725: GH-33724: [Doc] Update the substrait conformance doc with the latest support

2023-01-18 Thread GitBox
vibhatha commented on code in PR #33725: URL: https://github.com/apache/arrow/pull/33725#discussion_r1080759071 ## docs/source/cpp/streaming_execution.rst: ## @@ -113,12 +109,12 @@ Read Relations * The ``projection`` property is not supported and plans containing this pr

[GitHub] [arrow] vibhatha commented on pull request #33725: GH-33724: [Doc] Update the substrait conformance doc with the latest support

2023-01-18 Thread GitBox
vibhatha commented on PR #33725: URL: https://github.com/apache/arrow/pull/33725#issuecomment-1396374820 @westonpace seems like the CI's are unrelated to this modification. Reviews are addressed. Thank you for working on this. -- This is an automated message from the Apache Git Service. T

[GitHub] [arrow] mapleFU opened a new pull request, #33776: GH-15164: [C++][Parquet] BloomFilter fixing standard broken

2023-01-18 Thread GitBox
mapleFU opened a new pull request, #33776: URL: https://github.com/apache/arrow/pull/33776 ### Rationale for this change Previously, C++ BloomFilter is implemented in 2019, but standard change in BloomFilter, which could be seen here: https://github.com/apache/parquet

[GitHub] [arrow] github-actions[bot] commented on pull request #33776: GH-15164: [C++][Parquet] BloomFilter fixing standard broken

2023-01-18 Thread GitBox
github-actions[bot] commented on PR #33776: URL: https://github.com/apache/arrow/pull/33776#issuecomment-1396378871 * Closes: #15164 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [arrow] ziggythehamster commented on issue #33733: [Packaging] Amazon Linux 2 RPMs - openssl-devel cannot coexist with openssl11-devel and breaks installing arrow-devel

2023-01-18 Thread GitBox
ziggythehamster commented on issue #33733: URL: https://github.com/apache/arrow/issues/33733#issuecomment-1396381666 In my case, no, because I would first have to uninstall openssl11-devel (and anything already installed in my base image that depends on it) and then put it back when I'm don

[GitHub] [arrow-julia] quinnj commented on pull request #381: Tag new version dev/release/release.sh

2023-01-18 Thread GitBox
quinnj commented on PR #381: URL: https://github.com/apache/arrow-julia/pull/381#issuecomment-1396382366 This seems fine to me, but @ericphanson, are we not able to get TagBot to run for the repo? The advantages of TagBot are: * automated once the release is published in the General regis

[GitHub] [arrow] mapleFU commented on pull request #33776: GH-15164: [C++][Parquet] BloomFilter fixing standard broken

2023-01-18 Thread GitBox
mapleFU commented on PR #33776: URL: https://github.com/apache/arrow/pull/33776#issuecomment-1396382437 @pitrou @wjones127 @emkornfield Mind take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [arrow-julia] quinnj commented on issue #375: Make recursive iteration to get dictionaries more defensive for interop

2023-01-18 Thread GitBox
quinnj commented on issue #375: URL: https://github.com/apache/arrow-julia/issues/375#issuecomment-1396384853 that looks like a good fix to me; if you make a PR, that'd be great. If you have an example arrow file that exhibits the problem that we can use to test it with, even better. --

[GitHub] [arrow] wjones127 commented on a diff in pull request #33660: GH-33659: [Developer Tools] Add definition of Breaking Change and Critical Fix

2023-01-18 Thread GitBox
wjones127 commented on code in PR #33660: URL: https://github.com/apache/arrow/pull/33660#discussion_r1080767036 ## docs/source/developers/reviewing.rst: ## @@ -255,3 +255,43 @@ Social aspects * Like any communication, code reviews are governed by the Apache `Code of Conduct

[GitHub] [arrow] mapleFU commented on pull request #33776: GH-15164: [C++][Parquet] BloomFilter fixing standard broken

2023-01-18 Thread GitBox
mapleFU commented on PR #33776: URL: https://github.com/apache/arrow/pull/33776#issuecomment-1396387844 Well, why should I have a assignee but I cannot edit the description of patch? Should someone be assignee or assign this task to me? ╮( ̄▽ ̄"")╭ -- This is an automated message from the A

[GitHub] [arrow] bkmgit commented on pull request #33716: WIP: DO NOT MERGE: Apache Arrow Flight SQL adapter for PostgreSQL plan

2023-01-18 Thread GitBox
bkmgit commented on PR #33716: URL: https://github.com/apache/arrow/pull/33716#issuecomment-1396397369 What is needed for authentication? Could pluggable authentication modules be used? How often could authentication be required - in particular are there performance requirements? -- Thi

[GitHub] [arrow] kou commented on a diff in pull request #33660: GH-33659: [Developer Tools] Add definition of Breaking Change and Critical Fix

2023-01-18 Thread GitBox
kou commented on code in PR #33660: URL: https://github.com/apache/arrow/pull/33660#discussion_r1080797181 ## docs/source/developers/reviewing.rst: ## @@ -255,3 +255,43 @@ Social aspects * Like any communication, code reviews are governed by the Apache `Code of Conduct

[GitHub] [arrow] kou commented on pull request #33716: WIP: DO NOT MERGE: Apache Arrow Flight SQL adapter for PostgreSQL plan

2023-01-18 Thread GitBox
kou commented on PR #33716: URL: https://github.com/apache/arrow/pull/33716#issuecomment-1396433386 > What is needed for authentication? Integration with user information in PostgreSQL. We should not require users to configure additional authentication related things. > Could p

[GitHub] [arrow] ursabot commented on pull request #14814: GH-14875: [C++] C Data Interface: check imported buffer for non-null

2023-01-18 Thread GitBox
ursabot commented on PR #14814: URL: https://github.com/apache/arrow/pull/14814#issuecomment-1396438935 Benchmark runs are scheduled for baseline = 627caf3fe63ef3eebd9a3eb25367e5f05cb20c00 and contender = 7319250597b0f4e3b5f859eb073264ce3c72a1bd. 7319250597b0f4e3b5f859eb073264ce3c72a1bd is

[GitHub] [arrow] mapleFU commented on issue #15173: [Parquet][C++] ByteStreamSplitDecoder broken in presence of nulls

2023-01-18 Thread GitBox
mapleFU commented on issue #15173: URL: https://github.com/apache/arrow/issues/15173#issuecomment-1396461820 https://github.com/apache/arrow/issues/15173#issuecomment-1385858560 can be reproduce like this: ``` diff --git a/cpp/examples/parquet/low_level_api/reader_writer.cc b/cpp/

[GitHub] [arrow] jackwener commented on pull request #14351: GH-33115: [C++] Parquet Implement crc in reading and writing Page for DATA_PAGE (v1)

2023-01-18 Thread GitBox
jackwener commented on PR #14351: URL: https://github.com/apache/arrow/pull/14351#issuecomment-1396469562 It's a good feature. Can someone push the progress of this PR?❤️ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [arrow-datafusion] viirya commented on pull request #4963: Replace count with is_empty in Sum

2023-01-18 Thread GitBox
viirya commented on PR #4963: URL: https://github.com/apache/arrow-datafusion/pull/4963#issuecomment-1396475988 No, you're correct. The change at `retract_batch` is wrong. I don't follow how `retract_batch` works correctly. -- This is an automated message from the Apache Git Service. To

[GitHub] [arrow-rs] Sach1nAgarwal commented on issue #53: [Parquet] Reading parquet file into an ndarray

2023-01-18 Thread GitBox
Sach1nAgarwal commented on issue #53: URL: https://github.com/apache/arrow-rs/issues/53#issuecomment-1396513788 Parallel column is increasing the performance. I checked by creating multiple `ParquetRecordBatchStream` for each column and all `ParquetRecordBatchStream` reading parallely, perf

[GitHub] [arrow] Treize44 commented on issue #33759: [Python][C++] How to limit the memory consumption of to_batches()

2023-01-18 Thread GitBox
Treize44 commented on issue #33759: URL: https://github.com/apache/arrow/issues/33759#issuecomment-1396539880 I use pyarrow 10.0.1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [arrow-datafusion] mingmwang commented on pull request #4969: refactor: display input partitions for `RepartitionExec`

2023-01-18 Thread GitBox
mingmwang commented on PR #4969: URL: https://github.com/apache/arrow-datafusion/pull/4969#issuecomment-1396543284 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [arrow] ursabot commented on pull request #33728: GH-33726: [CI][Go] Set host name in Go benchmarks

2023-01-18 Thread GitBox
ursabot commented on PR #33728: URL: https://github.com/apache/arrow/pull/33728#issuecomment-1396552408 Benchmark runs are scheduled for baseline = 7319250597b0f4e3b5f859eb073264ce3c72a1bd and contender = 705e04bb15f481e476c9e7a8e2ac92460890ad0c. 705e04bb15f481e476c9e7a8e2ac92460890ad0c is

[GitHub] [arrow] mapleFU commented on pull request #33776: GH-15164: [C++][Parquet] BloomFilter fixing standard broken

2023-01-18 Thread GitBox
mapleFU commented on PR #33776: URL: https://github.com/apache/arrow/pull/33776#issuecomment-1396555264 I generate a test file, and update it here: https://github.com/apache/parquet-testing/pull/34 You can merge that. And after that, we can run testing here. -- This is an automated

[GitHub] [arrow-datafusion] mingmwang commented on pull request #4767: Move subquery alias assignment onto rules

2023-01-18 Thread GitBox
mingmwang commented on PR #4767: URL: https://github.com/apache/arrow-datafusion/pull/4767#issuecomment-1396574575 One question regarding the Subquery Alias generation logic: Why does the `InSubquery` generate a Subquery Alias, but the `Exists` Subquery does not ? -- This is an

<    1   2   3   4   5