github-actions[bot] commented on pull request #7133:
URL: https://github.com/apache/arrow/pull/7133#issuecomment-626115360
https://issues.apache.org/jira/browse/ARROW-8744
This is an automated message from the Apache Git Serv
houqp opened a new pull request #7133:
URL: https://github.com/apache/arrow/pull/7133
Once reached end of iteration, calling next on ParquetIterator will
result in an error. This is inconvenient in two ways:
* when shared between multiple threads, only one of the thread will be
emkornfield commented on pull request #6985:
URL: https://github.com/apache/arrow/pull/6985#issuecomment-626100172
@pitrou did you want to take another look?
@nealrichardson should I hold off until we an revert the change to see if
the test still fails?
kou commented on pull request #7131:
URL: https://github.com/apache/arrow/pull/7131#issuecomment-626095079
OK. I'll merge this once remaining GitHub Actions jobs are passed.
This is an automated message from the Apache Git Se
kiszk commented on pull request #7131:
URL: https://github.com/apache/arrow/pull/7131#issuecomment-626094759
Yes, I think that it is a good starting point.
I have a patch to fix failures at `rle_encoding_test.cc` in my environment.
In my local environment, I used the option `cmake -
kou commented on pull request #7131:
URL: https://github.com/apache/arrow/pull/7131#issuecomment-626093743
> Other candidates look `ARROW_PYTHON` and `ARROW_S3`. Does it make sense?
They are already disabled by default:
https://travis-ci.org/github/apache/arrow/builds/684931696#L1496
kou commented on pull request #7131:
URL: https://github.com/apache/arrow/pull/7131#issuecomment-626093641
Done: https://travis-ci.org/github/apache/arrow/builds/684931696
There are many failure outputs from
`cpp/src/arrow/util/rle_encoding_test.cc`. It's a core component. We can't
kiszk commented on pull request #7131:
URL: https://github.com/apache/arrow/pull/7131#issuecomment-626093493
Thank you very much!
Other candidates look `ARROW_PYTHON` and `ARROW_S3`. Does it make sense?
This is an automate
kou commented on pull request #7131:
URL: https://github.com/apache/arrow/pull/7131#issuecomment-626089457
Sure. I'll reduce enabled options.
This is an automated message from the Apache Git Service.
To respond to the message
kiszk commented on pull request #7131:
URL: https://github.com/apache/arrow/pull/7131#issuecomment-626087155
One question. Can we enable options step-by-step, too? For example, can we
customize `ENV ...` at
https://github.com/apache/arrow/pull/7131/commits/5d6617c4a26be2983336e1baba1a16eff
kiszk commented on pull request #7131:
URL: https://github.com/apache/arrow/pull/7131#issuecomment-626083632
@kou Thank you. I am happy to fix them.
This is an automated message from the Apache Git Service.
To respond to the
scampi commented on a change in pull request #6402:
URL: https://github.com/apache/arrow/pull/6402#discussion_r422419677
##
File path:
java/vector/src/main/java/org/apache/arrow/vector/BaseVariableWidthVector.java
##
@@ -740,10 +740,16 @@ private void splitAndTransferOffsetBuf
github-actions[bot] commented on pull request #7132:
URL: https://github.com/apache/arrow/pull/7132#issuecomment-626051893
https://issues.apache.org/jira/browse/ARROW-3509
This is an automated message from the Apache Git Serv
emkornfield opened a new pull request #7132:
URL: https://github.com/apache/arrow/pull/7132
I think there is potentially more consolidaion on the builders but this
seems like a reasonable place to make the PR.
This is an aut
github-actions[bot] commented on pull request #7131:
URL: https://github.com/apache/arrow/pull/7131#issuecomment-626024349
https://issues.apache.org/jira/browse/ARROW-8743
This is an automated message from the Apache Git Serv
kou commented on pull request #7131:
URL: https://github.com/apache/arrow/pull/7131#issuecomment-626022318
@kiszk Do you want to work on fixing test failures step-by-step as follow-up
tasks?
This is an automated message from
kou opened a new pull request #7131:
URL: https://github.com/apache/arrow/pull/7131
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
wesm commented on a change in pull request #7120:
URL: https://github.com/apache/arrow/pull/7120#discussion_r422371276
##
File path: cpp/src/arrow/util/value_parsing.h
##
@@ -484,6 +455,14 @@ static inline bool ParseHH_MM_SS(const char* s,
std::chrono::duration*
} // names
wesm commented on pull request #7120:
URL: https://github.com/apache/arrow/pull/7120#issuecomment-626009344
That’s fine. In general, introducing “nuisance” requirements for simple
cases doesn’t seem like a good habit
This i
kou commented on pull request #7118:
URL: https://github.com/apache/arrow/pull/7118#issuecomment-626002577
+1
Failures on uploading artifacts are unrelated.
This is an automated message from the Apache Git Service.
To resp
bkietz commented on a change in pull request #7120:
URL: https://github.com/apache/arrow/pull/7120#discussion_r422353994
##
File path: cpp/src/arrow/util/value_parsing.h
##
@@ -484,6 +455,14 @@ static inline bool ParseHH_MM_SS(const char* s,
std::chrono::duration*
} // nam
github-actions[bot] commented on pull request #7130:
URL: https://github.com/apache/arrow/pull/7130#issuecomment-625999819
https://issues.apache.org/jira/browse/ARROW-8742
This is an automated message from the Apache Git Serv
github-actions[bot] commented on pull request #7130:
URL: https://github.com/apache/arrow/pull/7130#issuecomment-625993735
Thanks for opening a pull request!
Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW
Then could
erinleeryan opened a new pull request #7130:
URL: https://github.com/apache/arrow/pull/7130
Our team would like to implement mutual tls authentication for a pyarrow
client, hence modifications to the C++ and Python implementations to at a
GrpcMTls scheme for connections.
wesm commented on pull request #6617:
URL: https://github.com/apache/arrow/pull/6617#issuecomment-625973437
+1, sorry for the delay in merging this
This is an automated message from the Apache Git Service.
To respond to the m
wesm commented on pull request #7120:
URL: https://github.com/apache/arrow/pull/7120#issuecomment-625970866
I left the `ParseValue` API as is and addressed the other comments. Since
this is internal-only code would it be alright to call it a day on this? If
someone wants to make more chang
wesm commented on a change in pull request #7120:
URL: https://github.com/apache/arrow/pull/7120#discussion_r422314767
##
File path: cpp/src/arrow/util/value_parsing.h
##
@@ -484,6 +455,14 @@ static inline bool ParseHH_MM_SS(const char* s,
std::chrono::duration*
} // names
emkornfield edited a comment on pull request #7110:
URL: https://github.com/apache/arrow/pull/7110#issuecomment-625963511
> I'm not sure what you mean by non-official function, though. Could you
expand on that?
Sorry, I meant not something that is supported officially in the IPC for
emkornfield commented on pull request #7110:
URL: https://github.com/apache/arrow/pull/7110#issuecomment-625963511
> I'm not sure what you mean by non-official function, though. Could you
expand on that?
Sorry, I meant not something that is supported officially in the IPC format
specif
chrish42 commented on pull request #7110:
URL: https://github.com/apache/arrow/pull/7110#issuecomment-625943409
I'd also prefer not to add anything to the JSON, but I was raising that
option because there were concerns about maintaining compatibility in the past
when I initially raised thi
bkietz commented on a change in pull request #7120:
URL: https://github.com/apache/arrow/pull/7120#discussion_r422259138
##
File path: cpp/src/arrow/util/value_parsing.cc
##
@@ -43,46 +44,43 @@ struct StringToFloatConverter::Impl {
util::double_conversion::StringToDoubleConv
github-actions[bot] commented on pull request #7129:
URL: https://github.com/apache/arrow/pull/7129#issuecomment-625887076
https://issues.apache.org/jira/browse/ARROW-8741
This is an automated message from the Apache Git Serv
github-actions[bot] commented on pull request #7129:
URL: https://github.com/apache/arrow/pull/7129#issuecomment-625875967
Revision: 2b729afa7900059a153769086a7fbb331be821f5
Submitted crossbow builds: [ursa-labs/crossbow @
actions-219](https://github.com/ursa-labs/crossbow/branches/a
kszucs commented on pull request #7129:
URL: https://github.com/apache/arrow/pull/7129#issuecomment-625875315
@github-actions crossbow submit wheel-win-cp36m
This is an automated message from the Apache Git Service.
To respon
wesm commented on issue #7127:
URL: https://github.com/apache/arrow/issues/7127#issuecomment-625862341
Hi could you please open a JIRA issue?
This is an automated message from the Apache Git Service.
To respond to the message
github-actions[bot] commented on pull request #7129:
URL: https://github.com/apache/arrow/pull/7129#issuecomment-625851764
Revision: 13b3c2c9b54147d26bac38dfdf624d63984ab278
Submitted crossbow builds: [ursa-labs/crossbow @
actions-218](https://github.com/ursa-labs/crossbow/branches/a
kszucs commented on pull request #7129:
URL: https://github.com/apache/arrow/pull/7129#issuecomment-625851074
@github-actions crossbow submit wheel-win-cp36m
This is an automated message from the Apache Git Service.
To respon
github-actions[bot] commented on pull request #7129:
URL: https://github.com/apache/arrow/pull/7129#issuecomment-625825788
Revision: 7db00e5112ded499d0bb3c40effe0e9608d4ba8f
Submitted crossbow builds: [ursa-labs/crossbow @
actions-217](https://github.com/ursa-labs/crossbow/branches/a
kszucs commented on pull request #7129:
URL: https://github.com/apache/arrow/pull/7129#issuecomment-625824968
@github-actions crossbow submit wheel-win-cp36m
This is an automated message from the Apache Git Service.
To respon
github-actions[bot] commented on pull request #7113:
URL: https://github.com/apache/arrow/pull/7113#issuecomment-625817459
https://issues.apache.org/jira/browse/ARROW-8740
This is an automated message from the Apache Git Serv
github-actions[bot] commented on pull request #7129:
URL: https://github.com/apache/arrow/pull/7129#issuecomment-625807095
Revision: 6109c0a9d8ada6201d616561233253ac51814ec4
Submitted crossbow builds: [ursa-labs/crossbow @
actions-216](https://github.com/ursa-labs/crossbow/branches/a
kszucs commented on pull request #7129:
URL: https://github.com/apache/arrow/pull/7129#issuecomment-625806490
@github-actions crossbow submit wheel-win-cp36m
This is an automated message from the Apache Git Service.
To respon
lidavidm commented on pull request #6617:
URL: https://github.com/apache/arrow/pull/6617#issuecomment-625800808
Rebased again to fix merge conflicts.
This is an automated message from the Apache Git Service.
To respond to the
github-actions[bot] commented on pull request #7129:
URL: https://github.com/apache/arrow/pull/7129#issuecomment-625789258
Revision: baa6c77e9e2b67f99a32da27c04cb94e67b08c7a
Submitted crossbow builds: [ursa-labs/crossbow @
actions-215](https://github.com/ursa-labs/crossbow/branches/a
kszucs opened a new pull request #7129:
URL: https://github.com/apache/arrow/pull/7129
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
kszucs commented on pull request #7129:
URL: https://github.com/apache/arrow/pull/7129#issuecomment-625787449
@github-actions crossbow submit wheel-win-cp36m
This is an automated message from the Apache Git Service.
To respo
kszucs commented on pull request #7080:
URL: https://github.com/apache/arrow/pull/7080#issuecomment-625771425
@pitrou I guess we shouldn't block on the infra ticket.
This is an automated message from the Apache Git Service.
T
kszucs commented on a change in pull request #7080:
URL: https://github.com/apache/arrow/pull/7080#discussion_r422091054
##
File path: ci/appveyor-cpp-build.bat
##
@@ -17,114 +17,146 @@
@echo on
-@rem In release mode, disable optimizations (/Od) for faster compiling
-set C
rymurr commented on a change in pull request #7100:
URL: https://github.com/apache/arrow/pull/7100#discussion_r422081471
##
File path:
java/memory/src/test/java/org/apache/arrow/memory/ITTestLargeArrowBuf.java
##
@@ -27,38 +32,45 @@
* main method.
*
*/
-public class T
rymurr commented on pull request #7095:
URL: https://github.com/apache/arrow/pull/7095#issuecomment-625760957
> This looks good to me. +1.
>
> > In the past adding a getUnsafe method was discussed. What do you think
about that?
>
> This ensures that the all methods are consist
rymurr commented on a change in pull request #7100:
URL: https://github.com/apache/arrow/pull/7100#discussion_r422079081
##
File path:
java/vector/src/test/java/org/apache/arrow/vector/ITTestLargeVector.java
##
@@ -45,32 +47,33 @@ private static void testLargeLongVector() {
rymurr commented on pull request #7100:
URL: https://github.com/apache/arrow/pull/7100#issuecomment-625759852
> I suggest we do a separate failsafe invocation for the one test with
specifalized system property requirements rather than applying those settings
for all tests.
done
--
github-actions[bot] commented on pull request #7128:
URL: https://github.com/apache/arrow/pull/7128#issuecomment-625757285
https://issues.apache.org/jira/browse/ARROW-8722
This is an automated message from the Apache Git Serv
rymurr commented on a change in pull request #7101:
URL: https://github.com/apache/arrow/pull/7101#discussion_r422074255
##
File path:
java/memory/src/main/java/org/apache/arrow/memory/util/hash/SimpleHasher.java
##
@@ -58,21 +56,21 @@ public int hashCode(long address, long le
rymurr commented on a change in pull request #7101:
URL: https://github.com/apache/arrow/pull/7101#discussion_r422074255
##
File path:
java/memory/src/main/java/org/apache/arrow/memory/util/hash/SimpleHasher.java
##
@@ -58,21 +56,21 @@ public int hashCode(long address, long le
rymurr commented on a change in pull request #7101:
URL: https://github.com/apache/arrow/pull/7101#discussion_r422074255
##
File path:
java/memory/src/main/java/org/apache/arrow/memory/util/hash/SimpleHasher.java
##
@@ -58,21 +56,21 @@ public int hashCode(long address, long le
kszucs opened a new pull request #7128:
URL: https://github.com/apache/arrow/pull/7128
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
tianchen92 commented on pull request #6433:
URL: https://github.com/apache/arrow/pull/6433#issuecomment-625704614
> I think it would be good to have a set of tests ensuring that the behavior
of the empty buffer is consistent. For example, refcnt, release/allocate, etc.
That way, if someone
domiden opened a new issue #7127:
URL: https://github.com/apache/arrow/issues/7127
First at all, many thanks for your hard work! I was quite exited, when you
guys implemented some basic function of the the `dplyr` package. Is there a why
to combine tow or more arrow tables into one by rows
59 matches
Mail list logo